Skip to contentSkip to conversation

arm64: tegra: Fix Tegra234 PCIe interrupt-map

PATCH Applied Brad Griffis 2 participants 2 messages Dec 13, 2024 – Jan 10, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: tegra: Fix Tegra234 PCIe interrupt-map

For interrupt-map entries, the DTS specification requires that #address-cells is defined for both the child node and the interrupt parent. For the PCIe interrupt-map entries, the parent node ("gic") has not specified #address-cells. The existing layout of the PCIe interrupt-map entries indicates that it assumes that #address-cells is zero for this node.

Explicitly set #address-cells to zero for "gic" so that it complies with the device tree specification.

NVIDIA EDK2 works around this issue by assuming #address-cells is zero in this scenario, but that workaround is being removed and so this update is needed or else NVIDIA EDK2 cannot successfully parse the device tree and the board cannot boot.

Fixes ec142c44b026 ("arm64: tegra: Add P2U and PCIe controller nodes to Tegra234 DT")

---

v2
* Add "Fixes" and CC stable
* Give further context about why the patch is needed

 arch/arm64/boot/dts/nvidia/tegra234.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +1 -0
index 984c85eab41a..e1c07c99e9bd 100644
@@ -4010,6 +4010,7 @@ ccplex@e000000 {
 
 		gic: interrupt-controller@f400000 {
 			compatible = "arm,gic-v3";
+			#address-cells = <0>;
 			reg = <0x0 0x0f400000 0x0 0x010000>, /* GICD */
 			      <0x0 0x0f440000 0x0 0x200000>; /* GICR */
 			interrupt-parent = <&gic>;
Signature · 1 line
2.34.1
#1 lore raw

From: Thierry Reding <[email protected]>

Quoted 8 lines · Brad Griffis

For interrupt-map entries, the DTS specification requires that #address-cells is defined for both the child node and the interrupt parent. For the PCIe interrupt-map entries, the parent node ("gic") has not specified #address-cells. The existing layout of the PCIe interrupt-map entries indicates that it assumes that #address-cells is zero for this node.

[...]

Applied, thanks!

[1/1] arm64: tegra: Fix Tegra234 PCIe interrupt-map
(no commit info)

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>