nand-utils: Fix integer overflow in nandflipbits.c
PATCH 1/1 nand-utils: Fix integer overflow in nandflipbits.c
Report of the static analyzer:
The value of an arithmetic expression 'bit_to_flip->block * mtd.eb_size + blkoffs' is a subject to overflow because its operands are not cast to a larger data type before performing arith$
Corrections explained:
Prevent arithmetic overflow in OOB read operation
Resolved an issue where the calculation of the offset in the OOB read operation could overflow due to operands not being cast to a larger data type. Specifically, the multiplication of bi$
Triggers found by static analyzer Svace.
--- nand-utils/nandflipbits.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
nand-utils/nandflipbits.c +1 -1
@@ -251,7 +251,7 @@ int main(int argc, char **argv) bufoffs += mtd.min_io_size; ret =mtd_read_oob (mtd_desc, &mtd, fd, - bit_to_flip->block * mtd.eb_size + + (unsigned long long )bit_to_flip->block * mtd.eb_size + blkoffs, mtd.oob_size, buffer + bufoffs);if (ret) {
Signature · 6 lines
2.30.2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 7 lines · Anton Moryakov
Report of the static analyzer:
The value of an arithmetic expression 'bit_to_flip->block* mtd.eb_size + blkoffs' is a subject to overflow because its operands are not cast to a larger data type before performing arith$Corrections explained:
Prevent arithmetic overflow in OOB read operation
Resolved an issue where the calculation of the offset in the OOB read operation could overflow due to operands not being cast to a larger data type. Specifically, the multiplication of bi$
Quoted 8 lines
Triggers found by static analyzer Svace.
Signed-off-by Anton Moryakov <[email protected]>--- nand-utils/nandflipbits.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines
nand-utils/nandflipbits.c +0
-0
nand-utils/nandflipbits.c int main(int argc, char **argv) · line 257
Quoted 8 lines
nand-utils/nandflipbits.c +1
-1@@ -251,7 +251,7 @@ int main(int argc, char **argv) bufoffs += mtd.min_io_size; ret =mtd_read_oob (mtd_desc, &mtd, fd, - bit_to_flip->block * mtd.eb_size + + (unsigned long long )bit_to_flip->block * mtd.eb_size + blkoffs, mtd.oob_size, buffer + bufoffs);if (ret) {
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/