Skip to contentSkip to conversation

dt-bindings: mfd: omap-usb-tll: convert to YAML

PATCH In review Karol Przybylski 2 participants 2 messages Dec 14, 2024 – Dec 17, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: mfd: omap-usb-tll: convert to YAML

Conversion of omap-usb-tll.txt into yaml format, inspired by discussion in lore.kernel.org/all/[email protected]/

Changes made to the binding during conversion:
- Added Roger Quadros as maintainer
- Removed deprecated ti,hwmod
- Renamed .yaml file to ti,usbhs-tll.yaml

---
 .../devicetree/bindings/mfd/omap-usb-tll.txt  | 27 -----------
 .../devicetree/bindings/mfd/ti,usbhs-tll.yaml | 47 +++++++++++++++++++
 2 files changed, 47 insertions(+), 27 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/omap-usb-tll.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml
Documentation/devicetree/bindings/mfd/omap-usb-tll.txt deleted +0 -27
deleted file mode 100644
index c58d70437..000000000
@@ -1,27 +0,0 @@
-OMAP HS USB Host TLL (Transceiver-Less Interface)
-
-Required properties:
-
-- compatible : should be "ti,usbhs-tll"
-- reg : should contain one register range i.e. start and length
-- interrupts : should contain the TLL module's interrupt
-- ti,hwmod : must contain "usb_tll_hs"
-
-Optional properties:
-
-- clocks: a list of phandles and clock-specifier pairs, one for each entry in
-  clock-names.
-
-- clock-names: should include:
-  * "usb_tll_hs_usb_ch0_clk" - USB TLL channel 0 clock
-  * "usb_tll_hs_usb_ch1_clk" - USB TLL channel 1 clock
-  * "usb_tll_hs_usb_ch2_clk" - USB TLL channel 2 clock
-
-Example:
-
-	usbhstll: usbhstll@4a062000 {
-		compatible = "ti,usbhs-tll";
-		reg = <0x4a062000 0x1000>;
-		interrupts = <78>;
-		ti,hwmods = "usb_tll_hs";
-	  };
Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml new file +47 -0

47 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 10 lines · Karol Przybylski

Conversion of omap-usb-tll.txt into yaml format, inspired by discussion in lore.kernel.org/all/[email protected]/

Changes made to the binding during conversion:
- Added Roger Quadros as maintainer
- Removed deprecated ti,hwmod
- Renamed .yaml file to ti,usbhs-tll.yaml

---

Changelog goes here. I asked about this last time.

Use b4 or git format-patch -v3, so there will be proper space before v3 in subject prefix.

These are nits but the problem is that you never responded to my review and did not implement it fully.

Quoted 5 lines
 .../devicetree/bindings/mfd/omap-usb-tll.txt  | 27 -----------
 .../devicetree/bindings/mfd/ti,usbhs-tll.yaml | 47 +++++++++++++++++++
 2 files changed, 47 insertions(+), 27 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/omap-usb-tll.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml

...

Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml line 32

Quoted 10 lines
Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml new file +10 -0
+  clocks:
+    minItems: 1
+    maxItems: 3
+
+  clock-names:
+    items:
+      - const: usb_tll_hs_usb_ch0_clk
+      - const: usb_tll_hs_usb_ch1_clk
+      - const: usb_tll_hs_usb_ch2_clk
+    minItems: 1

Same question as last time - why the number of clocks is flexible? Original binding suggested that if clocks are present, then three clocks are required, so you are changing here something which should be explained in commit msg.

More over, implementation suggests that you could provide clock "ch2" without "ch0" and "ch1", which your binding does not allow. So again a change or deviation from the current ABI.

Quoted 4 lines
Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml new file +4 -0
+
+required:
+  - compatible
+  - reg

Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml line 46

Quoted 10 lines
Documentation/devicetree/bindings/mfd/ti,usbhs-tll.yaml new file +10 -0
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    usbhstll@4a062000 {
+      compatible = "ti,usbhs-tll";
+      reg = <0x4a062000 0x1000>;
+      interrupts = <78>;

Nothing improved here. See my last comment.

Best regards,
Krzysztof