Skip to contentSkip to conversation

Fix recent regressions from for_next

PATCH In review Theodore Ts'o 6 participants 15 messages Dec 15, 2024 – Dec 22, 2024

lore
Share & tools
lore
#0 lore raw

cover Fix recent regressions from for_next

I don't think I saw an announcement for the most recent for_next update, but I just happened to pull it and try it out, and found the following regressions. Fortunately they were easy fixes.

Theodore Ts'o (2):
generic/135: don't try to rm $SCRATCH_MNT/*
generic/530: only use xfs-specific mkfs options when testing on xfs

 tests/generic/135 | 2 --
 tests/generic/530 | 6 +++++-
 2 files changed, 5 insertions(+), 3 deletions(-)
Signature · 1 line
2.45.2
#1 lore raw

PATCH 1/2 generic/135: don't try to rm $SCRATCH_MNT/*

This fixes a regression for ext4 introduced by commit 32e14cb90b88 ("fstests: don't use directory stacks"), which replaced a number of files at the top-level of the scratch file system:

async_file sync_file direct_file trunc_file

with "rm $SCRATCH_MNT/*". This causes a test failure on ext4 file systems caused by a failed attempt to unlink the lost+found directory. The thing, is these files are all super small (4k or 16k) and the scratch file system is going to get reformatted before it gets used again. So just dropping the delete is the simplest way to solve the problem.

Fixes 32e14cb90b88 ("fstests: don't use directory stacks")
---
 tests/generic/135 | 2 --
 1 file changed, 2 deletions(-)
tests/generic/135 +0 -2
index 392fee6fc..f74e144f3 100755
@@ -40,7 +40,5 @@ od -Ad -x $SCRATCH_MNT/sync_file
 od -Ad -x $SCRATCH_MNT/direct_file
 od -Ad -x $SCRATCH_MNT/trunc_file
 
-rm -f $SCRATCH_MNT/*
-
 status=0
 exit 
Signature · 1 line
2.45.2
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] generic/135: don't try to rm $SCRATCH_MNT/*

Quoted 13 lines · Theodore Ts'o

This fixes a regression for ext4 introduced by commit 32e14cb90b88 ("fstests: don't use directory stacks"), which replaced a number of files at the top-level of the scratch file system:

async_file sync_file direct_file trunc_file

with "rm $SCRATCH_MNT/*". This causes a test failure on ext4 file systems caused by a failed attempt to unlink the lost+found directory. The thing, is these files are all super small (4k or 16k) and the scratch file system is going to get reformatted before it gets used again. So just dropping the delete is the simplest way to solve the problem.

Quoted 2 lines
Fixes 32e14cb90b88 ("fstests: don't use directory stacks")

Looks good:

#3 lore raw

PATCH 2/2 generic/530: only use xfs-specific mkfs options when testing on xfs

In reply to Theodore Ts'o

This fixes a regression introduced by commit 000813899afb ("fstests:
scale some tests for high CPU count sanity") where this test unconditionally tried to use the mkfs option "-l size=256m" which would break when testing any file sytem other than xfs.

Fix this the same way commit 000813899afb dealt with this for generic/531; so this was just an oversight.

Fixes 000813899afb ("fstests: scale some tests for high CPU count sanity")
---
 tests/generic/530 | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tests/generic/530 +5 -1
index 18256b870..06d7532f0 100755
@@ -22,7 +22,11 @@ _require_scratch_shutdown
 _require_metadata_journaling
 _require_test_program "t_open_tmpfiles"
 
-_scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi
 _scratch_mount
 
 # Set ULIMIT_NOFILE to min(file-max / 2, 50000 files per LOAD_FACTOR)
Signature · 1 line
2.45.2
#4 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

tests/generic/530 _require_scratch_shutdown · line 29

Quoted 5 lines · Theodore Ts'o
tests/generic/530 +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

#5 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

Quoted 10 lines · Christoph Hellwig

tests/generic/530 _require_scratch_shutdown · line 29

Quoted 5 lines · Theodore Ts'o
tests/generic/530 +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#6 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

Quoted 12 lines · Dave Chinner
Quoted 10 lines · Christoph Hellwig

tests/generic/530 _require_scratch_shutdown · line 29

Quoted 5 lines · Theodore Ts'o
tests/generic/530 +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Quoted 3 lines

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

Please explain this in thet test. And you probably also want to ensure that you don't force the log smaller than 256 either, otherwise people in 10 or 20 years will wonder why this test forces logs to be so small.

#7 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

Quoted 13 lines · Christoph Hellwig
Quoted 12 lines · Dave Chinner
Quoted 10 lines · Christoph Hellwig

tests/generic/530 _require_scratch_shutdown · line 29

Quoted 5 lines · Theodore Ts'o
tests/generic/530 +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Quoted 8 lines
Quoted 3 lines

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

Please explain this in thet test. And you probably also want to ensure that you don't force the log smaller than 256 either, otherwise people in 10 or 20 years will wonder why this test forces logs to be so small.

I'll help to add this comment when I merge this patch, if Dave hope to keep "-l size=256m" for xfs.

Thanks,
Zorro

Quoted 1 line
#8 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

Quoted 18 lines · Zorro Lang
Quoted 17 lines · Christoph Hellwig
Quoted 15 lines · Dave Chinner
Quoted 10 lines · Christoph Hellwig

tests/generic/530 _require_scratch_shutdown · line 29

Quoted 5 lines · Theodore Ts'o
tests/generic/530 +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

Quoted 7 lines
Quoted 4 lines

Please explain this in thet test. And you probably also want to ensure that you don't force the log smaller than 256 either, otherwise people in 10 or 20 years will wonder why this test forces logs to be so small.

I'll help to add this comment when I merge this patch, if Dave hope to keep "-l size=256m" for xfs.

What happens if someone runs fstests with a 128M external log device? Is this one of those cases where _scratch_mkfs notices the mkfs failure and formats without MKFS_OPTIONS? And if that's true, what about my test configs that set MKFS_OPTIONS to test new non-default features?

--D

Quoted 6 lines

Thanks,
Zorro

Quoted 1 line
#9 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

Quoted 24 lines · Darrick J. Wong
Quoted 23 lines · Zorro Lang
Quoted 21 lines · Christoph Hellwig
Quoted 12 lines · Dave Chinner
Quoted 10 lines · Christoph Hellwig

tests/generic/530 _require_scratch_shutdown · line 29

Quoted 5 lines · Theodore Ts'o
tests/generic/530 +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Quoted 3 lines

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

Please explain this in thet test. And you probably also want to ensure that you don't force the log smaller than 256 either, otherwise people in 10 or 20 years will wonder why this test forces logs to be so small.

Quoted 4 lines
Quoted 2 lines

I'll help to add this comment when I merge this patch, if Dave hope to keep "-l size=256m" for xfs.

What happens if someone runs fstests with a 128M external log device?

It fails, then drops MKFS_OPTIONS. The simple solution for this is to simply to use a larger external log device....

Quoted 2 lines

Is this one of those cases where _scratch_mkfs notices the mkfs failure and formats without MKFS_OPTIONS?

More than likely.

Quoted 2 lines

And if that's true, what about my
test configs that set MKFS_OPTIONS to test new non-default features?

Changing existing infrastructure behaviour to better suit *your* test environments is *your* responsibility to address, not mine. I don't care if MKFS_OPTIONS get dropped in occasional tests, it's more important to me that the tests run fast so I can iterate my modify-build-test development cycle faster.

It should be trivial for you to address, though. Add a function like:

_scratch_mkfs_try_option "-l size=256M"

which has the opposite fallback behaviour of dropping the test supplied option and using MKFS_OPTIONS instead, and I'll use it for all these "test go faster" modifications that we badly need to address...

FWIW, this would also get rid of the need for the FSTYP checks in the test, too, because passing "-l size=256M" will fail on btrfs, ext4, etc and then they fall back to the specific test config...

So, provide me with the infrastructure that makes stuff like this work properly in *your test environment*, and I'll use it appropriately.

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#10 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

Quoted 38 lines · Dave Chinner
Quoted 24 lines · Darrick J. Wong
Quoted 23 lines · Zorro Lang
Quoted 21 lines · Christoph Hellwig
Quoted 12 lines · Dave Chinner
Quoted 10 lines · Christoph Hellwig

Review

Quoted 5 lines · Theodore Ts'o
(quoted diff) +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Quoted 3 lines

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

Please explain this in thet test. And you probably also want to ensure that you don't force the log smaller than 256 either, otherwise people in 10 or 20 years will wonder why this test forces logs to be so small.

Quoted 4 lines
Quoted 2 lines

I'll help to add this comment when I merge this patch, if Dave hope to keep "-l size=256m" for xfs.

What happens if someone runs fstests with a 128M external log device?

It fails, then drops MKFS_OPTIONS. The simple solution for this is to simply to use a larger external log device....

Quoted 2 lines

Is this one of those cases where _scratch_mkfs notices the mkfs failure and formats without MKFS_OPTIONS?

More than likely.

Quoted 8 lines
Quoted 2 lines

And if that's true, what about my
test configs that set MKFS_OPTIONS to test new non-default features?

Changing existing infrastructure behaviour to better suit *your* test environments is *your* responsibility to address, not mine. I don't care if MKFS_OPTIONS get dropped in occasional tests, it's more important to me that the tests run fast so I can iterate my modify-build-test development cycle faster.

I don't agree that your personal development velocity is more important than silent loss of code coverage of everyone who happens to be testing external log devices. That at least covers myself, our QA department, and everyone who uses the prepackaged configurations in kdevops and xfstests-bld.

Quoted 4 lines

It should be trivial for you to address, though. Add a function like:

_scratch_mkfs_try_option "-l size=256M"

Or instead:

# Pushing 50000 unlinked inode inactivations through a small xfs log can

# result in bottlenecks on the log grant heads, so try to make the log
# larger to reduce runtime.
if [ $FSTYP = xfs ] && [ -z "$SCRATCH_LOGDEV ]; then
	_scratch_mkfs -l size=256M
else
	_scratch_mkfs
fi
Quoted 8 lines

which has the opposite fallback behaviour of dropping the test supplied option and using MKFS_OPTIONS instead, and I'll use it for all these "test go faster" modifications that we badly need to address...

FWIW, this would also get rid of the need for the FSTYP checks in the test, too, because passing "-l size=256M" will fail on btrfs, ext4, etc and then they fall back to the specific test config...

Huh? And what happens when btrfs want their own try option?

Quoted 3 lines

So, provide me with the infrastructure that makes stuff like this work properly in *your test environment*, and I'll use it appropriately.

Dave.

You're the one who made the changes to generic/53*. It worked before.

Like any other code change, it's /your/ responsibility to try not to cause regressions for everyone else using the same code. If other people have problems with a change, it's longstanding community expectation that the author should help resolve the problem.

It is /not/ standard practice to lecture the affected people about how they should embark on a treewide change to fix a problem that didn't exist previously. The maintainer reverts the offending commit and the author redrafts the patch. You're well aware of this, because you've said as much about other patches (e.g. iomap zeroing cleanups).

It is not everyone else's (Ted, Christoph, Zorro) role to clean up after you.

I do not appreciate the condescending behavior you have shown towards me this year and last. Next year I will take more steps to insulate my team from you and other community members as needed because I don't want them to continue to deal with such conduct[1][2].

--D

[1] https://lore.kernel.org/fstests/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/

Quoted 4 lines

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#11 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

<snip the latest grousing back and forth>

Gentlemen, It would go a really long way if everyone could keep a few things in mind as we work together in this public space.

1) Act in good faith
2) Assume good intent
3) Don't escalate conflict
4) Own your mistakes

That's basic stuff. Could we maybe give that a shot for a while, and see if we can reduce this misery a bit?

(If you took any of the above personally, please don't. I'm just reflecting on what I think are some longstanding patterns, here.)

Everybody's working hard, everybody's stressed, everybody makes mistakes. I have no desire to go point by point through some of the many recent blow-ups, but in nearly every one of them I think things would have gone better if at any time during the back and forth, people had stopped to reflect on the points above before firing off a reply.

Above isn't perfect and perhaps others have thoughts on basic guidelines for communicating without conflict, but maybe it's a start?

-Eric

#12 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

In reply to Darrick J. Wong
Quoted 59 lines · Darrick J. Wong
Quoted 38 lines · Dave Chinner
Quoted 24 lines · Darrick J. Wong
Quoted 23 lines · Zorro Lang
Quoted 21 lines · Christoph Hellwig
Quoted 12 lines · Dave Chinner
Quoted 10 lines · Christoph Hellwig

Review

Quoted 5 lines · Theodore Ts'o
(quoted diff) +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Quoted 3 lines

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

Please explain this in thet test. And you probably also want to ensure that you don't force the log smaller than 256 either, otherwise people in 10 or 20 years will wonder why this test forces logs to be so small.

Quoted 4 lines
Quoted 2 lines

I'll help to add this comment when I merge this patch, if Dave hope to keep "-l size=256m" for xfs.

What happens if someone runs fstests with a 128M external log device?

It fails, then drops MKFS_OPTIONS. The simple solution for this is to simply to use a larger external log device....

Quoted 2 lines

Is this one of those cases where _scratch_mkfs notices the mkfs failure and formats without MKFS_OPTIONS?

More than likely.

Quoted 8 lines
Quoted 2 lines

And if that's true, what about my
test configs that set MKFS_OPTIONS to test new non-default features?

Changing existing infrastructure behaviour to better suit *your* test environments is *your* responsibility to address, not mine. I don't care if MKFS_OPTIONS get dropped in occasional tests, it's more important to me that the tests run fast so I can iterate my modify-build-test development cycle faster.

I don't agree that your personal development velocity is more important than silent loss of code coverage of everyone who happens to be testing external log devices. That at least covers myself, our QA department, and everyone who uses the prepackaged configurations in kdevops and xfstests-bld.

Quoted 4 lines

It should be trivial for you to address, though. Add a function like:

_scratch_mkfs_try_option "-l size=256M"

Quoted 7 lines

Or instead:

# Pushing 50000 unlinked inode inactivations through a small xfs log can

# result in bottlenecks on the log grant heads, so try to make the log
# larger to reduce runtime.
if [ $FSTYP = xfs ] && [ -z "$SCRATCH_LOGDEV ]; then
	_scratch_mkfs -l size=256M

Maybe better to use "_has_logdev", due to there's "$USE_EXTERNAL". I can change this patch as:

  # Pushing 50000 unlinked inode inactivations through a small xfs log can
  # result in bottlenecks on the log grant heads, so try to make the log
  # larger to reduce runtime.
  if [ "$FSTYP" = "xfs" ] && _has_logdev; then
  	_scratch_mkfs -l size=256M
  else
  	_scratch_mkfs
  fi

when I merge it, if you all agree :)

Thanks,
Zorro

Quoted 52 lines

else
_scratch_mkfs
fi

Quoted 8 lines

which has the opposite fallback behaviour of dropping the test supplied option and using MKFS_OPTIONS instead, and I'll use it for all these "test go faster" modifications that we badly need to address...

FWIW, this would also get rid of the need for the FSTYP checks in the test, too, because passing "-l size=256M" will fail on btrfs, ext4, etc and then they fall back to the specific test config...

Huh? And what happens when btrfs want their own try option?

Quoted 3 lines

So, provide me with the infrastructure that makes stuff like this work properly in *your test environment*, and I'll use it appropriately.

Dave.

You're the one who made the changes to generic/53*. It worked before.

Like any other code change, it's /your/ responsibility to try not to cause regressions for everyone else using the same code. If other people have problems with a change, it's longstanding community expectation that the author should help resolve the problem.

It is /not/ standard practice to lecture the affected people about how they should embark on a treewide change to fix a problem that didn't exist previously. The maintainer reverts the offending commit and the author redrafts the patch. You're well aware of this, because you've said as much about other patches (e.g. iomap zeroing cleanups).

It is not everyone else's (Ted, Christoph, Zorro) role to clean up after you.

I do not appreciate the condescending behavior you have shown towards me this year and last. Next year I will take more steps to insulate my team from you and other community members as needed because I don't want them to continue to deal with such conduct[1][2].

--D

[1] https://lore.kernel.org/fstests/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/

Quoted 4 lines

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#13 lore raw

Re: [PATCH 2/2] generic/530: only use xfs-specific mkfs options when testing on xfs

Quoted 68 lines · Zorro Lang
Quoted 59 lines · Darrick J. Wong
Quoted 38 lines · Dave Chinner
Quoted 24 lines · Darrick J. Wong
Quoted 23 lines · Zorro Lang
Quoted 21 lines · Christoph Hellwig
Quoted 12 lines · Dave Chinner
Quoted 10 lines · Christoph Hellwig

Review

Quoted 5 lines · Theodore Ts'o
(quoted diff) +5 -0
+if [ $FSTYP = "xfs" ]; then
+    _scratch_mkfs "-l size=256m" >> $seqres.full 2>&1
+else
+    _scratch_mkfs >> $seqres.full 2>&1
+fi

We really need to document why generic tests have file system specific hacks. And yes, that's a request for Dave who originally added it without any explanation and not Ted.

Quoted 3 lines

Creating and then unlinking 50000 files is journal space bound when using default 64MB logs on small test filesystems. Increasing the journal size to 256MB halved the runtime of this test.

Please explain this in thet test. And you probably also want to ensure that you don't force the log smaller than 256 either, otherwise people in 10 or 20 years will wonder why this test forces logs to be so small.

Quoted 4 lines
Quoted 2 lines

I'll help to add this comment when I merge this patch, if Dave hope to keep "-l size=256m" for xfs.

What happens if someone runs fstests with a 128M external log device?

It fails, then drops MKFS_OPTIONS. The simple solution for this is to simply to use a larger external log device....

Quoted 2 lines

Is this one of those cases where _scratch_mkfs notices the mkfs failure and formats without MKFS_OPTIONS?

More than likely.

Quoted 8 lines
Quoted 2 lines

And if that's true, what about my
test configs that set MKFS_OPTIONS to test new non-default features?

Changing existing infrastructure behaviour to better suit *your* test environments is *your* responsibility to address, not mine. I don't care if MKFS_OPTIONS get dropped in occasional tests, it's more important to me that the tests run fast so I can iterate my modify-build-test development cycle faster.

I don't agree that your personal development velocity is more important than silent loss of code coverage of everyone who happens to be testing external log devices. That at least covers myself, our QA department, and everyone who uses the prepackaged configurations in kdevops and xfstests-bld.

Quoted 4 lines

It should be trivial for you to address, though. Add a function like:

_scratch_mkfs_try_option "-l size=256M"

Quoted 7 lines

Or instead:

# Pushing 50000 unlinked inode inactivations through a small xfs log can

# result in bottlenecks on the log grant heads, so try to make the log
# larger to reduce runtime.
if [ $FSTYP = xfs ] && [ -z "$SCRATCH_LOGDEV ]; then
	_scratch_mkfs -l size=256M
Quoted 7 lines

Maybe better to use "_has_logdev", due to there's "$USE_EXTERNAL". I can change this patch as:

  # Pushing 50000 unlinked inode inactivations through a small xfs log can
  # result in bottlenecks on the log grant heads, so try to make the log
  # larger to reduce runtime.
  if [ "$FSTYP" = "xfs" ] && _has_logdev; then

Sorry, should be "! _has_logdev".

Quoted 62 lines

_scratch_mkfs -l size=256M
else
_scratch_mkfs
fi

when I merge it, if you all agree :)

Thanks,
Zorro

Quoted 52 lines

else
_scratch_mkfs
fi

Quoted 8 lines

which has the opposite fallback behaviour of dropping the test supplied option and using MKFS_OPTIONS instead, and I'll use it for all these "test go faster" modifications that we badly need to address...

FWIW, this would also get rid of the need for the FSTYP checks in the test, too, because passing "-l size=256M" will fail on btrfs, ext4, etc and then they fall back to the specific test config...

Huh? And what happens when btrfs want their own try option?

Quoted 3 lines

So, provide me with the infrastructure that makes stuff like this work properly in *your test environment*, and I'll use it appropriately.

Dave.

You're the one who made the changes to generic/53*. It worked before.

Like any other code change, it's /your/ responsibility to try not to cause regressions for everyone else using the same code. If other people have problems with a change, it's longstanding community expectation that the author should help resolve the problem.

It is /not/ standard practice to lecture the affected people about how they should embark on a treewide change to fix a problem that didn't exist previously. The maintainer reverts the offending commit and the author redrafts the patch. You're well aware of this, because you've said as much about other patches (e.g. iomap zeroing cleanups).

It is not everyone else's (Ted, Christoph, Zorro) role to clean up after you.

I do not appreciate the condescending behavior you have shown towards me this year and last. Next year I will take more steps to insulate my team from you and other community members as needed because I don't want them to continue to deal with such conduct[1][2].

--D

[1] https://lore.kernel.org/fstests/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/

Quoted 4 lines

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]
Reviewed-by on the v1 series
#14 lore raw
In reply to Theodore Ts'o
Quoted 11 lines · Theodore Ts'o

I don't think I saw an announcement for the most recent for_next update, but I just happened to pull it and try it out, and found the following regressions. Fortunately they were easy fixes.

Theodore Ts'o (2):
generic/135: don't try to rm $SCRATCH_MNT/*
generic/530: only use xfs-specific mkfs options when testing on xfs

 tests/generic/135 | 2 --
 tests/generic/530 | 6 +++++-
 2 files changed, 5 insertions(+), 3 deletions(-)

Fixes look good.

Signature · 2 lines
Dave Chinner
[email protected]