iio: adc: ti-ads124s08: Switch to fsleep()
PATCH v2 1/1 iio: adc: ti-ads124s08: Switch to fsleep()
From: Fabio Estevam <[email protected]>
According to Documentation/timers/delay_sleep_functions.rst, fsleep() is the preferred delay function to be used in non-atomic context, so switch to it accordingly.
---
Changes since v1:
- Use [email protected] in the Suggested-by tag.
- Add Reviewed-by.
drivers/iio/adc/ti-ads124s08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti-ads124s08.c +1 -1
@@ -184,7 +184,7 @@ static int ads124s_reset(struct iio_dev *indio_dev)if (priv->reset_gpio) {gpiod_set_value_cansleep (priv->reset_gpio,0 ); -udelay (200 ); +fsleep (200 );gpiod_set_value_cansleep (priv->reset_gpio,1 ); }else {return ads124s_write_cmd (indio_dev,ADS124S08_CMD_RESET );
Signature · 1 line
2.34.1
Jonathan Cameron
maintainerQuoted 9 lines · On Mon, 9 Dec 2024 15:16:24 -0300 Fabio Estevam <[email protected]> wrote:
From: Fabio Estevam <[email protected]>
According to
Documentation/timers/delay_sleep_functions.rst,fsleep()is the preferred delay function to be used in non-atomic context, so switch to it accordingly.Suggested-by Andy Shevchenko <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
This is one is stalled behind the cansleep patch which I decided was trivial enough and sort of a fix so sent the fast way.
If the two had been together I'd have included this as well, but now it's just an optimization so needs to go the slow route.
Jonathan
Quoted 21 lines
---
Changes since v1:
- Use [email protected] in the Suggested-by tag.
- Add Reviewed-by.drivers/iio/adc/ti-ads124s08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/ti-ads124s08.c +1
-1@@ -184,7 +184,7 @@ static int ads124s_reset(struct iio_dev *indio_dev)if (priv->reset_gpio) {gpiod_set_value_cansleep (priv->reset_gpio,0 ); -udelay (200 ); +fsleep (200 );gpiod_set_value_cansleep (priv->reset_gpio,1 ); }else {return ads124s_write_cmd (indio_dev,ADS124S08_CMD_RESET );
Hi Jonathan,
Quoted 2 lines · Jonathan Cameron
If the two had been together I'd have included this as well, but now it's just an optimization so needs to go the slow route.
That's OK. This one is just an improvement and can wait.
Thanks
Jonathan Cameron
maintainerQuoted 11 lines · On Sun, 15 Dec 2024 09:32:47 -0300 Fabio Estevam <[email protected]> wrote:
Hi Jonathan,
Quoted 2 lines · Jonathan Cameron
If the two had been together I'd have included this as well, but now it's just an optimization so needs to go the slow route.
That's OK. This one is just an improvement and can wait.
Thanks
Now applied to the testing branch of iio.git
Thanks,