Skip to contentSkip to conversation

dt-bindings: connector: Add time property for sender response

PATCH Superseded joswang 3 participants 5 messages Dec 15, 2024 – Dec 20, 2024 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

joswang

author
#0 lore raw

PATCH 1/2 dt-bindings: connector: Add time property for sender response

From: Jos Wang <[email protected]>

This commit adds the following properties:
* pd2-sender-response-time-ms
* pd3-sender-response-time-ms

This is to enable setting of platform/board specific timer values as these timers have a range of acceptable values.

---
 .../bindings/connector/usb-connector.yaml     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
Documentation/devicetree/bindings/connector/usb-connector.yaml +20 -0
index 67700440e23b..83be66f6d406 100644
@@ -293,6 +293,26 @@ properties:
       PD negotiation till BC1.2 detection completes.
     default: 0
 
+  pd2-sender-response-time-ms:
+    description: Represents the PD20 max time in ms that port started from
+      the time the last bit of the GoodCRC Message EOP has been received by
+      the Physical Layer, it shall be stopped when the last bit of the expected
+      response Message EOP has been received by the Physical Layer. A timeout
+      leads to a hard reset message by the port.
+    minimum: 24
+    maximum: 30
+    default: 27
+
+  pd3-sender-response-time-ms:
+    description: Represents the PD30 max time in ms that port started from
+      the time the last bit of the GoodCRC Message EOP has been received by
+      the Physical Layer, it shall be stopped when the last bit of the expected
+      response Message EOP has been received by the Physical Layer. A timeout
+      leads to a hard reset message by the port.
+    minimum: 27
+    maximum: 33
+    default: 30
+
 dependencies:
   sink-vdos-v1: [ sink-vdos ]
   sink-vdos: [ sink-vdos-v1 ]
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · joswang

From: Jos Wang <[email protected]>

This commit adds the following properties:

Please do not use "This commit/patch/change", but imperative mood. See longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Quoted 5 lines

* pd2-sender-response-time-ms
* pd3-sender-response-time-ms

This is to enable setting of platform/board specific timer values as these timers have a range of acceptable values.

Some explanation from where do they come would be useful.

Quoted 2 lines

Your second patch did not make it.

Best regards,
Krzysztof

author
#2 lore raw

Thank you for your help in reviewing the code.

I will resubmit the code as soon as possible, put patch 1/2 and 2/2 in the same thread.

Quoted 25 lines · Krzysztof Kozlowski
Quoted 3 lines · joswang

From: Jos Wang <[email protected]>

This commit adds the following properties:

Please do not use "This commit/patch/change", but imperative mood. See longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Quoted 5 lines

* pd2-sender-response-time-ms
* pd3-sender-response-time-ms

This is to enable setting of platform/board specific timer values as these timers have a range of acceptable values.

Some explanation from where do they come would be useful.

Quoted 2 lines

Your second patch did not make it.

Best regards,
Krzysztof

#3 lore raw
In reply to joswang
Quoted 6 lines · joswang

From: Jos Wang <[email protected]>

This commit adds the following properties:
* pd2-sender-response-time-ms
* pd3-sender-response-time-ms

Quoted 7 lines

This is to enable setting of platform/board specific timer values as these timers have a range of acceptable values.

---
 .../bindings/connector/usb-connector.yaml     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Where is patch 2/2? Oh, I now see it, but our tools do not :(

Please make them properly linked together, normally something like 'git send-email' will do that for you.

thakns,

greg k-h

author
#4 lore raw

Thank you for your help in reviewing the code.

I will resubmit the V2 version as soon as possible,put patch 1/2 and 2/2 in the same thread.

Thank

Jos Wang

Quoted 24 lines · Greg KH
Quoted 6 lines · joswang

From: Jos Wang <[email protected]>

This commit adds the following properties:
* pd2-sender-response-time-ms
* pd3-sender-response-time-ms

Quoted 7 lines

This is to enable setting of platform/board specific timer values as these timers have a range of acceptable values.

---
 .../bindings/connector/usb-connector.yaml     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Where is patch 2/2? Oh, I now see it, but our tools do not :(

Please make them properly linked together, normally something like 'git send-email' will do that for you.

thakns,

greg k-h