Skip to contentSkip to conversation

arm64: dts: rockchip: Refine dts for Radxa ROCK 5C

PATCH Superseded FUKAUMI Naoki 4 participants 39 messages Dec 16, 2024 – Dec 22, 2024

Subsystems (2)

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v5 cover arm64: dts: rockchip: Refine dts for Radxa ROCK 5C

This patch series includes fixes for difference from schematic and vendor kernel, minor improvements, cosmetic changes, etc.

FUKAUMI Naoki (12):
arm64: dts: rockchip: Change function name for blue LED for Radxa ROCK

    5C
  arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C
  arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa
    ROCK 5C
  arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C
  arm64: dts: rockchip: Add properties for pcie2x1l2 for Radxa ROCK 5C
  arm64: dts: rockchip: Remove RTC and related node for Radxa ROCK 5C
  arm64: dts: rockchip: Separate pinctrl for vcc_5v0 for Radxa ROCK 5C
  arm64: dts: rockchip: Add cd-gpios for sdmmc for Radxa ROCK 5C
  arm64: dts: rockchip: Fix pmic dcdc-reg7 regulator-name for Radxa ROCK
    5C

arm64: dts: rockchip: Fix pmic dcdc-reg10 label for Radxa ROCK 5C
arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa
ROCK 5C
arm64: dts: rockchip: Sort nodes for Radxa ROCK 5C

 .../boot/dts/rockchip/rk3588s-rock-5c.dts     | 62 +++++++------------
 1 file changed, 22 insertions(+), 40 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v5 1/12 arm64: dts: rockchip: Change function name for blue LED for Radxa ROCK 5C

Since Radxa ROCK 5C is updated version of Radxa ROCK 5A, everything should be compatible as much as possible.

Change function for blue LED from HEARTBEAT to STATUS.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5
- Reword commit message
Changes in v4
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
index 9b14d5383cdc..23e9b447b6f0 100644
@@ -62,7 +62,7 @@ led-0 {
 		led-1 {
 			color = <LED_COLOR_ID_BLUE>;
 			default-state = "on";
-			function = LED_FUNCTION_HEARTBEAT;
+			function = LED_FUNCTION_STATUS;
 			gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
Signature · 1 line
2.43.0
#2 lore raw

PATCH v5 2/12 arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

In reply to FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

---
Changes in v5
- Reword commit message
Changes in v4
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
index 23e9b447b6f0..630f026d856c 100644
@@ -68,7 +68,7 @@ led-1 {
 		};
 	};
 
-	fan {
+	pwm-fan {
 		compatible = "pwm-fan";
 		#cooling-cells = <2>;
 		cooling-levels = <0 64 128 192 255>;
Signature · 1 line
2.43.0
Reviewed-by on v5 2/12
#3 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 3 lines · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

Looking good to me, as a preparatory patch. Please, feel free to include:

Quoted 23 lines

---
Changes in v5
- Reword commit message
Changes in v4
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
index 23e9b447b6f0..630f026d856c 100644
@@ -68,7 +68,7 @@ led-1 {
 		};
 	};
 
-	fan {
+	pwm-fan {
 		compatible = "pwm-fan";
 		#cooling-cells = <2>;
 		cooling-levels = <0 64 128 192 255>;
#4 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 9 lines · Dragan Simic
Quoted 3 lines · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

Looking good to me, as a preparatory patch. Please, feel free to include:

That's just incorrect. If you really want to review such trivial patches, perform a full review.

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Hello Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Dragan Simic
Quoted 3 lines · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

Quoted 7 lines
Quoted 4 lines

Looking good to me, as a preparatory patch. Please, feel free to include:

That's just incorrect. If you really want to review such trivial patches, perform a full review.

Well, I don't see what's wrong with reviewing two fan-related patches that go together? Moreover, in this case it's about using a generic name, which you prefer, or using a more common name, which I prefer. However, as a maintainer, your preference matters more.

#6 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

In reply to FUKAUMI Naoki
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

Best regards,
Krzysztof

#7 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

https://lore.kernel.org/all/[email protected]/

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#8 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 8 lines · FUKAUMI Naoki
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

https://lore.kernel.org/all/[email protected]/

And? That's incorrect advice. There is no such device as "pwm-fan". There is a "fan" and whether it is pwm or gpio it does not matter.

See DT spec and generic names recommendation.

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · FUKAUMI Naoki
Quoted 3 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

No, generic name is fan.

   https://lore.kernel.org/all/[email protected]/

And? That's incorrect advice. There is no such device as "pwm-fan". There is a "fan" and whether it is pwm or gpio it does not matter.

See DT spec and generic names recommendation.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67

Is it wrong?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · FUKAUMI Naoki
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

   https://lore.kernel.org/all/[email protected]/
Quoted 8 lines
Quoted 4 lines

And? That's incorrect advice. There is no such device as "pwm-fan". There is a "fan" and whether it is pwm or gpio it does not matter.

See DT spec and generic names recommendation.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67

Is it wrong?

Yes.

Best regards,
Krzysztof

#11 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Krzysztof Kozlowski
Quoted 8 lines · FUKAUMI Naoki
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

    https://lore.kernel.org/all/[email protected]/

And? That's incorrect advice. There is no such device as "pwm-fan". There is a "fan" and whether it is pwm or gpio it does not matter.

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

See DT spec and generic names recommendation.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67

Is it wrong?

Yes.

Okay, please fix it.

Feel free to use:

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

Best regards,
Krzysztof

#12 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

Quoted 16 lines · FUKAUMI Naoki
Quoted 15 lines · Krzysztof Kozlowski
Quoted 14 lines · FUKAUMI Naoki
Quoted 13 lines · Krzysztof Kozlowski
Quoted 9 lines · FUKAUMI Naoki
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

https://lore.kernel.org/all/[email protected]/

And? That's incorrect advice. There is no such device as "pwm-fan". There is a "fan" and whether it is pwm or gpio it does not matter.

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line

See DT spec and generic names recommendation.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67

Is it wrong?

Yes.

Okay, please fix it.

Good point.

Quoted 3 lines

Feel free to use:

#13 lore raw

Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C

In reply to FUKAUMI Naoki
Quoted 15 lines · FUKAUMI Naoki
Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Krzysztof Kozlowski
Quoted 8 lines · FUKAUMI Naoki
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Use more common name "pwm-fan" for pwm-fan node. No functinal change.

No, generic name is fan.

    https://lore.kernel.org/all/[email protected]/

And? That's incorrect advice. There is no such device as "pwm-fan". There is a "fan" and whether it is pwm or gpio it does not matter.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line

See DT spec and generic names recommendation.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67

Is it wrong?

Yes.

There's an(other) issue with the binding:
line 91 references &fan0 while it isn't defined (in the binding example)

Cheers,
Diederik

#14 lore raw

PATCH v5 3/12 arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa ROCK 5C

In reply to FUKAUMI Naoki

The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a total switch-on time of 0,6us and a total switch-off time of 6us [1], meaning that the current PWM period of just 10us is too short for fine-grained fan speed control. Increase the PWM period to 60us, so that the switch-on and switch-off time of the MOSFET fall within a more reasonable ~10% of the full period, thus making lower PWM duty cycles meaningful.

[1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message (Alexey Charkov)
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- reword commit message

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
index 630f026d856c..85589d1a6d3b 100644
@@ -73,7 +73,7 @@ pwm-fan {
 		#cooling-cells = <2>;
 		cooling-levels = <0 64 128 192 255>;
 		fan-supply = <&vcc_5v0>;
-		pwms = <&pwm3 0 10000 0>;
+		pwms = <&pwm3 0 60000 0>;
 	};
 
 	pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
Signature · 1 line
2.43.0
Reviewed-by on v5 3/12
#15 lore raw

Re: [PATCH v5 03/12] arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa ROCK 5C

Quoted 8 lines · FUKAUMI Naoki

The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a total switch-on time of 0,6us and a total switch-off time of 6us [1], meaning that the current PWM period of just 10us is too short for fine-grained fan speed control. Increase the PWM period to 60us, so that the switch-on and switch-off time of the MOSFET fall within a more reasonable ~10% of the full period, thus making lower PWM duty cycles meaningful.

Quoted 4 lines

[1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

Looking good to me. Please, feel free to include:

Quoted 27 lines

---
Changes in v5:
- Reword commit message (Alexey Charkov)
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- reword commit message

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
index 630f026d856c..85589d1a6d3b 100644
@@ -73,7 +73,7 @@ pwm-fan {
 		#cooling-cells = <2>;
 		cooling-levels = <0 64 128 192 255>;
 		fan-supply = <&vcc_5v0>;
-		pwms = <&pwm3 0 10000 0>;
+		pwms = <&pwm3 0 60000 0>;
 	};
 
 	pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
#16 lore raw

PATCH v5 4/12 arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

In reply to FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +3 -3
index 85589d1a6d3b..61d75ab503b2 100644
@@ -76,13 +76,13 @@ pwm-fan {
 		pwms = <&pwm3 0 60000 0>;
 	};
 
-	pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+	vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {
 		compatible = "regulator-fixed";
 		enable-active-high;
 		gpio = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pow_en>;
-		regulator-name = "pcie2x1l2_3v3";
+		regulator-name = "vcc3v3_pcie2x1l2";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		vin-supply = <&vcc_sysin>;
@@ -421,7 +421,7 @@ &pcie2x1l2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie20x1_2_perstn_m0>;
 	reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
-	vpcie3v3-supply = <&pcie2x1l2_3v3>;
+	vpcie3v3-supply = <&vcc3v3_pcie2x1l2>;
 	status = "okay";
 };
 
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#17 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

Quoted 22 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 79

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
 		pwms = <&pwm3 0 60000 0>;
 	};
 
-	pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+	vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46

Best regards,
Krzysztof

#18 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

Quoted 31 lines · Krzysztof Kozlowski
Quoted 22 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new

---
  arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 79

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
  		pwms = <&pwm3 0 60000 0>;
  	};
 
-	pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+	vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Quoted 4 lines

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46

Thanks for pointing.
(Please blame other dts too)

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#19 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

In reply to Krzysztof Kozlowski
Quoted 31 lines · Krzysztof Kozlowski
Quoted 22 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new

---
  arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 79

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
  		pwms = <&pwm3 0 60000 0>;
  	};
 
-	pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+	vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Quoted 4 lines

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46

'regulator-[0-9]v[0-9]' is preferred, but 'regulator-[0-9a-z-]+' is also permitted, right?

i.e. regulator-vcc3v3_pcie2x1l2 should be regulator-vcc3v3-pcie2x1l2

Or, should we revert below patch and use 'regulator-[0-9]v[0-9]'?

https://lore.kernel.org/all/[email protected]/

Is 'regulator-0v0' valid?
Is 'regulator-12v0' invalid?

How should we handle multiple 1v8/3v3/5v0 regulators?

Are examples in fixed-regulator.yaml valid? 'regulator-name' should be '[0-9]v[0-9]' even if there is same name?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#20 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

Hi Krzysztof,

Could you please reply to this email?
(Not for me, but for everyone)

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 49 lines · FUKAUMI Naoki
Quoted 30 lines · Krzysztof Kozlowski
Quoted 22 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new
---
  arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---

  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 78

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
           pwms = <&pwm3 0 60000 0>;
       };
-    pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+    vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Quoted 4 lines

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml? h=v6.11-rc1#n46

'regulator-[0-9]v[0-9]' is preferred, but 'regulator-[0-9a-z-]+' is also permitted, right?

i.e. regulator-vcc3v3_pcie2x1l2 should be regulator-vcc3v3-pcie2x1l2

Or, should we revert below patch and use 'regulator-[0-9]v[0-9]'?

 https://lore.kernel.org/
all/[email protected]/

Is 'regulator-0v0' valid?
Is 'regulator-12v0' invalid?

Quoted 15 lines

How should we handle multiple 1v8/3v3/5v0 regulators?

Are examples in fixed-regulator.yaml valid? 'regulator-name' should be '[0-9]v[0-9]' even if there is same name?

Best regards,

Signature · 2 lines
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#21 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

Quoted 4 lines · FUKAUMI Naoki

Hi Krzysztof,

Could you please reply to this email?
(Not for me, but for everyone)

You have me how much time... 3 days to reply?

Quoted 59 lines

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 51 lines · FUKAUMI Naoki
Quoted 31 lines · Krzysztof Kozlowski
Quoted 23 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new
---
  arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---

  1 file changed, 3 insertions(+), 3 deletions(-)
arch/ renamed from arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0

arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 78

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
           pwms = <&pwm3 0 60000 0>;
       };
-    pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+    vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Quoted 6 lines

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml? h=v6.11-rc1#n46

'regulator-[0-9]v[0-9]' is preferred, but 'regulator-[0-9a-z-]+' is also permitted, right?

i.e. regulator-vcc3v3_pcie2x1l2 should be regulator-vcc3v3-pcie2x1l2

Or, should we revert below patch and use 'regulator-[0-9]v[0-9]'?

 https://lore.kernel.org/
all/[email protected]/

Is 'regulator-0v0' valid?

Why would it be valid? Can you have regulator with 0 volts?

Quoted 1 line
Quoted 1 line

Is 'regulator-12v0' invalid?

Read the binding. I gave you very specific link.

Quoted 2 lines
Quoted 2 lines

How should we handle multiple 1v8/3v3/5v0 regulators?

Just add suffix. But usually more than one suffix, vcc+3v3+pcie_2x1l2, means you created a very specific name.

Best regards,
Krzysztof

#22 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · FUKAUMI Naoki

Hi Krzysztof,

Could you please reply to this email?
(Not for me, but for everyone)

You have me how much time... 3 days to reply?

sorry.

Quoted 52 lines
Quoted 52 lines

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 45 lines · FUKAUMI Naoki
Quoted 31 lines · Krzysztof Kozlowski
Quoted 23 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new

---
   arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)
arch/ renamed from arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0

arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 78

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
           pwms = <&pwm3 0 60000 0>;
       };
-    pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+    vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Quoted 6 lines

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml? h=v6.11-rc1#n46

'regulator-[0-9]v[0-9]' is preferred, but 'regulator-[0-9a-z-]+' is also permitted, right?

i.e. regulator-vcc3v3_pcie2x1l2 should be regulator-vcc3v3-pcie2x1l2

Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

Or, should we revert below patch and use 'regulator-[0-9]v[0-9]'?

 https://lore.kernel.org/
all/[email protected]/

Is 'regulator-0v0' valid?

Why would it be valid? Can you have regulator with 0 volts?

There may be a .dtsi that is shared across multiple .dts, so some regulators may not be able to set a specific voltage in the .dtsi.

How should I describe it?

Quoted 3 lines
Quoted 1 line
Quoted 1 line

Is 'regulator-12v0' invalid?

Read the binding. I gave you very specific link.

46| - description: Preferred name is 'regulator-[0-9]v[0-9]'
47| pattern: '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'

The "description" and "pattern" don't match. What you provided is a link to the "description".

Quoted 4 lines
Quoted 1 line
Quoted 1 line

How should we handle multiple 1v8/3v3/5v0 regulators?

Just add suffix. But usually more than one suffix, vcc+3v3+pcie_2x1l2, means you created a very specific name.

So shouldn't we refer to the schematic?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#23 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

Quoted 68 lines · FUKAUMI Naoki
Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · FUKAUMI Naoki

Hi Krzysztof,

Could you please reply to this email?
(Not for me, but for everyone)

You have me how much time... 3 days to reply?

sorry.

Quoted 57 lines
Quoted 57 lines

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 50 lines · FUKAUMI Naoki
Quoted 31 lines · Krzysztof Kozlowski
Quoted 23 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new

---
   arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)
arch/ renamed from arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0

arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 78

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
           pwms = <&pwm3 0 60000 0>;
       };
-    pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+    vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Quoted 6 lines

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml? h=v6.11-rc1#n46

'regulator-[0-9]v[0-9]' is preferred, but 'regulator-[0-9a-z-]+' is also permitted, right?

i.e. regulator-vcc3v3_pcie2x1l2 should be regulator-vcc3v3-pcie2x1l2

Or, should we revert below patch and use 'regulator-[0-9]v[0-9]'?

 https://lore.kernel.org/
all/[email protected]/

Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

Is 'regulator-0v0' valid?

Why would it be valid? Can you have regulator with 0 volts?

There may be a .dtsi that is shared across multiple .dts, so some regulators may not be able to set a specific voltage in the .dtsi.

How should I describe it?

How fixed voltage regulator can have non-specific voltage? Sorry, that's impossible. Shared DTSI with a regulator means that regulator is shared, so it cannot be flexible.

Quoted 10 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

Is 'regulator-12v0' invalid?

Read the binding. I gave you very specific link.

46| - description: Preferred name is 'regulator-[0-9]v[0-9]'
47| pattern: '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'

The "description" and "pattern" don't match. What you provided is a link to the "description".

It's pretty obvious still...

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines

How should we handle multiple 1v8/3v3/5v0 regulators?

Just add suffix. But usually more than one suffix, vcc+3v3+pcie_2x1l2, means you created a very specific name.

So shouldn't we refer to the schematic?

So that's the argument you define 10 fixed, uncontrollable regulators in DTS? What is the benefit of that exactly? Just unnecessary bloat in DTS, in kernel memory and for probe time?

Best regards,
Krzysztof

#24 lore raw

Re: [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for Radxa ROCK 5C

Hello Krzysztof,

Quoted 81 lines · Krzysztof Kozlowski
Quoted 53 lines · FUKAUMI Naoki
Quoted 52 lines · Krzysztof Kozlowski
Quoted 51 lines · FUKAUMI Naoki
Quoted 50 lines · FUKAUMI Naoki
Quoted 31 lines · Krzysztof Kozlowski
Quoted 23 lines · FUKAUMI Naoki

Use consistent name with other regulators. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reword commit message
Changes in v3:
- none
Changes in v2:
- new

---
   arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)
arch/ renamed from arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -0

arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 85589d1a6d3b..61d75ab503b2 100644

arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts pwm-fan { · line 78

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
@@ -76,13 +76,13 @@ pwm-fan {
           pwms = <&pwm3 0 60000 0>;
       };
-    pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+    vcc3v3_pcie2x1l2: regulator-vcc3v3_pcie2x1l2 {

No, neither explained, nor correct. See DTS coding style.

Quoted 6 lines

Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]v[0-9]'

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml? h=v6.11-rc1#n46

'regulator-[0-9]v[0-9]' is preferred, but 'regulator-[0-9a-z-]+' is also permitted, right?

i.e. regulator-vcc3v3_pcie2x1l2 should be regulator-vcc3v3-pcie2x1l2

Or, should we revert below patch and use 'regulator-[0-9]v[0-9]'?

 https://lore.kernel.org/
all/[email protected]/

Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

Is 'regulator-0v0' valid?

Why would it be valid? Can you have regulator with 0 volts?

There may be a .dtsi that is shared across multiple .dts, so some regulators may not be able to set a specific voltage in the .dtsi.

How should I describe it?

How fixed voltage regulator can have non-specific voltage? Sorry, that's impossible. Shared DTSI with a regulator means that regulator is shared, so it cannot be flexible.

Quoted 9 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

Is 'regulator-12v0' invalid?

Read the binding. I gave you very specific link.

46| - description: Preferred name is 'regulator-[0-9]v[0-9]'
47| pattern: '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'

The "description" and "pattern" don't match. What you provided is a link to the "description".

It's pretty obvious still...

Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

How should we handle multiple 1v8/3v3/5v0 regulators?

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Just add suffix. But usually more than one suffix, vcc+3v3+pcie_2x1l2, means you created a very specific name.

So shouldn't we refer to the schematic?

So that's the argument you define 10 fixed, uncontrollable regulators in DTS? What is the benefit of that exactly? Just unnecessary bloat in DTS, in kernel memory and for probe time?

I'm quite surprised to hear you suggesting that some of the hardware components should be omitted from a board dts(i) file. Regardless of some of the hardware components being fixed or adjustable, they should all be described, for the sake of transcribing the board schematic into the board dts(i) files accurately and completely. Furthermore, some fixed components may actually be needed in the board dts(i) files; for example, a fixed regulator may be turned on at boot time, or turned on and off at runtime.

Technically, we could omit the fixed regulators from the board dts(i) files, _only_ if they aren't powered on and off at boot time or at runtime, of course, but many more things could technically be omitted as well from the dts(i) files if we'd follow that rule, which would result in a huge per-board inconsistency, leading to a mess.

#25 lore raw

PATCH v5 5/12 arm64: dts: rockchip: Add properties for pcie2x1l2 for Radxa ROCK 5C

In reply to FUKAUMI Naoki

By schematic[1], pcie2x1l2 CLKREQ and WAKE pins are connected. Describe them in dts.

[1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- reword commit message

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +3 -1
index 61d75ab503b2..01537b47f880 100644
@@ -419,7 +419,9 @@ rgmii_phy1: ethernet-phy@1 {
 
 &pcie2x1l2 {
 	pinctrl-names = "default";
-	pinctrl-0 = <&pcie20x1_2_perstn_m0>;
+	pinctrl-0 = <&pcie20x1_2_perstn_m0>,
+		    <&pcie20x1m0_clkreqn>,
+		    <&pcie20x1m0_waken>;
 	reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
 	vpcie3v3-supply = <&vcc3v3_pcie2x1l2>;
 	status = "okay";
Signature · 1 line
2.43.0
#26 lore raw

PATCH v5 6/12 arm64: dts: rockchip: Remove RTC and related node for Radxa ROCK 5C

In reply to FUKAUMI Naoki

RTC doesn't exist on actual board. Remove it.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- new

---
 .../boot/dts/rockchip/rk3588s-rock-5c.dts     | 23 -------------------
 1 file changed, 23 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +0 -23
index 01537b47f880..1ba94396aab8 100644
@@ -350,23 +350,6 @@ regulator-state-mem {
 	};
 };
 
-&i2c5 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&i2c5m2_xfer>;
-	status = "okay";
-
-	rtc@51 {
-		compatible = "haoyu,hym8563";
-		reg = <0x51>;
-		#clock-cells = <0>;
-		clock-output-names = "rtcic_32kout";
-		interrupt-parent = <&gpio0>;
-		interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&rtc_int_l>;
-	};
-};
-
 &i2c7 {
 	status = "okay";
 
@@ -451,12 +434,6 @@ pow_en: pow-en {
 		};
 	};
 
-	rtc {
-		rtc_int_l: rtc-int-l {
-			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-	};
-
 	usb {
 		usb_host_pwren_h: usb-host-pwren-h {
 			rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
Signature · 1 line
2.43.0
#27 lore raw

PATCH v5 7/12 arm64: dts: rockchip: Separate pinctrl for vcc_5v0 for Radxa ROCK 5C

In reply to FUKAUMI Naoki

vcc_5v0 is used in many places, separate vcc_5v0_pwren_h from usb in pinctrl. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +2 -0
index 1ba94396aab8..b632093183b2 100644
@@ -446,7 +446,9 @@ usb_otg_pwren_h: usb-otg-pwren-h {
 		usb_wifi_pwr: usb-wifi-pwr {
 			rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
+	};
 
+	vcc-5v0 {
 		vcc_5v0_pwren_h: vcc-5v0-pwren-h {
 			rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#28 lore raw

PATCH v5 8/12 arm64: dts: rockchip: Add cd-gpios for sdmmc for Radxa ROCK 5C

In reply to FUKAUMI Naoki

By discussion about cd-gpios and sdmmmc_det pin function[1], it's better to add cd-gpios for now.

[1] https://lore.kernel.org/linux-rockchip/4920950.GXAFRqVoOG@diego/T/#u

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- none

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -0
index b632093183b2..1da082b18c0e 100644
@@ -480,6 +480,7 @@ &sdmmc {
 	bus-width = <4>;
 	cap-mmc-highspeed;
 	cap-sd-highspeed;
+	cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	no-sdio;
 	no-mmc;
Signature · 1 line
2.43.0
#29 lore raw

PATCH v5 9/12 arm64: dts: rockchip: Fix pmic dcdc-reg7 regulator-name for Radxa ROCK 5C

In reply to FUKAUMI Naoki

Fix regulator-name to match with node label. No functinal change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -1
index 1da082b18c0e..0f8048f6511b 100644
@@ -634,7 +634,7 @@ regulator-state-mem {
 			};
 
 			vcc_2v0_pldo_s3: dcdc-reg7 {
-				regulator-name = "vdd_2v0_pldo_s3";
+				regulator-name = "vcc_2v0_pldo_s3";
 				regulator-always-on;
 				regulator-boot-on;
 				regulator-min-microvolt = <2000000>;
Signature · 1 line
2.43.0
#30 lore raw

PATCH v5 10/12 arm64: dts: rockchip: Fix pmic dcdc-reg10 label for Radxa ROCK 5C

In reply to FUKAUMI Naoki

Fix pmic dcdc-reg10 label to match with schematic[1]. No functional change.

[1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- split from "arm64: dts: rockchip: fix pmic properties for Radxa ROCK 5C"

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +2 -2
index 0f8048f6511b..fbe491e63852 100644
@@ -670,8 +670,8 @@ regulator-state-mem {
 				};
 			};
 
-			vcc1v8_pmu_ddr_s3: dcdc-reg10 {
-				regulator-name = "vcc1v8_pmu_ddr_s3";
+			vcc_1v8_s3: dcdc-reg10 {
+				regulator-name = "vcc_1v8_s3";
 				regulator-always-on;
 				regulator-boot-on;
 				regulator-min-microvolt = <1800000>;
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#31 lore raw

Re: [PATCH v5 10/12] arm64: dts: rockchip: Fix pmic dcdc-reg10 label for Radxa ROCK 5C

Quoted 6 lines · FUKAUMI Naoki

Fix pmic dcdc-reg10 label to match with schematic[1]. No functional change.

[1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

All your commits have the same flaw. You claim there is no functional change, yet there is a real bug to fix.

All such trivial cleanups are not fixes and should be squashed together. Best regards,
Krzysztof

#32 lore raw

Re: [PATCH v5 10/12] arm64: dts: rockchip: Fix pmic dcdc-reg10 label for Radxa ROCK 5C

Quoted 4 lines · Krzysztof Kozlowski
Quoted 3 lines · FUKAUMI Naoki

Fix pmic dcdc-reg10 label to match with schematic[1]. No functional change.

Quoted 8 lines
Quoted 3 lines

[1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

All your commits have the same flaw. You claim there is no functional change, yet there is a real bug to fix.

All such trivial cleanups are not fixes and should be squashed together.

I see, I'll do "squashed together" for trivial/cosmetic/no functional changes without "Fixes" tag.

Thanks for pointing.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 3 lines

Best regards,
Krzysztof

#33 lore raw

PATCH v5 11/12 arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C

In reply to FUKAUMI Naoki

Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with vendor kernel[1].

[1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- split from "arm64: dts: rockchip: fix pmic properties for Radxa ROCK 5C"

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +2 -2
index fbe491e63852..60eabe22ef02 100644
@@ -639,7 +639,6 @@ vcc_2v0_pldo_s3: dcdc-reg7 {
 				regulator-boot-on;
 				regulator-min-microvolt = <2000000>;
 				regulator-max-microvolt = <2000000>;
-				regulator-ramp-delay = <12500>;
 
 				regulator-state-mem {
 					regulator-on-in-suspend;
@@ -793,7 +792,8 @@ vdda_0v75_s0: nldo-reg3 {
 				regulator-max-microvolt = <750000>;
 
 				regulator-state-mem {
-					regulator-off-in-suspend;
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <750000>;
 				};
 			};
 
Signature · 1 line
2.43.0
#34 lore raw

Re: [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C

Quoted 1 line · FUKAUMI Naoki

Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with

You have so many typos in almost each commit msg. Here both in subject and commit msg.

Run spell check before you send to the lists. Don't expect the reviewers to be your computer tools.

Explain what is being fixed here. Why would you prefer to match with vendor kernel?

Quoted 7 lines

vendor kernel[1].

[1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---

Best regards,
Krzysztof

#35 lore raw

Re: [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C

Quoted 10 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with

You have so many typos in almost each commit msg. Here both in subject and commit msg.

Run spell check before you send to the lists. Don't expect the reviewers to be your computer tools.

Sorry for my poor English. I'll check it next time.

Quoted 2 lines

Explain what is being fixed here. Why would you prefer to match with vendor kernel?

Not my preference, but the only reference.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 14 lines
Quoted 7 lines

vendor kernel[1].

[1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---

Best regards,
Krzysztof

#36 lore raw

Re: [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C

Quoted 6 lines · FUKAUMI Naoki
Quoted 5 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with

Quoted 7 lines
Quoted 5 lines

You have so many typos in almost each commit msg. Here both in subject and commit msg.

Run spell check before you send to the lists. Don't expect the reviewers to be your computer tools.

Sorry for my poor English. I'll check it next time.

I am not pointing out English. I am pointing out not using standard tool, spellcheck, to fix issues in effortless way.

Quoted 5 lines
Quoted 3 lines

Explain what is being fixed here. Why would you prefer to match with vendor kernel?

Not my preference, but the only reference.

Then why the reference is correct? Provide some arguments why this should be changed to the "reference" and not the "reference" fixed.

Best regards,
Krzysztof

#37 lore raw

Re: [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C

Quoted 19 lines · Krzysztof Kozlowski
Quoted 6 lines · FUKAUMI Naoki
Quoted 5 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki

Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with

Quoted 7 lines
Quoted 5 lines

You have so many typos in almost each commit msg. Here both in subject and commit msg.

Run spell check before you send to the lists. Don't expect the reviewers to be your computer tools.

Sorry for my poor English. I'll check it next time.

I am not pointing out English. I am pointing out not using standard tool, spellcheck, to fix issues in effortless way.

Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Explain what is being fixed here. Why would you prefer to match with vendor kernel?

Not my preference, but the only reference.

Then why the reference is correct? Provide some arguments why this should be changed to the "reference" and not the "reference" fixed.

Are you serious?

Why do you think the current code is correct? It's written by me, typo and copy-pasto generator. Need more argument?

Best regards,

--
FUKAUMI Naoki
Typo and Copy-Pasto Generator

Quoted 3 lines

Best regards,
Krzysztof

#38 lore raw

PATCH v5 12/12 arm64: dts: rockchip: Sort nodes for Radxa ROCK 5C

In reply to FUKAUMI Naoki

Sort nodes alphanumerically. No functional change.

Fixes 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")

---
Changes in v5:
- Reword commit message
Changes in v4:
- reflect other commits, no functional change
Changes in v3:
- none
Changes in v2:
- new

---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +5 -5
index 60eabe22ef02..a987d256c947 100644
@@ -861,10 +861,6 @@ &uart2 {
 	status = "okay";
 };
 
-&usbdp_phy0 {
-	status = "okay";
-};
-
 &usb_host0_ehci {
 	status = "okay";
 };
@@ -886,7 +882,7 @@ &usb_host2_xhci {
 	status = "okay";
 };
 
-&vop_mmu {
+&usbdp_phy0 {
 	status = "okay";
 };
 
@@ -894,6 +890,10 @@ &vop {
 	status = "okay";
 };
 
+&vop_mmu {
+	status = "okay";
+};
+
 &vp0 {
 	vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
 		reg = <ROCKCHIP_VOP2_EP_HDMI0>;
Signature · 1 line
2.43.0