lib: Fix integer overflow in in libiniparser.c
Subsystems (2)
PATCH 1/1 lib: Fix integer overflow in in libiniparser.c
Report of the static analyzer:
Possible integer underflow: left operand is tainted.
An integer underflow may occur due to arithmetic operation (subtraction) between values
{ [-2147483648, 2147483647] } and '1', where the first value comes from the expression '(int)strlen(line)'
Corrections explained:
Modified logic toskip empty lines immediately, reducing unnecessary processing.- Ensured safety by validating len >= 0 before accessing line[len] to avoid out-of-bounds access.
Triggers found by static analyzer Svace.
--- lib/libiniparser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/libiniparser.c +1 -1
@@ -540,7 +540,7 @@ dictionary * iniparser_load(const char * ininame) len-- ; }/* Detect multi-line */ -if (line[len]=='\\' ) { +if (len >=0 && line[len]=='\\' ) {/* Multi-line value */ last=len ;continue ;
Signature · 6 lines
2.30.2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 8 lines · Anton Moryakov
Report of the static analyzer:
Possible integer underflow: left operand is tainted.
An integer underflow may occur due to arithmetic operation (subtraction) between values
{ [-2147483648, 2147483647] } and '1', where the first value comes from the expression '(int)strlen(line)'Corrections explained:
Modified logic toskip empty lines immediately, reducing unnecessary processing.- Ensured safety by validating len >= 0 before accessing line[len] to avoid out-of-bounds access.
Quoted 7 lines
Triggers found by static analyzer Svace.
Signed-off-by Anton Moryakov <[email protected]--- lib/libiniparser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Hi, Anton. I'm fine with the single-point fix solution, and you can add:
Or just like Anton's suggestions, I'm also fine with updating libiniparser from [1], which did solve several bugs in the past few years. And there may be some unused functions should be deleted to avoid compiling warnings.
[1] https://gitlab.com/iniparser/iniparser
Quoted 7 lines
lib/libiniparser.c +0
-0
lib/libiniparser.c dictionary * iniparser_load(const char * ininame) · line 546
Quoted 8 lines
lib/libiniparser.c +1
-1@@ -540,7 +540,7 @@ dictionary * iniparser_load(const char * ininame) len-- ; }/* Detect multi-line */ -if (line[len]=='\\' ) { +if (len >=0 && line[len]=='\\' ) {/* Multi-line value */ last=len ;continue ;
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/