Skip to contentSkip to conversation

staging: gpib: Workaround for ppc build failure

PATCH In review Dave Penkler 3 participants 3 messages Dec 4, 2024 – Dec 16, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: gpib: Workaround for ppc build failure

Make GPIB_FMH depend on !PPC

Reported_by: Stephen Rothwell <[email protected]>

---
 drivers/staging/gpib/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gpib/Kconfig +1 -1
index 95308d15a555..a9b811165f6b 100644
@@ -128,7 +128,7 @@ config GPIB_FMH
        tristate "FMH FPGA based devices"
        select GPIB_COMMON
        select GPIB_NEC7210
-       depends on BROKEN
+       depends on !PPC
        depends on OF && PCI
        help
          GPIB driver for fmhess FPGA based devices
Signature · 1 line
2.47.1
#1 lore raw
Quoted 6 lines · Dave Penkler

Make GPIB_FMH depend on !PPC

Reported_by: Stephen Rothwell <[email protected]>

This patch just exposes other build failures, for example i386:allyesconfig or x86_64:allyesconfig.

Error log:
x86_64-linux-ld: vmlinux.o: in function `fmh_gpib_t1_delay':
fmh_gpib.c:(.text+0xfd49dbd): undefined reference to `nec7210_t1_delay'

There are many more missing functions. FWIW, I don't know how this is supposed to work in the first place, since pretty much all gpib Makefiles say

obj-m += <object file>

meaning they won't be built with allyesconfig. fmh_gpib is the only exception with

obj-$(CONFIG_GPIB_FMH) += fmh_gpib.o

which means it _will_ be built with allyesconfig. So it is not surprising that it fails to link allyesconfig builds. Actually, it will fail all builds with CONFIG_GPIB_FMH=y.

Guenter

maintainer
#2 lore raw
Quoted 21 lines · Guenter Roeck
Quoted 6 lines · Dave Penkler

Make GPIB_FMH depend on !PPC

Reported_by: Stephen Rothwell <[email protected]>

This patch just exposes other build failures, for example i386:allyesconfig or x86_64:allyesconfig.

Error log:
x86_64-linux-ld: vmlinux.o: in function `fmh_gpib_t1_delay':
fmh_gpib.c:(.text+0xfd49dbd): undefined reference to `nec7210_t1_delay'

There are many more missing functions. FWIW, I don't know how this is supposed to work in the first place, since pretty much all gpib Makefiles say

obj-m += <object file>

Quoted 8 lines

meaning they won't be built with allyesconfig. fmh_gpib is the only exception with

obj-$(CONFIG_GPIB_FMH) += fmh_gpib.o

which means it _will_ be built with allyesconfig. So it is not surprising that it fails to link allyesconfig builds. Actually, it will fail all builds with CONFIG_GPIB_FMH=y.

Arnd has a patch for this that I'll be queueing up this week and getting to Linus also this week.

thanks,

greg k-h