Skip to contentSkip to conversation

media: cec: include linux/debugfs.h and linux/seq_file.h where needed

PATCH In review Jani Nikula 2 participants 4 messages Dec 17, 2024 – Dec 31, 2024 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 media: cec: include linux/debugfs.h and linux/seq_file.h where needed

Having cec.h include linux/debugfs.h leads to all users of all cec headers include and depend on debugfs.h and its dependencies for no reason. Drop the include from cec.h, and include debugfs.h and seq_file.h where needed.

Sort all the modified include lists while at it.

---

v2: Rebase, update cec-pin-error-inj.c and cec-gpio.c too

Depends on commit ae19ba915eb7 ("drm/i915/display: include media/cec-notifier.h and linux/debugfs.h where needed") in v6.13-rc1

---
 drivers/media/cec/core/cec-adap.c              | 5 +++--
 drivers/media/cec/core/cec-core.c              | 5 +++--
 drivers/media/cec/core/cec-pin-error-inj.c     | 3 ++-
 drivers/media/cec/core/cec-pin.c               | 3 ++-
 drivers/media/cec/platform/cec-gpio/cec-gpio.c | 7 ++++---
 include/media/cec.h                            | 1 -
 6 files changed, 14 insertions(+), 10 deletions(-)
drivers/media/cec/core/cec-adap.c +3 -2
index c7d36010c890..ba6828ef540e 100644
@@ -7,12 +7,13 @@
 
 #include <linux/errno.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/kmod.h>
 #include <linux/ktime.h>
-#include <linux/slab.h>
 #include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/types.h>
 
drivers/media/cec/core/cec-core.c +3 -2
index ca0db8d457b4..e10bd588a586 100644
@@ -5,13 +5,14 @@
  * Copyright 2016 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
  */
 
+#include <linux/debugfs.h>
 #include <linux/errno.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/kmod.h>
-#include <linux/slab.h>
 #include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/types.h>
 
drivers/media/cec/core/cec-pin-error-inj.c +2 -1
index fc0968b9d40e..6e61a04b8168 100644
@@ -4,8 +4,9 @@
  */
 
 #include <linux/delay.h>
-#include <linux/slab.h>
 #include <linux/sched/types.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include <media/cec-pin.h>
 #include "cec-pin-priv.h"
drivers/media/cec/core/cec-pin.c +2 -1
index 330d5d5d86ab..a70451d99ebc 100644
@@ -4,8 +4,9 @@
  */
 
 #include <linux/delay.h>
-#include <linux/slab.h>
 #include <linux/sched/types.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include <media/cec-pin.h>
 #include "cec-pin-priv.h"
drivers/media/cec/platform/cec-gpio/cec-gpio.c +4 -3
index cf64e8871fe5..50cdc557c943 100644
@@ -3,11 +3,12 @@
  * Copyright 2017 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
  */
 
-#include <linux/module.h>
-#include <linux/interrupt.h>
 #include <linux/delay.h>
-#include <linux/platform_device.h>
 #include <linux/gpio/consumer.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <media/cec-notifier.h>
 #include <media/cec-pin.h>
 
include/media/cec.h +0 -1
index 16b412b3131b..0c8e86115b6f 100644
@@ -10,7 +10,6 @@
 
 #include <linux/poll.h>
 #include <linux/fs.h>
-#include <linux/debugfs.h>
 #include <linux/device.h>
 #include <linux/cdev.h>
 #include <linux/kthread.h>
Signature · 1 line
2.39.5

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 8 lines · Patchwork Integration

Dear Jani Nikula:

Thanks for your patches! Unfortunately media-ci detected some issues:

# Test virtme64:test-virtme
Final Summary: 3607, Succeeded: 3607, Failed: 0, Warnings: 2 Warnings Found!

Quoted 8 lines

# Test media-patchstyle:./0001-media-cec-include-linux-debugfs.h-and-linux-seq_file.patch media style
WARNING: ./0001-media-cec-include-linux-debugfs.h-and-linux-seq_file.patch: Don't Cc hverkuil (Cc: Hans Verkuil <[email protected]>)
WARNING: ./0001-media-cec-include-linux-debugfs.h-and-linux-seq_file.patch: Don't Cc linux-media (Cc: [email protected])

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

Really? Just to drop Cc's?

Quoted 11 lines

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/68302192/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

Doesn't say anything about Cc's.

BR,
Jani.

Quoted 5 lines

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 1 line
Jani Nikula, Intel
#3 lore raw
In reply to Jani Nikula
Quoted 10 lines · Jani Nikula

Having cec.h include linux/debugfs.h leads to all users of all cec headers include and depend on debugfs.h and its dependencies for no reason. Drop the include from cec.h, and include debugfs.h and seq_file.h where needed.

Sort all the modified include lists while at it.

Ping?

Quoted 119 lines

---

v2: Rebase, update cec-pin-error-inj.c and cec-gpio.c too

Depends on commit ae19ba915eb7 ("drm/i915/display: include media/cec-notifier.h and linux/debugfs.h where needed") in v6.13-rc1

---
 drivers/media/cec/core/cec-adap.c              | 5 +++--
 drivers/media/cec/core/cec-core.c              | 5 +++--
 drivers/media/cec/core/cec-pin-error-inj.c     | 3 ++-
 drivers/media/cec/core/cec-pin.c               | 3 ++-
 drivers/media/cec/platform/cec-gpio/cec-gpio.c | 7 ++++---
 include/media/cec.h                            | 1 -
 6 files changed, 14 insertions(+), 10 deletions(-)
drivers/media/cec/core/cec-adap.c +3 -2
index c7d36010c890..ba6828ef540e 100644
@@ -7,12 +7,13 @@
 
 #include <linux/errno.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/kmod.h>
 #include <linux/ktime.h>
-#include <linux/slab.h>
 #include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/types.h>
 
drivers/media/cec/core/cec-core.c +3 -2
index ca0db8d457b4..e10bd588a586 100644
@@ -5,13 +5,14 @@
  * Copyright 2016 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
  */
 
+#include <linux/debugfs.h>
 #include <linux/errno.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/kmod.h>
-#include <linux/slab.h>
 #include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/types.h>
 
drivers/media/cec/core/cec-pin-error-inj.c +2 -1
index fc0968b9d40e..6e61a04b8168 100644
@@ -4,8 +4,9 @@
  */
 
 #include <linux/delay.h>
-#include <linux/slab.h>
 #include <linux/sched/types.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include <media/cec-pin.h>
 #include "cec-pin-priv.h"
drivers/media/cec/core/cec-pin.c +2 -1
index 330d5d5d86ab..a70451d99ebc 100644
@@ -4,8 +4,9 @@
  */
 
 #include <linux/delay.h>
-#include <linux/slab.h>
 #include <linux/sched/types.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include <media/cec-pin.h>
 #include "cec-pin-priv.h"
drivers/media/cec/platform/cec-gpio/cec-gpio.c +4 -3
index cf64e8871fe5..50cdc557c943 100644
@@ -3,11 +3,12 @@
  * Copyright 2017 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
  */
 
-#include <linux/module.h>
-#include <linux/interrupt.h>
 #include <linux/delay.h>
-#include <linux/platform_device.h>
 #include <linux/gpio/consumer.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <media/cec-notifier.h>
 #include <media/cec-pin.h>
 
include/media/cec.h +0 -1
index 16b412b3131b..0c8e86115b6f 100644
@@ -10,7 +10,6 @@
 
 #include <linux/poll.h>
 #include <linux/fs.h>
-#include <linux/debugfs.h>
 #include <linux/device.h>
 #include <linux/cdev.h>
 #include <linux/kthread.h>
Signature · 1 line
Jani Nikula, Intel
#4 lore raw
Quoted 6 lines · Jani Nikula
Quoted 5 lines · Jani Nikula

Having cec.h include linux/debugfs.h leads to all users of all cec headers include and depend on debugfs.h and its dependencies for no reason. Drop the include from cec.h, and include debugfs.h and seq_file.h where needed.

Quoted 7 lines
Quoted 5 lines

Sort all the modified include lists while at it.

Ping?

I plan to pick it up next week, when I'm back from my Christmas vacation.

Regards,

Hans

Quoted 121 lines
Quoted 120 lines

---

v2: Rebase, update cec-pin-error-inj.c and cec-gpio.c too

Depends on commit ae19ba915eb7 ("drm/i915/display: include media/cec-notifier.h and linux/debugfs.h where needed") in v6.13-rc1

---
 drivers/media/cec/core/cec-adap.c              | 5 +++--
 drivers/media/cec/core/cec-core.c              | 5 +++--
 drivers/media/cec/core/cec-pin-error-inj.c     | 3 ++-
 drivers/media/cec/core/cec-pin.c               | 3 ++-
 drivers/media/cec/platform/cec-gpio/cec-gpio.c | 7 ++++---
 include/media/cec.h                            | 1 -
 6 files changed, 14 insertions(+), 10 deletions(-)
drivers/media/cec/core/cec-adap.c +3 -2
index c7d36010c890..ba6828ef540e 100644
@@ -7,12 +7,13 @@
 
 #include <linux/errno.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/kmod.h>
 #include <linux/ktime.h>
-#include <linux/slab.h>
 #include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/types.h>
 
drivers/media/cec/core/cec-core.c +3 -2
index ca0db8d457b4..e10bd588a586 100644
@@ -5,13 +5,14 @@
  * Copyright 2016 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
  */
 
+#include <linux/debugfs.h>
 #include <linux/errno.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/kmod.h>
-#include <linux/slab.h>
 #include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/types.h>
 
drivers/media/cec/core/cec-pin-error-inj.c +2 -1
index fc0968b9d40e..6e61a04b8168 100644
@@ -4,8 +4,9 @@
  */
 
 #include <linux/delay.h>
-#include <linux/slab.h>
 #include <linux/sched/types.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include <media/cec-pin.h>
 #include "cec-pin-priv.h"
drivers/media/cec/core/cec-pin.c +2 -1
index 330d5d5d86ab..a70451d99ebc 100644
@@ -4,8 +4,9 @@
  */
 
 #include <linux/delay.h>
-#include <linux/slab.h>
 #include <linux/sched/types.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
 
 #include <media/cec-pin.h>
 #include "cec-pin-priv.h"
drivers/media/cec/platform/cec-gpio/cec-gpio.c +4 -3
index cf64e8871fe5..50cdc557c943 100644
@@ -3,11 +3,12 @@
  * Copyright 2017 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
  */
 
-#include <linux/module.h>
-#include <linux/interrupt.h>
 #include <linux/delay.h>
-#include <linux/platform_device.h>
 #include <linux/gpio/consumer.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <media/cec-notifier.h>
 #include <media/cec-pin.h>
 
include/media/cec.h +0 -1
index 16b412b3131b..0c8e86115b6f 100644
@@ -10,7 +10,6 @@
 
 #include <linux/poll.h>
 #include <linux/fs.h>
-#include <linux/debugfs.h>
 #include <linux/device.h>
 #include <linux/cdev.h>
 #include <linux/kthread.h>