fix some bsg related bugs
Subsystems (2)
v2 cover fix some bsg related bugs
Changes from v1 to v2:
- Add fixes tag to the first patch.
- Add rb tag from Avri, thanks.
Guixin Liu (2):
scsi: ufs: delete bsg_dev when setup bsg fail
scsi: ufs: set bsg_queue to NULL after remove
drivers/ufs/core/ufs_bsg.c | 2 ++ 1 file changed, 2 insertions(+)
Signature · 1 line
2.43.0
PATCH v2 1/2 scsi: ufs: delete bsg_dev when setup bsg fail
We should remove the bsg device when bsg_setup_queue() return fail to release the resources.
--- drivers/ufs/core/ufs_bsg.c | 1 + 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs_bsg.c +1 -0
@@ -257,6 +257,7 @@ int ufs_bsg_probe(struct ufs_hba *hba) NULL, 0);if (IS_ERR (q)) { ret =PTR_ERR (q); +device_del (bsg_dev); goto out; }
Signature · 1 line
2.43.0
PATCH v2 2/2 scsi: ufs: set bsg_queue to NULL after remove
In reply to Guixin LiuCurrently, this does not cause any issues, but I believe it is necessary to set bsg_queue to NULL after removing it to prevent potential use-after-free (UAF) access.
--- drivers/ufs/core/ufs_bsg.c | 1 + 1 file changed, 1 insertion(+)
drivers/ufs/core/ufs_bsg.c +1 -0
@@ -216,6 +216,7 @@ void ufs_bsg_remove(struct ufs_hba *hba)return ;bsg_remove_queue (hba->bsg_queue); + hba->bsg_queue =NULL ;device_del (bsg_dev);put_device (bsg_dev);
Signature · 1 line
2.43.0
Martin K. Petersen
AppliedGuixin,
Quoted 3 lines
Guixin Liu (2):
scsi: ufs: deletebsg_devwhen setup bsg fail
scsi: ufs: setbsg_queueto NULL after remove
Applied to 6.14/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering