Skip to contentSkip to conversation

imx8-isi fixes and improvements

GIT PULL Laurent Pinchart 3 participants 6 messages Dec 18, 2024 – Jan 3, 2025 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro, Hans,

The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37:

Linux 6.13-rc1 (2024-12-01 14:28:56 -0800)

are available in the Git repository at:

https://gitlab.freedesktop.org/linux-media/users/pinchartl.git tags/next-media-nxp-20241218

for you to fetch changes up to ee8b722db9a4d4b370ecf9a0b2a6ad39e254daee:

media: nxp: imx8-isi: Add i.MX8ULP support (2024-12-04 18:50:05 +0200)

----------------------------------------------------------------
Miscellaneous imx8-isi fixes and improvements

----------------------------------------------------------------
Guoniu.zhou (2):
dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string
media: nxp: imx8-isi: Add i.MX8ULP support

Laurentiu Palcu (1):
media: nxp: imx8-isi: fix v4l2-compliance test errors

 Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml |  2 ++
 drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c       | 14 ++++++++++++++
 drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h       |  1 +
 drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c      |  3 +++
 4 files changed, 20 insertions(+)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

Re: [GIT PULL FOR v6.14] imx8-isi fixes and improvements (#106186)

From: [email protected]

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/408806/
Build time: 00:14:03

gpg: Signature made Wed 18 Dec 2024 12:29:26 AM UTC
gpg:                using EDDSA key 7804022A38B7D13F41738C3685F1965061424BE1
gpg:                issuer "[email protected]"
gpg: Good signature from "Laurent Pinchart <[email protected]>" [full]
gpg: [email protected]: Verified 6 signatures in the past

5 months. Encrypted 0 messages.

Summary: no issues. All 3 looked fine.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 9 lines · Patchwork Integration

Dear Laurent Pinchart:

Thanks for your patches! Unfortunately media-ci detected some issues:

# Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style
WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but [email protected] not in Cc:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

I don't think Cc: stable makes sense for this particular commit.

Quoted 9 lines

total: 0 errors, 1 warnings, 15 lines checked
WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests

# Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

total: 0 errors, 1 warnings, 0 checks, 15 lines checked

This I can fix. I'll wait for replies to the above though.

Quoted 18 lines

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/68354451/artifacts/report.htm .

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw

Em Wed, 18 Dec 2024 04:18:47 +0200
Laurent Pinchart <[email protected]> escreveu:

Quoted 5 lines · Patchwork Integration
Quoted 4 lines

Dear Laurent Pinchart:

Thanks for your patches! Unfortunately media-ci detected some issues:

Quoted 7 lines
Quoted 5 lines

# Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style
WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but [email protected] not in Cc:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

I don't think Cc: stable makes sense for this particular commit.

Sure, not all commits are actually fixing things, but, in this particular case, it sounds that it contains a real problem:

	Running the v4l2-compliance (1.27.0-5208, SHA: af114250d48d) on the m2m
	device fails on the MMAP streaming tests, with the following messages:

	fail: v4l2-test-buffers.cpp(240): g_field() == V4L2_FIELD_ANY
	fail: v4l2-test-buffers.cpp(1508): buf.qbuf(node)

causing userspace to fail. For me, it seems that such patch needs to be backported.

In doubt, please add c/c stable when fixes is used. If there are good reasons why not doing it, please place the rationale at the patch.

Quoted 11 lines
Quoted 9 lines

total: 0 errors, 1 warnings, 15 lines checked
WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests

# Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

total: 0 errors, 1 warnings, 0 checks, 15 lines checked

This I can fix. I'll wait for replies to the above though.

Please do it.

The rest of the PR sounds OK on my eyes.

Thanks,
Mauro

#5 lore raw

Hi Mauro,

Quoted 17 lines · Mauro Carvalho Chehab

Em Wed, 18 Dec 2024 04:18:47 +0200 Laurent Pinchart escreveu:

Quoted 5 lines · Patchwork Integration
Quoted 4 lines

Dear Laurent Pinchart:

Thanks for your patches! Unfortunately media-ci detected some issues:

Quoted 7 lines
Quoted 5 lines

# Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style
WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but [email protected] not in Cc:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

I don't think Cc: stable makes sense for this particular commit.

Sure, not all commits are actually fixing things, but, in this particular case, it sounds that it contains a real problem:

Quoted 8 lines
	Running the v4l2-compliance (1.27.0-5208, SHA: af114250d48d) on the m2m
	device fails on the MMAP streaming tests, with the following messages:

	fail: v4l2-test-buffers.cpp(240): g_field() == V4L2_FIELD_ANY
	fail: v4l2-test-buffers.cpp(1508): buf.qbuf(node)

causing userspace to fail. For me, it seems that such patch needs to be backported.

If the fix wasn't fixing a problem, it wouldn't be a fix :-) The reason why I don't think this is worth a backport is that it only fixes an issue reported by v4l2-compliance, that hasn't to my knowledge affected anyone in other use cases. Given that the driver evolves, backporting this change blindly, testing compilation only but not runtime operation, has a higher risk of introducing failures in stable kernels than it has a chance to fix issues that affect people.

Quoted 18 lines

In doubt, please add c/c stable when fixes is used. If there are good reasons why not doing it, please place the rationale at the patch.

Quoted 11 lines
Quoted 9 lines

total: 0 errors, 1 warnings, 15 lines checked
WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests

# Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

total: 0 errors, 1 warnings, 0 checks, 15 lines checked

This I can fix. I'll wait for replies to the above though.

Please do it.

The rest of the PR sounds OK on my eyes.

Signature · 3 lines
Regards,

Laurent Pinchart
#6 lore raw
Quoted 27 lines · Laurent Pinchart
Quoted 17 lines · Mauro Carvalho Chehab

Em Wed, 18 Dec 2024 04:18:47 +0200 Laurent Pinchart escreveu:

Quoted 5 lines · Patchwork Integration
Quoted 4 lines

Dear Laurent Pinchart:

Thanks for your patches! Unfortunately media-ci detected some issues:

Quoted 7 lines
Quoted 5 lines

# Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style
WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but [email protected] not in Cc:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

I don't think Cc: stable makes sense for this particular commit.

Sure, not all commits are actually fixing things, but, in this particular case, it sounds that it contains a real problem:

Quoted 8 lines
	Running the v4l2-compliance (1.27.0-5208, SHA: af114250d48d) on the m2m
	device fails on the MMAP streaming tests, with the following messages:

	fail: v4l2-test-buffers.cpp(240): g_field() == V4L2_FIELD_ANY
	fail: v4l2-test-buffers.cpp(1508): buf.qbuf(node)

causing userspace to fail. For me, it seems that such patch needs to be backported.

Quoted 7 lines

If the fix wasn't fixing a problem, it wouldn't be a fix :-) The reason why I don't think this is worth a backport is that it only fixes an issue reported by v4l2-compliance, that hasn't to my knowledge affected anyone in other use cases. Given that the driver evolves, backporting this change blindly, testing compilation only but not runtime operation, has a higher risk of introducing failures in stable kernels than it has a chance to fix issues that affect people.

As there has been no voiced disagreement, I'll send a new version of the pull request without "Cc: stable" for this commit.

Quoted 18 lines
Quoted 18 lines

In doubt, please add c/c stable when fixes is used. If there are good reasons why not doing it, please place the rationale at the patch.

Quoted 11 lines
Quoted 9 lines

total: 0 errors, 1 warnings, 15 lines checked
WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests

# Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' #16:

Fixes cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")

total: 0 errors, 1 warnings, 0 checks, 15 lines checked

This I can fix. I'll wait for replies to the above though.

Please do it.

The rest of the PR sounds OK on my eyes.

Signature · 3 lines
Regards,

Laurent Pinchart