staging: gpib: Rename variable ValidAll
PATCH 1/1 staging: gpib: Rename variable ValidAll
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Avoid CamelCase: <ValidALL>
+ int status = ValidALL;
--- drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 2 +- drivers/staging/gpib/cb7210/cb7210.c | 2 +- drivers/staging/gpib/eastwood/fluke_gpib.c | 2 +- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 2 +- drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +- drivers/staging/gpib/ines/ines_gpib.c | 2 +- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 2 +- drivers/staging/gpib/tms9914/tms9914.c | 2 +- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 2 +- drivers/staging/gpib/uapi/gpib_user.h | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-)
drivers/staging/gpib/agilent_82357a/agilent_82357a.c +1 -1
@@ -999,7 +999,7 @@ static int agilent_82357a_line_status(const gpib_board_t *board)struct usb_device *usb_dev =interface_to_usbdev (a_priv->bus_interface);struct agilent_82357a_register_pairlet bus_status;int retval; -int status = ValidALL; +int status =VALIDALL ; bus_status.address =BSR ; retval =agilent_82357a_read_registers (a_priv, &bus_status,1 ,0 );
drivers/staging/gpib/cb7210/cb7210.c +1 -1
@@ -377,7 +377,7 @@ int cb7210_accel_write(gpib_board_t *board, uint8_t *buffer, size_t length, intint cb7210_line_status (const gpib_board_t *board) { -int status = ValidALL; +int status =VALIDALL ;int bsr_bits;struct cb7210_priv *cb_priv;struct nec7210_priv *nec_priv;
drivers/staging/gpib/eastwood/fluke_gpib.c +1 -1
@@ -191,7 +191,7 @@ static void fluke_return_to_local(gpib_board_t *board)static int fluke_line_status (const gpib_board_t *board) { -int status = ValidALL; +int status =VALIDALL ;int bsr_bits;struct fluke_priv *e_priv;struct nec7210_priv *nec_priv;
drivers/staging/gpib/fmh_gpib/fmh_gpib.c +1 -1
@@ -223,7 +223,7 @@ static void fmh_gpib_return_to_local(gpib_board_t *board)static int fmh_gpib_line_status (const gpib_board_t *board) { -int status = ValidALL; +int status =VALIDALL ;int bsr_bits;struct fmh_priv *e_priv;struct nec7210_priv *nec_priv;
drivers/staging/gpib/gpio/gpib_bitbang.c +1 -1
@@ -1035,7 +1035,7 @@ static void bb_return_to_local(gpib_board_t *board)static int bb_line_status (const gpib_board_t *board) { -int line_status = ValidALL; +int line_status =VALIDALL ;// dbg_printk(1,"\n");
drivers/staging/gpib/ines/ines_gpib.c +1 -1
@@ -23,7 +23,7 @@ MODULE_DESCRIPTION("GPIB driver for Ines iGPIB 72010");int ines_line_status (const gpib_board_t *board) { -int status = ValidALL; +int status =VALIDALL ;int bcm_bits;struct ines_priv *ines_priv;struct nec7210_priv *nec_priv;
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +1 -1
@@ -702,7 +702,7 @@ static void usb_gpib_interface_clear(gpib_board_t *board, int assert)static int usb_gpib_line_status (const gpib_board_t *board) {int buffer; -int line_status = ValidALL;/* all lines will be read */ +int line_status =VALIDALL ;/* all lines will be read */ struct list_head *p, *q;WQT *item;unsigned long flags;
drivers/staging/gpib/ni_usb/ni_usb_gpib.c +1 -1
@@ -1483,7 +1483,7 @@ static int ni_usb_line_status(const gpib_board_t *board)int bytes_written =0 , bytes_read =0 ;int i =0 ;unsigned int bsr_bits; -int line_status = ValidALL; +int line_status =VALIDALL ;// NI windows driver reads 0xd(HSSEL), 0xc (ARD0), 0x1f (BSR) out_data =kmalloc (out_data_length,GFP_KERNEL );
drivers/staging/gpib/tms9914/tms9914.c +1 -1
@@ -390,7 +390,7 @@ static unsigned int update_status_nolock(gpib_board_t *board, struct tms9914_priint tms9914_line_status (const gpib_board_t *board,struct tms9914_priv *priv) {int bsr_bits; -int status = ValidALL; +int status =VALIDALL ; bsr_bits =read_byte (priv,BSR );
drivers/staging/gpib/tnt4882/tnt4882_gpib.c +1 -1
@@ -194,7 +194,7 @@ MODULE_DESCRIPTION("GPIB driver for National Instruments boards using tnt4882 orint tnt4882_line_status (const gpib_board_t *board) { -int status = ValidALL; +int status =VALIDALL ;int bcsr_bits;struct tnt4882_priv *tnt_priv;
drivers/staging/gpib/uapi/gpib_user.h +1 -1
@@ -114,7 +114,7 @@ enum bus_control_line { ValidSRQ =0x20 , ValidATN =0x40 , ValidEOI =0x80 , - ValidALL =0xff , +VALIDALL =0xff , BusDAV =0x0100 ,/* DAV line status bit */ BusNDAC =0x0200 ,/* NDAC line status bit */ BusNRFD = 0x0400, /* NRFD line status bit */
Signature · 1 line
2.43.0
Greg Kroah-Hartman
maintainerdrivers/staging/gpib/uapi/gpib_user.h enum bus_control_line { · line 117
Quoted 8 lines · Antonio Riccio
drivers/staging/gpib/uapi/gpib_user.h +1
-1@@ -114,7 +114,7 @@ enum bus_control_line { ValidSRQ =0x20 , ValidATN =0x40 , ValidEOI =0x80 , - ValidALL = 0xff, + VALIDALL = 0xff,
Why are you only changing one of these? And are you sure that these values aren't coming from a specification with this type of naming?
thanks,
greg k-h
Quoted 13 lines · Greg Kroah-Hartman
drivers/staging/gpib/uapi/gpib_user.h enum bus_control_line { · line 117
Quoted 8 lines · Antonio Riccio
drivers/staging/gpib/uapi/gpib_user.h +1
-1@@ -114,7 +114,7 @@ enum bus_control_line { ValidSRQ =0x20 , ValidATN =0x40 , ValidEOI =0x80 , - ValidALL = 0xff, + VALIDALL = 0xff,Why are you only changing one of these? And are you sure that these values aren't coming from a specification with this type of naming?
Quoted 3 lines
thanks,
greg k-h
I prefer that we keep the camel case definitions in the uapi includes as they are for now so that they remain compatible with the current user space includes. Over time I will release a version of the user space includes that provide compatability definitions for the checkpatch clean version of the uapi includes. This includes the camel case definitions and the typedefs. I will submit a patches for this in the new year.
-dave
Greg Kroah-Hartman
maintainerQuoted 16 lines · Dave Penkler
Quoted 15 lines · Greg Kroah-Hartman
drivers/staging/gpib/uapi/gpib_user.h enum bus_control_line { · line 117
Quoted 8 lines · Antonio Riccio
drivers/staging/gpib/uapi/gpib_user.h +1
-1@@ -114,7 +114,7 @@ enum bus_control_line { ValidSRQ =0x20 , ValidATN =0x40 , ValidEOI =0x80 , - ValidALL = 0xff, + VALIDALL = 0xff,Why are you only changing one of these? And are you sure that these values aren't coming from a specification with this type of naming?
thanks,
Quoted 8 lines
Quoted 1 line
greg k-h
I prefer that we keep the camel case definitions in the uapi includes as they are for now so that they remain compatible with the current user space includes. Over time I will release a version of the user space includes that provide compatability definitions for the checkpatch clean version of the uapi includes. This includes the camel case definitions and the typedefs. I will submit a patches for this in the new year.
Ah, this is uapi, we really can't change them all that easily anyway :)
thanks for the quick review.
greg k-h