Skip to contentSkip to conversation

scsi: target: Remove unused functions

PATCH Applied [email protected] 2 participants 3 messages Dec 22, 2024 – Jan 10, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: target: Remove unused functions

From: "Dr. David Alan Gilbert" <[email protected]>

The functions:
iscsit_check_unsolicited_dataout()
iscsit_fail_session()
iscsit_create_conn_recovery_datain_values()
iscsit_create_conn_recovery_dataout_values()
iscsit_tpg_dump_params()
iscsit_print_session_params()

were all added in 2011 by
commit e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")

but have remained unused.

Remove them.

Having deleted them, the functions:
iscsi_print_params()
iscsi_dump_conn_ops()
iscsi_dump_sess_ops()

are also unused.

Remove them.

---
 drivers/target/iscsi/iscsi_target.c           | 15 -----
 drivers/target/iscsi/iscsi_target.h           |  1 -
 drivers/target/iscsi/iscsi_target_erl2.c      | 48 ---------------
 drivers/target/iscsi/iscsi_target_erl2.h      |  2 -
 .../target/iscsi/iscsi_target_parameters.c    | 48 ---------------
 .../target/iscsi/iscsi_target_parameters.h    |  3 -
 drivers/target/iscsi/iscsi_target_tpg.c       |  5 --
 drivers/target/iscsi/iscsi_target_tpg.h       |  1 -
 drivers/target/iscsi/iscsi_target_util.c      | 58 -------------------
 drivers/target/iscsi/iscsi_target_util.h      |  2 -
 10 files changed, 183 deletions(-)
drivers/target/iscsi/iscsi_target.c +0 -15
index 6002283cbeba..3c889b26f099 100644
@@ -4727,21 +4727,6 @@ int iscsit_logout_post_handler(
 }
 EXPORT_SYMBOL(iscsit_logout_post_handler);
 
-void iscsit_fail_session(struct iscsit_session *sess)
-{
-	struct iscsit_conn *conn;
-
-	spin_lock_bh(&sess->conn_lock);
-	list_for_each_entry(conn, &sess->sess_conn_list, conn_list) {
-		pr_debug("Moving to TARG_CONN_STATE_CLEANUP_WAIT.\n");
-		conn->conn_state = TARG_CONN_STATE_CLEANUP_WAIT;
-	}
-	spin_unlock_bh(&sess->conn_lock);
-
-	pr_debug("Moving to TARG_SESS_STATE_FAILED.\n");
-	sess->session_state = TARG_SESS_STATE_FAILED;
-}
-
 void iscsit_stop_session(
 	struct iscsit_session *sess,
 	int session_sleep,
drivers/target/iscsi/iscsi_target.h +0 -1
index 873411e95ed2..f4addae2aae4 100644
@@ -40,7 +40,6 @@ extern int iscsi_target_tx_thread(void *);
 extern int iscsi_target_rx_thread(void *);
 extern int iscsit_close_connection(struct iscsit_conn *);
 extern int iscsit_close_session(struct iscsit_session *, bool can_sleep);
-extern void iscsit_fail_session(struct iscsit_session *);
 extern void iscsit_stop_session(struct iscsit_session *, int, int);
 extern int iscsit_release_sessions_for_tpg(struct iscsi_portal_group *, int);
 
drivers/target/iscsi/iscsi_target_erl2.c +0 -48

54 lines not on this page · raw message

drivers/target/iscsi/iscsi_target_erl2.h +0 -2
index 6655e4bcf893..9064c74eef7a 100644
@@ -9,8 +9,6 @@ struct iscsit_conn;
 struct iscsi_conn_recovery;
 struct iscsit_session;
 
-extern void iscsit_create_conn_recovery_datain_values(struct iscsit_cmd *, __be32);
-extern void iscsit_create_conn_recovery_dataout_values(struct iscsit_cmd *);
 extern struct iscsi_conn_recovery *iscsit_get_inactive_connection_recovery_entry(
 			struct iscsit_session *, u16);
 extern void iscsit_free_connection_recovery_entries(struct iscsit_session *);
drivers/target/iscsi/iscsi_target_parameters.c +0 -48

54 lines not on this page · raw message

drivers/target/iscsi/iscsi_target_parameters.h +0 -3
index 00fbbebb8c75..c672a971fcb7 100644
@@ -32,9 +32,6 @@ struct iscsi_sess_ops;
 
 extern int iscsi_login_rx_data(struct iscsit_conn *, char *, int);
 extern int iscsi_login_tx_data(struct iscsit_conn *, char *, char *, int);
-extern void iscsi_dump_conn_ops(struct iscsi_conn_ops *);
-extern void iscsi_dump_sess_ops(struct iscsi_sess_ops *);
-extern void iscsi_print_params(struct iscsi_param_list *);
 extern int iscsi_create_default_params(struct iscsi_param_list **);
 extern int iscsi_set_keys_to_negotiate(struct iscsi_param_list *, bool);
 extern int iscsi_set_keys_irrelevant_for_discovery(struct iscsi_param_list *);
drivers/target/iscsi/iscsi_target_tpg.c +0 -5
index f7bac98fd4fe..bf06cfdfb012 100644
@@ -200,11 +200,6 @@ static void iscsit_clear_tpg_np_login_threads(
 	spin_unlock(&tpg->tpg_np_lock);
 }
 
-void iscsit_tpg_dump_params(struct iscsi_portal_group *tpg)
-{
-	iscsi_print_params(tpg->param_list);
-}
-
 static void iscsit_set_default_tpg_attribs(struct iscsi_portal_group *tpg)
 {
 	struct iscsi_tpg_attrib *a = &tpg->tpg_attrib;
drivers/target/iscsi/iscsi_target_tpg.h +0 -1
index d44d09f2dde9..1155b7b3164a 100644
@@ -18,7 +18,6 @@ extern struct iscsi_portal_group *iscsit_get_tpg_from_np(struct iscsi_tiqn *,
 			struct iscsi_np *, struct iscsi_tpg_np **);
 extern int iscsit_get_tpg(struct iscsi_portal_group *);
 extern void iscsit_put_tpg(struct iscsi_portal_group *);
-extern void iscsit_tpg_dump_params(struct iscsi_portal_group *);
 extern int iscsit_tpg_add_portal_group(struct iscsi_tiqn *, struct iscsi_portal_group *);
 extern int iscsit_tpg_del_portal_group(struct iscsi_tiqn *, struct iscsi_portal_group *,
 			int);
drivers/target/iscsi/iscsi_target_util.c +0 -58

70 lines not on this page · raw message

drivers/target/iscsi/iscsi_target_util.h +0 -2
index 336da4fb0a77..7ae48a8a5cbf 100644
@@ -23,7 +23,6 @@ extern struct iscsi_seq *iscsit_get_seq_holder_for_r2t(struct iscsit_cmd *);
 extern struct iscsi_r2t *iscsit_get_holder_for_r2tsn(struct iscsit_cmd *, u32);
 extern int iscsit_sequence_cmd(struct iscsit_conn *conn, struct iscsit_cmd *cmd,
 			       unsigned char * ,__be32 cmdsn);
-extern int iscsit_check_unsolicited_dataout(struct iscsit_cmd *, unsigned char *);
 extern struct iscsit_cmd *iscsit_find_cmd_from_itt_or_dump(struct iscsit_conn *,
 			itt_t, u32);
 extern struct iscsit_cmd *iscsit_find_cmd_from_ttt(struct iscsit_conn *, u32);
@@ -61,7 +60,6 @@ extern int iscsit_set_login_timer_kworker(struct iscsit_conn *, struct task_stru
 extern int iscsit_send_tx_data(struct iscsit_cmd *, struct iscsit_conn *, int);
 extern int iscsit_fe_sendpage_sg(struct iscsit_cmd *, struct iscsit_conn *);
 extern int iscsit_tx_login_rsp(struct iscsit_conn *, u8, u8);
-extern void iscsit_print_session_params(struct iscsit_session *);
 extern int rx_data(struct iscsit_conn *, struct kvec *, int, int);
 extern int tx_data(struct iscsit_conn *, struct kvec *, int, int);
 extern void iscsit_collect_login_stats(struct iscsit_conn *, u8, u8);
Signature · 1 line
2.47.1
#1 lore raw
Quoted 9 lines

The functions:
iscsit_check_unsolicited_dataout()
iscsit_fail_session()
iscsit_create_conn_recovery_datain_values()
iscsit_create_conn_recovery_dataout_values()
iscsit_tpg_dump_params()
iscsit_print_session_params()

Quoted 5 lines

were all added in 2011 by
commit e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")

but have remained unused.

Applied to 6.14/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to [email protected]
Quoted 9 lines · On Sun, 22 Dec 2024 21:35:24 +0000, [email protected] wrote:

The functions:
iscsit_check_unsolicited_dataout()
iscsit_fail_session()
iscsit_create_conn_recovery_datain_values()
iscsit_create_conn_recovery_dataout_values()
iscsit_tpg_dump_params()
iscsit_print_session_params()

[...]

Applied to 6.14/scsi-queue, thanks!

[1/1] scsi: target: Remove unused functions

      https://git.kernel.org/mkp/scsi/c/4d43d350a4b0
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering