Skip to contentSkip to conversation

mt6779-keypad: fix compatibles and add to mt8516

PATCH Applied Val Packett 4 participants 10 messages Dec 25, 2024 – Jan 7, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover mt6779-keypad: fix compatibles and add to mt8516

The mt8516 patch was previously sent in another series but rejected due to not using an mt8516 specific compatible - which the other usages of this driver (mt8183 and mt8365) weren't doing either.

It's only fair to add the SoC-specific compatibles to all of them then :)

Val Packett (3):
dt-bindings: mediatek,mt6779-keypad: add more compatibles
arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
arm64: dts: mediatek: mt8516: add keypad node

 .../bindings/input/mediatek,mt6779-keypad.yaml        |  3 +++
 arch/arm64/boot/dts/mediatek/mt8183.dtsi              |  3 ++-
 arch/arm64/boot/dts/mediatek/mt8365.dtsi              |  3 ++-
 arch/arm64/boot/dts/mediatek/mt8516.dtsi              | 11 +++++++++++
 4 files changed, 18 insertions(+), 2 deletions(-)
Signature · 1 line
2.47.1
#1 lore raw

PATCH 1/3 dt-bindings: mediatek,mt6779-keypad: add more compatibles

Add compatibles for SoCs using this device (mt8183, mt8365, mt8516).

---
 .../devicetree/bindings/input/mediatek,mt6779-keypad.yaml      | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml +3 -0
index 47aac8794b689..517a4ac1bea3d 100644
@@ -26,6 +26,9 @@ properties:
       - items:
           - enum:
               - mediatek,mt6873-keypad
+              - mediatek,mt8183-keypad
+              - mediatek,mt8365-keypad
+              - mediatek,mt8516-keypad
           - const: mediatek,mt6779-keypad
 
   reg:
Signature · 1 line
2.47.1
Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles

Quoted 1 line · Val Packett

Add compatibles for SoCs using this device (mt8183, mt8365, mt8516).

This we see from the diff. Say what is less visible, e.g. are they fully compatible with other variants? Partially?

---

<form letter>
This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH 1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles

Il 27/12/24 10:12, Krzysztof Kozlowski ha scritto:

Quoted 8 lines · Val Packett
Quoted 1 line

Add compatibles for SoCs using this device (mt8183, mt8365, mt8516).

This we see from the diff. Say what is less visible, e.g. are they fully compatible with other variants? Partially?

Yeah saying that they are fully compatible would be good here, but anyway the change is self-explanatory (just IMO - but I know MTK SoCs so stuff appears obvious to me from time to time, and might not be obvious for others).

Anyway, input maintainers, please let me know if you want to take this (or the next version) through the input tree or if I should take it in the MediaTek tree along with the devicetree changes.

Cheers,
Angelo

Quoted 22 lines

---

<form letter>
This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof

#4 lore raw

PATCH 2/3 arm64: dts: mediatek: add per-SoC compatibles for keypad nodes

In reply to Val Packett

The mt6779-keypad binding specifies using a compatible for the actual SoC before the generic MT6779 one.

Fixes a8013418d35c ("arm64: dts: mediatek: mt8183: add keyboard node")
Fixes 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support")
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 ++-
 arch/arm64/boot/dts/mediatek/mt8365.dtsi | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt8183.dtsi +2 -1
index c7008bb8a81da..0aa34e5bbaaa8 100644
@@ -1024,7 +1024,8 @@ pwrap: pwrap@1000d000 {
 		};
 
 		keyboard: keyboard@10010000 {
-			compatible = "mediatek,mt6779-keypad";
+			compatible = "mediatek,mt8183-keypad",
+				     "mediatek,mt6779-keypad";
 			reg = <0 0x10010000 0 0x1000>;
 			interrupts = <GIC_SPI 186 IRQ_TYPE_EDGE_FALLING>;
 			clocks = <&clk26m>;
arch/arm64/boot/dts/mediatek/mt8365.dtsi +2 -1
index 9c91fe8ea0f96..2bf8c9d02b6ee 100644
@@ -449,7 +449,8 @@ pwrap: pwrap@1000d000 {
 		};
 
 		keypad: keypad@10010000 {
-			compatible = "mediatek,mt6779-keypad";
+			compatible = "mediatek,mt8365-keypad",
+				     "mediatek,mt6779-keypad";
 			reg = <0 0x10010000 0 0x1000>;
 			wakeup-source;
 			interrupts = <GIC_SPI 124 IRQ_TYPE_EDGE_FALLING>;
Signature · 1 line
2.47.1
#5 lore raw

Re: [PATCH 2/3] arm64: dts: mediatek: add per-SoC compatibles for keypad nodes

Quoted 5 lines · Val Packett

The mt6779-keypad binding specifies using a compatible for the actual SoC before the generic MT6779 one.

Fixes a8013418d35c ("arm64: dts: mediatek: mt8183: add keyboard node")
Fixes 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support")

Not really a fix... or describe the bug.

Best regards,
Krzysztof

#6 lore raw

PATCH 3/3 arm64: dts: mediatek: mt8516: add keypad node

In reply to Val Packett

Add a keypad matrix node for the MT8516/MT8167 SoC.

---
 arch/arm64/boot/dts/mediatek/mt8516.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm64/boot/dts/mediatek/mt8516.dtsi +11 -0
index e30623ebac0e1..b5e753759465d 100644
@@ -220,6 +220,17 @@ timer: timer@10008000 {
 			clock-names = "clk13m", "bus";
 		};
 
+		keypad: keypad@10002000 {
+			compatible = "mediatek,mt8516-keypad",
+				     "mediatek,mt6779-keypad";
+			reg = <0 0x10002000 0 0x1000>;
+			wakeup-source;
+			interrupts = <GIC_SPI 149 IRQ_TYPE_EDGE_FALLING>;
+			clocks = <&clk26m>;
+			clock-names = "kpd";
+			status = "disabled";
+		};
+
 		syscfg_pctl: syscfg-pctl@10005000 {
 			compatible = "syscon";
 			reg = <0 0x10005000 0 0x1000>;
Signature · 1 line
2.47.1
maintainer Reviewed-by on the v1 series
#7 lore raw
In reply to Val Packett

Il 25/12/24 20:26, Val Packett ha scritto:

Quoted 6 lines

The mt8516 patch was previously sent in another series but rejected due to not using an mt8516 specific compatible - which the other usages of this driver (mt8183 and mt8365) weren't doing either.

It's only fair to add the SoC-specific compatibles to all of them then :)

Nice!!

Whole series is

Quoted 11 lines

Val Packett (3):
dt-bindings: mediatek,mt6779-keypad: add more compatibles
arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
arm64: dts: mediatek: mt8516: add keypad node

  .../bindings/input/mediatek,mt6779-keypad.yaml        |  3 +++
  arch/arm64/boot/dts/mediatek/mt8183.dtsi              |  3 ++-
  arch/arm64/boot/dts/mediatek/mt8365.dtsi              |  3 ++-
  arch/arm64/boot/dts/mediatek/mt8516.dtsi              | 11 +++++++++++
  4 files changed, 18 insertions(+), 2 deletions(-)
Reviewed-by on the v1 series
#8 lore raw
In reply to Val Packett

Hi Val,

Thank you for the patches.

Quoted 10 lines · Val Packett

The mt8516 patch was previously sent in another series but rejected due to not using an mt8516 specific compatible - which the other usages of this driver (mt8183 and mt8365) weren't doing either.

It's only fair to add the SoC-specific compatibles to all of them then :)

Val Packett (3):
dt-bindings: mediatek,mt6779-keypad: add more compatibles
arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
arm64: dts: mediatek: mt8516: add keypad node

For the series,

Quoted 9 lines
 .../bindings/input/mediatek,mt6779-keypad.yaml        |  3 +++
 arch/arm64/boot/dts/mediatek/mt8183.dtsi              |  3 ++-
 arch/arm64/boot/dts/mediatek/mt8365.dtsi              |  3 ++-
 arch/arm64/boot/dts/mediatek/mt8516.dtsi              | 11 +++++++++++
 4 files changed, 18 insertions(+), 2 deletions(-)
Signature · 1 line
2.47.1
maintainer Applied
#9 lore raw
In reply to Val Packett
Quoted 4 lines · Val Packett

The mt8516 patch was previously sent in another series but rejected due to not using an mt8516 specific compatible - which the other usages of this driver (mt8183 and mt8365) weren't doing either.

Quoted 8 lines

It's only fair to add the SoC-specific compatibles to all of them then :)

Val Packett (3):
dt-bindings: mediatek,mt6779-keypad: add more compatibles
arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
arm64: dts: mediatek: mt8516: add keypad node

[...]

Applied to v6.13-next/dts64, thanks!

[1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles

      commit: 3b19239ad4201123a2bc05af5859f5d75a30a49e
[2/3] arm64: dts: mediatek: add per-SoC compatibles for keypad nodes
      commit: 6139d9e9e397dc9711cf10f8f548a8f9da3b5323
[3/3] arm64: dts: mediatek: mt8516: add keypad node
      commit: 0fb0d360218129f00b76f13e30b86321b64e36f6

Cheers,
Angelo