Skip to contentSkip to conversation

arch/powerpc: Remove unused function icp_native_cause_ipi_rm()

PATCH Applied Gautam Menghani 3 participants 3 messages Jan 1, 2025 – Feb 26, 2025 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/powerpc: Remove unused function icp_native_cause_ipi_rm()

Remove icp_native_cause_ipi_rm() as it has no callers since commit 53af3ba2e819("KVM: PPC: Book3S HV: Allow guest exit path to have MMU on")

---
 arch/powerpc/include/asm/xics.h       |  1 -
 arch/powerpc/sysdev/xics/icp-native.c | 21 ---------------------
 2 files changed, 22 deletions(-)
arch/powerpc/include/asm/xics.h +0 -1
index 89090485bec1..60ef312dab05 100644
@@ -31,7 +31,6 @@
 #ifdef CONFIG_PPC_ICP_NATIVE
 extern int icp_native_init(void);
 extern void icp_native_flush_interrupt(void);
-extern void icp_native_cause_ipi_rm(int cpu);
 #else
 static inline int icp_native_init(void) { return -ENODEV; }
 #endif
arch/powerpc/sysdev/xics/icp-native.c +0 -21
index 700b67476a7d..4e89158a577c 100644
@@ -145,27 +145,6 @@ static void icp_native_cause_ipi(int cpu)
 	icp_native_set_qirr(cpu, IPI_PRIORITY);
 }
 
-#ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE
-void icp_native_cause_ipi_rm(int cpu)
-{
-	/*
-	 * Currently not used to send IPIs to another CPU
-	 * on the same core. Only caller is KVM real mode.
-	 * Need the physical address of the XICS to be
-	 * previously saved in kvm_hstate in the paca.
-	 */
-	void __iomem *xics_phys;
-
-	/*
-	 * Just like the cause_ipi functions, it is required to
-	 * include a full barrier before causing the IPI.
-	 */
-	xics_phys = paca_ptrs[cpu]->kvm_hstate.xics_phys;
-	mb();
-	__raw_rm_writeb(IPI_PRIORITY, xics_phys + XICS_MFRR);
-}
-#endif
-
 /*
  * Called when an interrupt is received on an off-line CPU to
  * clear the interrupt, so that the CPU can go back to nap mode.
Signature · 1 line
2.47.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Gautam Menghani

Remove icp_native_cause_ipi_rm() as it has no callers since commit 53af3ba2e819("KVM: PPC: Book3S HV: Allow guest exit path to have MMU on")

---
 arch/powerpc/include/asm/xics.h       |  1 -
 arch/powerpc/sysdev/xics/icp-native.c | 21 ---------------------
 2 files changed, 22 deletions(-)

Indeed there are no callers left of this function. Great catch!

Looks good to me. Please feel free to add -

-ritesh