Skip to contentSkip to conversation

drm/nouveau/disp: Fix missing backlight control on Macbook 5,1

PATCH RESEND Applied Takashi Iwai 2 participants 2 messages Jan 2, 2025 – Jan 7, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drm/nouveau/disp: Fix missing backlight control on Macbook 5,1

Macbook 5,1 with MCP79 lost its backlight control since the recent change for supporting GFP-RM; it rewrote the whole nv50 backlight control code and each display engine is supposed to have an entry for IOR bl callback, but it didn't cover mcp77.

This patch adds the missing bl entry initialization for mcp77 display engine to recover the backlight control.

Fixes 2274ce7e3681 ("drm/nouveau/disp: add output backlight control methods")

---

The previous submission seemed fallin in a crack:
https://lore.kernel.org/all/[email protected]/
so just resending it.

 drivers/gpu/drm/nouveau/nvkm/engine/disp/mcp77.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nouveau/nvkm/engine/disp/mcp77.c +1 -0
index 841e3b69fcaf..5a0c9b8a79f3 100644
@@ -31,6 +31,7 @@ mcp77_sor = {
 	.state = g94_sor_state,
 	.power = nv50_sor_power,
 	.clock = nv50_sor_clock,
+	.bl = &nv50_sor_bl,
 	.hdmi = &g84_sor_hdmi,
 	.dp = &g94_sor_dp,
 };
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 5 lines · Takashi Iwai

Macbook 5,1 with MCP79 lost its backlight control since the recent change for supporting GFP-RM; it rewrote the whole nv50 backlight control code and each display engine is supposed to have an entry for IOR bl callback, but it didn't cover mcp77.

Quoted 7 lines

This patch adds the missing bl entry initialization for mcp77 display engine to recover the backlight control.

Fixes 2274ce7e3681 ("drm/nouveau/disp: add output backlight control methods")

Applied to drm-misc-fixes, thanks!

Quoted 24 lines

---

The previous submission seemed fallin in a crack:
https://lore.kernel.org/all/[email protected]/
so just resending it.

 drivers/gpu/drm/nouveau/nvkm/engine/disp/mcp77.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nouveau/nvkm/engine/disp/mcp77.c +1 -0
index 841e3b69fcaf..5a0c9b8a79f3 100644
@@ -31,6 +31,7 @@ mcp77_sor = {
 	.state = g94_sor_state,
 	.power = nv50_sor_power,
 	.clock = nv50_sor_clock,
+	.bl = &nv50_sor_bl,
 	.hdmi = &g84_sor_hdmi,
 	.dp = &g94_sor_dp,
 };
Signature · 1 line
2.43.0