cpufreq/amd-pstate: Fix prefcore rankings
Subsystems (2)
PATCH 1/1 cpufreq/amd-pstate: Fix prefcore rankings
From: Mario Limonciello <[email protected]>
commit 50a062a76200 ("cpufreq/amd-pstate: Store the boost numerator as highest perf again") updated the value stored for highest perf to no longer store the highest perf value but instead the boost numerator.
This is a fixed value for systems with preferred cores and not appropriate for use ITMT rankings. Update the value used for ITMT rankings to be the preferred core ranking.
--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/amd-pstate.c +1 -1
@@ -802,7 +802,7 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata)* sched_set_itmt_support(true) has been called and it is valid to * update them at any time after it has been called. */ -sched_set_itmt_core_prio ((int )READ_ONCE (cpudata->highest_perf), cpudata->cpu); +sched_set_itmt_core_prio ((int )READ_ONCE (cpudata->prefcore_ranking), cpudata->cpu);schedule_work (&sched_prefcore_work); }
Signature · 1 line
2.43.0
Quoted 9 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
commit
50a062a76200("cpufreq/amd-pstate: Store the boost numerator as highest perf again") updated the value stored for highest perf to no longer store the highest perf value but instead the boost numerator.This is a fixed value for systems with preferred cores and not appropriate for use ITMT rankings. Update the value used for ITMT rankings to be the preferred core ranking.
Looks good to me,
Thanks,
Dhananjay
Quoted 22 lines
Reported-and-tested-by Sebastian <[email protected]>Fixes 50a062a76200 ("cpufreq/amd-pstate: Store the boost numerator as highest perf again")Signed-off-by Mario Limonciello <[email protected]>--- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/amd-pstate.c +1
-1@@ -802,7 +802,7 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata)* sched_set_itmt_support(true) has been called and it is valid to * update them at any time after it has been called. */ -sched_set_itmt_core_prio ((int )READ_ONCE (cpudata->highest_perf), cpudata->cpu); +sched_set_itmt_core_prio ((int )READ_ONCE (cpudata->prefcore_ranking), cpudata->cpu);schedule_work (&sched_prefcore_work); }