Skip to contentSkip to conversation

package/v4l2loopback: enable CONFIG_MEDIA_CAMERA_SUPPORT kernel option

PATCH In review Thomas Petazzoni via buildroot 3 participants 3 messages Jan 2, 2025 – Jan 8, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/v4l2loopback: enable CONFIG_MEDIA_CAMERA_SUPPORT kernel option

Setting CONFIG_VIDEO_DEV is no sufficient as drivers/media/Kconfig has some very convoluted logic to hide some options behind a CONFIG_MEDIA_SUPPORT_FILTER option, unless CONFIG_EXPERT is enabled. Due to this, several arch defconfigs don't have CONFIG_VIDEO_DEV enabled when doing $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV).

To fix this, we enable one of the possible options that ensures CONFIG_VIDEO_DEV is enabled, and we've more or less arbitrarily chosen CONFIG_MEDIA_CAMERA_SUPPORT.

Fixes:

http://autobuild.buildroot.net/results/2a337d29e7870564027bcd42bd0addd228eb6a24/

We've tried to track down which kernel version introduced this exactly, but it's been introduced a while ago and step by step making it difficult to pin-point which version version exactly introduced this. But the issue has been appearing for quite some time in the autobuilders, so it's clearly not a recent issue.

---
 package/v4l2loopback/v4l2loopback.mk | 1 +
 1 file changed, 1 insertion(+)
package/v4l2loopback/v4l2loopback.mk +1 -0
index abc2929d12..0e1d20c0cc 100644
@@ -24,6 +24,7 @@ define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS
 	$(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT)
 	$(call KCONFIG_ENABLE_OPT,CONFIG_I2C)
 	$(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_CAMERA_SUPPORT)
 endef
 
 $(eval $(kernel-module))
Signature · 6 lines
2.47.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 16 lines · Thomas Petazzoni via buildroot

Setting CONFIG_VIDEO_DEV is no sufficient as drivers/media/Kconfig has some very convoluted logic to hide some options behind a CONFIG_MEDIA_SUPPORT_FILTER option, unless CONFIG_EXPERT is enabled. Due to this, several arch defconfigs don't have CONFIG_VIDEO_DEV enabled when doing $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV).

To fix this, we enable one of the possible options that ensures CONFIG_VIDEO_DEV is enabled, and we've more or less arbitrarily chosen CONFIG_MEDIA_CAMERA_SUPPORT.

Fixes:

http://autobuild.buildroot.net/results/2a337d29e7870564027bcd42bd0addd228eb6a24/

Quoted 7 lines

We've tried to track down which kernel version introduced this exactly, but it's been introduced a while ago and step by step making it difficult to pin-point which version version exactly introduced this. But the issue has been appearing for quite some time in the autobuilders, so it's clearly not a recent issue.

Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 15 lines · Thomas Petazzoni via buildroot

Setting CONFIG_VIDEO_DEV is no sufficient as drivers/media/Kconfig has some very convoluted logic to hide some options behind a CONFIG_MEDIA_SUPPORT_FILTER option, unless CONFIG_EXPERT is enabled. Due to this, several arch defconfigs don't have CONFIG_VIDEO_DEV enabled when doing $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV).

To fix this, we enable one of the possible options that ensures CONFIG_VIDEO_DEV is enabled, and we've more or less arbitrarily chosen CONFIG_MEDIA_CAMERA_SUPPORT.

Fixes:

   http://autobuild.buildroot.net/results/2a337d29e7870564027bcd42bd0addd228eb6a24/
Quoted 7 lines

We've tried to track down which kernel version introduced this exactly, but it's been introduced a while ago and step by step making it difficult to pin-point which version version exactly introduced this. But the issue has been appearing for quite some time in the autobuilders, so it's clearly not a recent issue.

Committed to 2024.02.x and 2024.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot