Remove the deprecated "-runas" command line option
PATCH 1/1 Remove the deprecated "-runas" command line option
It has been marked as deprecated two releases ago, so it should be fine now to remove this command line option.
Signed-off-by Thomas Huth <[email protected]>
--- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 6 ++++++ system/vl.c | 9 --------- qemu-options.hx | 15 +-------------- 4 files changed, 7 insertions(+), 29 deletions(-)
docs/about/deprecated.rst +0 -6
@@ -74,12 +74,6 @@ configurations (e.g. -smp drawers=1,books=1,clusters=1 for x86 PC machine) is marked deprecated since 9.0, users have to ensure that all the topology members described with -smp are supported by the target machine. -``-runas`` (since 9.1) -'''''''''''''''''''''' - -Use ``-run-with user=..`` instead. - - User-mode emulator command line arguments -----------------------------------------
docs/about/removed-features.rst +6 -0
@@ -555,6 +555,12 @@ to produce an odd effect (rotating input but not display output). But this was never intended or documented behaviour, so we have dropped the options along with the machine models they were intended for. +``-runas`` (removed in 10.0) +'''''''''''''''''''''''''''' + +Use ``-run-with user=..`` instead. + + User-mode emulator command line arguments -----------------------------------------
system/vl.c +0 -9
@@ -3611,15 +3611,6 @@ void qemu_init(int argc, char **argv)/* Nothing to be parsed here. Especially, do not error out below. */ break ;#if defined(CONFIG_POSIX ) -case QEMU_OPTION_runas: -warn_report ("-runas is deprecated, use '-run-with user=...' instead" ); -if (!os_set_runas (optarg)) { -error_report ("User \"%s\" doesn't exist" -" (and is not <uid>:<gid>)" , - optarg); -exit (1 ); - } -break ;case QEMU_OPTION_daemonize:os_set_daemonize (true);break ;
qemu-options.hx +1 -14
@@ -4976,19 +4976,6 @@ SRST ``-nodefaults`` option will disable all those default devices. ERST -#ifndef _WIN32 -DEF("runas", HAS_ARG, QEMU_OPTION_runas, \ - "-runas user change to user id user just before starting the VM\n" \ - " user can be numeric uid:gid instead\n", - QEMU_ARCH_ALL) -#endif -SRST -``-runas user`` - Immediately before starting guest execution, drop root privileges, - switching to the specified user. This option is deprecated, use - ``-run-with user=...`` instead. -ERST - DEF("prom-env", HAS_ARG, QEMU_OPTION_prom_env, "-prom-env variable=value\n" " set OpenBIOS nvram variables\n",
@@ -5176,7 +5163,7 @@ SRST ``chroot=dir`` can be used for doing a chroot to the specified directory immediately before starting the guest execution. This is especially useful - in combination with -runas. + in combination with ``user=...``. ``user=username`` or ``user=uid:gid`` can be used to drop root privileges before starting guest execution. QEMU will use the ``setuid`` and ``setgid``
Signature · 1 line
2.47.1
Quoted 10 lines · Thomas Huth
It has been marked as deprecated two releases ago, so it should be fine now to remove this command line option.
Signed-off-by Thomas Huth <[email protected]>--- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 6 ++++++ system/vl.c | 9 --------- qemu-options.hx | 15 +-------------- 4 files changed, 7 insertions(+), 29 deletions(-)
Reviewed-by Daniel P. Berrangé <[email protected]>
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|