Skip to contentSkip to conversation

bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"

PATCH Applied Ted Chen 3 participants 3 messages Jan 4, 2025 – Jan 7, 2025

Subsystems (3)
lore
Share & tools
lore

Ted Chen

author
#0 lore raw

PATCH v2 1/1 bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"

The skb_buff struct in br_is_nd_neigh_msg() is never modified. Mark it as const.

---
v2:
- Rebased to net-next (Nicolay)
- Wrapped commit message lines to be within 75 characters. (Nicolay)
- Added net-next to patch subject. (Nicolay)

v1:
https://lore.kernel.org/all/[email protected]

---
 net/bridge/br_arp_nd_proxy.c | 2 +-
 net/bridge/br_private.h      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
net/bridge/br_arp_nd_proxy.c +1 -1
index c7869a286df4..115a23054a58 100644
@@ -229,7 +229,7 @@ void br_do_proxy_suppress_arp(struct sk_buff *skb, struct net_bridge *br,
 #endif
 
 #if IS_ENABLED(CONFIG_IPV6)
-struct nd_msg *br_is_nd_neigh_msg(struct sk_buff *skb, struct nd_msg *msg)
+struct nd_msg *br_is_nd_neigh_msg(const struct sk_buff *skb, struct nd_msg *msg)
 {
 	struct nd_msg *m;
 
net/bridge/br_private.h +1 -1
index 29d6ec45cf41..1054b8a88edc 100644
@@ -2299,6 +2299,6 @@ void br_do_proxy_suppress_arp(struct sk_buff *skb, struct net_bridge *br,
 			      u16 vid, struct net_bridge_port *p);
 void br_do_suppress_nd(struct sk_buff *skb, struct net_bridge *br,
 		       u16 vid, struct net_bridge_port *p, struct nd_msg *msg);
-struct nd_msg *br_is_nd_neigh_msg(struct sk_buff *skb, struct nd_msg *m);
+struct nd_msg *br_is_nd_neigh_msg(const struct sk_buff *skb, struct nd_msg *m);
 bool br_is_neigh_suppress_enabled(const struct net_bridge_port *p, u16 vid);
 #endif
Signature · 1 line
2.39.2
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines · Ted Chen

The skb_buff struct in br_is_nd_neigh_msg() is never modified. Mark it as const.

---
v2:
- Rebased to net-next (Nicolay)
- Wrapped commit message lines to be within 75 characters. (Nicolay)
- Added net-next to patch subject. (Nicolay)

Quoted 3 lines

v1:
https://lore.kernel.org/all/[email protected]
---

#2 lore raw
In reply to Ted Chen
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 11 lines · On Sat, 4 Jan 2025 16:38:46 +0800 you wrote:

The skb_buff struct in br_is_nd_neigh_msg() is never modified. Mark it as const.

---
v2:
- Rebased to net-next (Nicolay)
- Wrapped commit message lines to be within 75 characters. (Nicolay)
- Added net-next to patch subject. (Nicolay)

[...]

Here is the summary with links:
- [net-next,v2] bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff"

    https://git.kernel.org/netdev/net-next/c/a1942da8a387

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html