usb: typec: tcpm: set SRC_SEND_CAPABILITIES timeout to PD_T_SENDER_RESPONSE
Subsystems (4)
PATCH 1/1 usb: typec: tcpm: set SRC_SEND_CAPABILITIES timeout to PD_T_SENDER_RESPONSE
From: Jos Wang <[email protected]>
As PD2.0 spec ("8.3.3.2.3 PE_SRC_Send_Capabilities state"), after the Source receives the GoodCRC Message from the Sink in response to the Source_Capabilities message, it should start the SenderResponseTimer, after the timer times out, the state machine transitions to the HARD_RESET state.
--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/typec/tcpm/tcpm.c +1 -1
@@ -4821,7 +4821,7 @@ static void run_state_machine(struct tcpm_port *port) port->caps_count =0 ; port->pd_capable = true;tcpm_set_state_cond (port,SRC_SEND_CAPABILITIES_TIMEOUT , -PD_T_SEND_SOURCE_CAP ); +PD_T_SENDER_RESPONSE ); }break ;case SRC_SEND_CAPABILITIES_TIMEOUT :
Signature · 1 line
2.17.1
Heikki Krogerus
maintainer+Badhri
Quoted 20 lines · joswang
From: Jos Wang <[email protected]>
As PD2.0 spec ("8.3.3.2.3
PE_SRC_Send_Capabilitiesstate"), after the Source receives the GoodCRC Message from the Sink in response to theSource_Capabilitiesmessage, it should start the SenderResponseTimer, after the timer times out, the state machine transitions to theHARD_RESETstate.Fixes f0690a25a140 ("staging: typec: USB Type-C Port Manager (tcpm)")Signed-off-by Jos Wang <[email protected]>--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/tcpm.c +0
-0
drivers/usb/typec/tcpm/tcpm.c static void run_state_machine(struct tcpm_port *port) · line 4827
Quoted 8 lines
drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -4821,7 +4821,7 @@ static void run_state_machine(struct tcpm_port *port) port->caps_count =0 ; port->pd_capable = true;tcpm_set_state_cond (port,SRC_SEND_CAPABILITIES_TIMEOUT , -PD_T_SEND_SOURCE_CAP ); +PD_T_SENDER_RESPONSE ); }break ;case SRC_SEND_CAPABILITIES_TIMEOUT :
This looks okay to me, but let's get comments from Badhri, just in case.
thanks,
Signature · 1 line
heikki
Quoted 15 lines · Heikki Krogerus
+Badhri
Quoted 11 lines · joswang
From: Jos Wang <[email protected]>
As PD2.0 spec ("8.3.3.2.3
PE_SRC_Send_Capabilitiesstate"), after the Source receives the GoodCRC Message from the Sink in response to theSource_Capabilitiesmessage, it should start the SenderResponseTimer, after the timer times out, the state machine transitions to theHARD_RESETstate.Fixes f0690a25a140 ("staging: typec: USB Type-C Port Manager (tcpm)")Signed-off-by Jos Wang <[email protected]>
Quoted 4 lines
Quoted 4 lines
--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines
drivers/usb/typec/tcpm/tcpm.c static void run_state_machine(struct tcpm_port *port) · line 4824
Quoted 10 lines
drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -4821,7 +4821,7 @@ static void run_state_machine(struct tcpm_port *port) port->caps_count =0 ; port->pd_capable = true;tcpm_set_state_cond (port,SRC_SEND_CAPABILITIES_TIMEOUT , -PD_T_SEND_SOURCE_CAP ); +PD_T_SENDER_RESPONSE );
This aligns with what the spec says as Jos Wang has already mentioned. However, itdoes reduce the time within which the sink has to reply back with the request message. So if there are non-compliant sinks, which we don't know of yet, we would know now and we can later see how we can handle the interoperability.
Regards,
Badhri
Quoted 11 lines
drivers/usb/typec/tcpm/tcpm.c static void run_state_machine(struct tcpm_port *port) · line 4827
Quoted 3 lines
drivers/usb/typec/tcpm/tcpm.c +0
-0}break ;case SRC_SEND_CAPABILITIES_TIMEOUT :This looks okay to me, but let's get comments from Badhri, just in case.
thanks,
--
heikki
Quoted 11 lines · joswang
From: Jos Wang <[email protected]>
As PD2.0 spec ("8.3.3.2.3
PE_SRC_Send_Capabilitiesstate"), after the Source receives the GoodCRC Message from the Sink in response to theSource_Capabilitiesmessage, it should start the SenderResponseTimer, after the timer times out, the state machine transitions to theHARD_RESETstate.Fixes f0690a25a140 ("staging: typec: USB Type-C Port Manager (tcpm)")Signed-off-by Jos Wang <[email protected]>
Quoted 19 lines
--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -4821,7 +4821,7 @@ static void run_state_machine(struct tcpm_port *port) port->caps_count =0 ; port->pd_capable = true;tcpm_set_state_cond (port,SRC_SEND_CAPABILITIES_TIMEOUT , -PD_T_SEND_SOURCE_CAP ); +PD_T_SENDER_RESPONSE ); }break ;case SRC_SEND_CAPABILITIES_TIMEOUT :Signature · 1 line
2.17.1
Signature · 1 line
heikki