drm/amdgpu: fill the ucode bo during psp resume for SRIOV
Subsystems (2)
PATCH 1/1 drm/amdgpu: fill the ucode bo during psp resume for SRIOV
refill the ucode bo during psp resume for SRIOV, otherwise ucode load will fail after VM hibernation and fb clean.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +4 -0
@@ -3148,6 +3148,10 @@ static int psp_resume(struct amdgpu_ip_block *ip_block)mutex_lock (&adev->firmware.mutex); + ret =amdgpu_ucode_init_bo (adev); +if (ret) + goto failed; + ret =psp_hw_start (psp);if (ret) goto failed;
Signature · 1 line
2.34.1
[AMD Official Use Only - AMD Internal Distribution Only]
Ping..
-----Original Message-----
From: Victor Zhao <[email protected]>
Sent: Monday, January 6, 2025 6:52 PM
To: [email protected]
Cc: Zhao, Victor <[email protected]>
Subject: [PATCH] drm/amdgpu: fill the ucode bo during psp resume for SRIOV
refill the ucode bo during psp resume for SRIOV, otherwise ucode load will fail after VM hibernation and fb clean.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +4 -0
@@ -3148,6 +3148,10 @@ static int psp_resume(struct amdgpu_ip_block *ip_block)mutex_lock (&adev->firmware.mutex); + ret =amdgpu_ucode_init_bo (adev); +if (ret) + goto failed; + ret =psp_hw_start (psp);if (ret) goto failed;
--
2.34.1
Quoted 3 lines · Victor Zhao
refill the ucode bo during psp resume for SRIOV, otherwise ucode load will fail after VM hibernation and fb clean.
Please drop the comment above amdgpu_ucode_init_bo() in psp_hw_init() since it is no longer true. WIth that fixed, the patch is:
Quoted 24 lines
Signed-off-by Victor Zhao <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +4
-1@@ -3148,6 +3148,10 @@ static int psp_resume(struct amdgpu_ip_block *ip_block)mutex_lock (&adev->firmware.mutex); + ret =amdgpu_ucode_init_bo (adev); +if (ret) + goto failed; + ret =psp_hw_start (psp);if (ret) goto failed; --2.34.1