sched_ext: update scx_bpf_dsq_insert() doc for SCX_DSQ_LOCAL_ON
Subsystems (2)
PATCH 1/1 sched_ext: update scx_bpf_dsq_insert() doc for SCX_DSQ_LOCAL_ON
With commit 5b26f7b920f7 ("sched_ext: Allow SCX_DSQ_LOCAL_ON for direct dispatches"), scx_bpf_dsq_insert() can use SCX_DSQ_LOCAL_ON for direct dispatch from ops.enqueue() to target the local DSQ of any CPU.
Update the documentation accordingly.
Fixes 5b26f7b920f7 ("sched_ext: Allow SCX_DSQ_LOCAL_ON for direct dispatches")
Signed-off-by Andrea Righi <[email protected]>
--- Documentation/scheduler/sched-ext.rst | 6 +++--- kernel/sched/ext.c | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-)
Documentation/scheduler/sched-ext.rst +3 -3
@@ -242,9 +242,9 @@ The following briefly shows how a waking task is scheduled and executed. task was inserted directly from ``ops.select_cpu()``). ``ops.enqueue()`` can make one of the following decisions: - * Immediately insert the task into either the global or local DSQ by - calling ``scx_bpf_dsq_insert()`` with ``SCX_DSQ_GLOBAL`` or - ``SCX_DSQ_LOCAL``, respectively. + * Immediately insert the task into either the global or a local DSQ by + calling ``scx_bpf_dsq_insert()`` with one of the following options: + ``SCX_DSQ_GLOBAL``, ``SCX_DSQ_LOCAL``, or ``SCX_DSQ_LOCAL_ON | cpu``. * Immediately insert the task into a custom DSQ by calling ``scx_bpf_dsq_insert()`` with a DSQ ID which is smaller than 2^63.
kernel/sched/ext.c +1 -3
@@ -6406,9 +6406,7 @@ __bpf_kfunc_start_defs();* ops.select_cpu(), and ops.dispatch(). * * When called from ops.select_cpu() or ops.enqueue(), it's for direct dispatch -* and @p must match the task being enqueued. Also, %SCX_DSQ_LOCAL_ON can't be -* used to target the local DSQ of a CPU other than the enqueueing one. Use -* ops.select_cpu() to be on the target CPU in the first place. +* and @p must match the task being enqueued. * * When called from ops.select_cpu(), @enq_flags and @dsp_id are stored, and @p * will be directly inserted into the corresponding dispatch queue after
Signature · 1 line
2.47.1
Tejun Heo
AppliedQuoted 8 lines · Andrea Righi
With commit
5b26f7b920f7("sched_ext: AllowSCX_DSQ_LOCAL_ONfor direct dispatches"),scx_bpf_dsq_insert()can useSCX_DSQ_LOCAL_ONfor direct dispatch fromops.enqueue()to target the local DSQ of any CPU.Update the documentation accordingly.
Fixes 5b26f7b920f7 ("sched_ext: Allow SCX_DSQ_LOCAL_ON for direct dispatches")Signed-off-by Andrea Righi <[email protected]>
Applied to sched_ext/for-6.14.
Thanks.
Signature · 1 line
tejun