drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
kernel test robot
build bottree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT date: 2 years, 8 months ago config: csky-randconfig-r022-20230522 (https://download.01.org/0day-ci/archive/20250103/[email protected]/config) compiler: csky-linux-gcc (GCC) 12.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
drivers/android/binder.c:233: warning: Function parameter or struct member '_proc' not described in 'binder_proc_unlock' drivers/android/binder.c:233: warning: Excess function parameter 'proc' description in 'binder_proc_unlock' drivers/android/binder.c:335: warning: expecting prototype for binder_node_unlock(). Prototype was for binder_node_inner_unlock() instead drivers/android/binder.c:1155: warning: expecting prototype for binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
>> drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb' >> drivers/android/binder.c:1819: warning: Excess struct member 'fd' description in 'binder_task_work_cb' >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup' >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup' >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup' >> drivers/android/binder.c:2254: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup' >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy' >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy' >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy' >> drivers/android/binder.c:2274: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy' drivers/android/binder.c:2683: warning: Function parameter or struct member 'procp' not described in 'binder_get_node_refs_for_txn' drivers/android/binder.c:2683: warning: Excess function parameter 'proc' description in 'binder_get_node_refs_for_txn' >> drivers/android/binder.c:3510: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'
vim +1819 drivers/android/binder.c
7980240b6d63e0 Martijn Coenen 2017-02-03 1806
80cd795630d652 Todd Kjos 2018-12-14 1807 /**
80cd795630d652 Todd Kjos 2018-12-14 1808 * struct binder_task_work_cb - for deferred close
80cd795630d652 Todd Kjos 2018-12-14 1809 *
80cd795630d652 Todd Kjos 2018-12-14 1810 * @twork: callback_head for task work
80cd795630d652 Todd Kjos 2018-12-14 1811 * @fd: fd to close
80cd795630d652 Todd Kjos 2018-12-14 1812 *
80cd795630d652 Todd Kjos 2018-12-14 1813 * Structure to pass task work to be handled after
80cd795630d652 Todd Kjos 2018-12-14 1814 * returning from binder_ioctl() via task_work_add().
80cd795630d652 Todd Kjos 2018-12-14 1815 */
80cd795630d652 Todd Kjos 2018-12-14 1816 struct binder_task_work_cb {
80cd795630d652 Todd Kjos 2018-12-14 1817 struct callback_head twork;
80cd795630d652 Todd Kjos 2018-12-14 1818 struct file *file;80cd795630d652 Todd Kjos 2018-12-14 @1819 };80cd795630d652 Todd Kjos 2018-12-14 1820
:::::: The code at line 1819 was first introduced by commit
:::::: 80cd795630d6526ba729a089a435bf74a57af927 binder: fix use-after-free due to ksys_close() during fdget()
:::::: TO: Todd Kjos <[email protected]>
:::::: CC: Greg Kroah-Hartman <[email protected]>
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Quoted 49 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT date: 2 years, 8 months ago config: csky-randconfig-r022-20230522 (https://download.01.org/0day-ci/archive/20250103/[email protected]/config) compiler: csky-linux-gcc (GCC) 12.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All warnings (new ones prefixed by >>):
drivers/android/binder.c:233: warning: Function parameter or struct member '_proc' not described in 'binder_proc_unlock'drivers/android/binder.c:233: warning: Excess function parameter 'proc' description in 'binder_proc_unlock'drivers/android/binder.c:335: warning: expecting prototype forbinder_node_unlock(). Prototype was forbinder_node_inner_unlock()insteaddrivers/android/binder.c:1155: warning: expecting prototype forbinder_dec_ref(). Prototype was forbinder_dec_ref_olocked()insteadQuoted 10 lines
Quoted 10 lines
drivers/android/binder.c:1819: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'drivers/android/binder.c:1819: warning: Excess struct member 'fd' description in 'binder_task_work_cb'drivers/android/binder.c:2254: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup'drivers/android/binder.c:2254: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup'drivers/android/binder.c:2254: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup'drivers/android/binder.c:2254: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup'drivers/android/binder.c:2274: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy'drivers/android/binder.c:2274: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy'drivers/android/binder.c:2274: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy'drivers/android/binder.c:2274: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy'
drivers/android/binder.c:2683: warning: Function parameter or struct member 'procp' not described in 'binder_get_node_refs_for_txn'drivers/android/binder.c:2683: warning: Excess function parameter 'proc' description in 'binder_get_node_refs_for_txn'Quoted 1 line
Quoted 1 line
drivers/android/binder.c:3510: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'vim +1819
drivers/android/binder.c7980240b6d63e0 Martijn Coenen 2017-02-03 1806 80cd795630d652 Todd Kjos 2018-12-14 1807 /** 80cd795630d652 Todd Kjos 2018-12-14 1808 * struct binder_task_work_cb - for deferred close 80cd795630d652 Todd Kjos 2018-12-14 1809 * 80cd795630d652 Todd Kjos 2018-12-14 1810 * @twork: callback_head for task work 80cd795630d652 Todd Kjos 2018-12-14 1811 * @fd: fd to close 80cd795630d652 Todd Kjos 2018-12-14 1812 * 80cd795630d652 Todd Kjos 2018-12-14 1813 * Structure to pass task work to be handled after 80cd795630d652 Todd Kjos 2018-12-14 1814 * returning from binder_ioctl() via task_work_add(). 80cd795630d652 Todd Kjos 2018-12-14 1815 */ 80cd795630d652 Todd Kjos 2018-12-14 1816 struct binder_task_work_cb { 80cd795630d652 Todd Kjos 2018-12-14 1817 struct callback_head twork; 80cd795630d652 Todd Kjos 2018-12-14 1818 struct file *file;
Quoted 6 lines
80cd795630d652Todd Kjos 2018-12-14 @1819 };80cd795630d652Todd Kjos 2018-12-14 1820:::::: The code at line 1819 was first introduced by commit
::::::80cd795630d6526ba729a089a435bf74a57af927binder: fix use-after-free due toksys_close()duringfdget()
Above warnings have nothing to do with the:
commit: 28b3ae426598e722cf5d5ab9cc7038791b955a56 rcu: Introduce CONFIG_RCU_EXP_CPU_STALL_TIMEOUT
Add "Todd Kjos <[email protected]>", owner of the patch, to sort those warnings out.
--
Uladzislau Rezki
Carlos Llamas
maintainerPATCH 1/1 binder: fix kernel-doc warning of 'file' member
In reply to kernel test robotThe 'struct file' member in 'binder_task_work_cb' definition was renamed to 'file' between patch versions but its kernel-doc reference kept the old name 'fd'. Update the naming to fix the W=1 build warning.
--- drivers/android/binder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder.c +1 -1
@@ -1971,7 +1971,7 @@ static bool binder_validate_fixup(struct binder_proc *proc,* struct binder_task_work_cb - for deferred close * * @twork: callback_head for task work -* @fd: fd to close +* @file: file to close * * Structure to pass task work to be handled after * returning from binder_ioctl() via task_work_add().
Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog
Re: [PATCH] binder: fix kernel-doc warning of 'file' member
Quoted 10 lines · Carlos Llamas
The 'struct file' member in '
binder_task_work_cb' definition was renamed to 'file' between patch versions but its kernel-doc reference kept the old name 'fd'. Update the naming to fix the W=1 build warning.Cc Todd Kjos <[email protected]>Fixes 80cd795630d6 ("binder: fix use-after-free due to ksys_close() during fdget()")Reported-by kernel test robot <[email protected]>Signed-off-by Carlos Llamas <[email protected]>
Quoted 20 lines
--- drivers/android/binder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/android/binder.c +1
-2@@ -1971,7 +1971,7 @@ static bool binder_validate_fixup(struct binder_proc *proc,* struct binder_task_work_cb - for deferred close * * @twork: callback_head for task work -* @fd: fd to close +* @file: file to close * * Structure to pass task work to be handled after * returning from binder_ioctl() via task_work_add(). -- 2.47.1.613.gc27f4b7a9f-goog