Skip to contentSkip to conversation

package/qt6/qt6quicktimeline: add missing select BR2_PACKAGE_QT6DECLARATIVE

PATCH In review Thomas Petazzoni via buildroot 3 participants 4 messages Jan 6, 2025 – Jan 7, 2025 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qt6/qt6quicktimeline: add missing select BR2_PACKAGE_QT6DECLARATIVE

qt6quicktimeline has qt6declative in its dependencies, but does not select BR2_PACKAGE_QT6DECLARATIVE. It does select BR2_PACKAGE_QT6DECLARATIVE_QUICK, but this option "depends on" BR2_PACKAGE_QT6DECLARATIVE, and does not select it.

Fixes:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT6DECLARATIVE_QUICK
Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE [=n] Selected by [y]:
- BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]

reported by kconfig.

---
 package/qt6/qt6quicktimeline/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/qt6/qt6quicktimeline/Config.in +1 -0
index 4dcf0e1452..466aab23c8 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT6QUICKTIMELINE
 	bool "qt6quicktimeline"
+	select BR2_PACKAGE_QT6DECLARATIVE
 	select BR2_PACKAGE_QT6DECLARATIVE_QUICK
 	help
 	  This package corresponds to the Qt Quick Timeline module:
Signature · 6 lines
2.47.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

A message that is not in the archive (sent off-list or not yet received): CA+R_deqLs+aSCBvoTGj9rJn8D5ARu1=QFKDy19qgTP_YWBdU0g@mail.gmail.com

#2 lore raw

Hello Roy,

Quoted 1 line · On Mon, 6 Jan 2025 23:07:46 +0100 Roy Kollen Svendsen…

How can I recreate the warning reported by kconfig?

Like this:

$ cat > .config <<EOF
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_PACKAGE_QT6=y
BR2_PACKAGE_QT6QUICKTIMELINE=y
EOF
$ make olddefconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT6DECLARATIVE_QUICK
  Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE [=n]
  Selected by [y]:
  - BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]
#
# configuration written to /home/thomas/projets/buildroot/.config
#

Basically, just enable qt6 and qt6quicktimeline. You can even do it from menuconfig, and then when you exit menuconfig, you will see the kconfig warning.

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Thanks. Now I got the warning, and it disappeared after applying your patch.

man. 6. jan. 2025 kl. 23:19 skrev Thomas Petazzoni < [email protected]>:

Quoted 32 lines

Hello Roy,

Quoted 1 line · On Mon, 6 Jan 2025 23:07:46 +0100 Roy Kollen Svendsen…

How can I recreate the warning reported by kconfig?

Like this:

$ cat > .config <<EOF
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_PACKAGE_QT6=y
BR2_PACKAGE_QT6QUICKTIMELINE=y
EOF
$ make olddefconfig
WARNING: unmet direct dependencies detected for
BR2_PACKAGE_QT6DECLARATIVE_QUICK
  Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE [=n]
  Selected by [y]:
  - BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]
#
# configuration written to /home/thomas/projets/buildroot/.config
#

Basically, just enable qt6 and qt6quicktimeline. You can even do it from menuconfig, and then when you exit menuconfig, you will see the kconfig warning.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 13 lines · Thomas Petazzoni via buildroot

qt6quicktimeline has qt6declative in its dependencies, but does not select BR2_PACKAGE_QT6DECLARATIVE. It does select BR2_PACKAGE_QT6DECLARATIVE_QUICK, but this option "depends on" BR2_PACKAGE_QT6DECLARATIVE, and does not select it.

Fixes:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT6DECLARATIVE_QUICK
Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE
[=n]
Selected by [y]:
- BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]

Quoted 3 lines

reported by kconfig.

Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot