erofs: shorten bvecs[] for file-backed mounts
PATCH 1/1 erofs: shorten bvecs[] for file-backed mounts
BIO_MAX_VECS is too large for __GFP_NOFAIL allocation. We could use a mempool (since BIO can always proceed), but it seems overly complicated for now.
Signed-off-by Gao Xiang <[email protected]>
--- fs/erofs/fileio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/erofs/fileio.c +2 -2
@@ -6,7 +6,7 @@#include <trace/events/erofs.h> struct erofs_fileio_rq { -struct bio_vec bvecs[BIO_MAX_VECS ]; +struct bio_vec bvecs[16 ];struct bio bio;struct kiocb iocb;struct super_block *sb;
@@ -68,7 +68,7 @@ static struct erofs_fileio_rq *erofs_fileio_rq_alloc(struct erofs_map_dev *mdev)struct erofs_fileio_rq *rq =kzalloc (sizeof (*rq),GFP_KERNEL | __GFP_NOFAIL); -bio_init (&rq->bio,NULL , rq->bvecs,BIO_MAX_VECS ,REQ_OP_READ ); +bio_init (&rq->bio,NULL , rq->bvecs,ARRAY_SIZE (rq->bvecs),REQ_OP_READ ); rq->iocb.ki_filp = mdev->m_dif->file; rq->sb = mdev->m_sb;return rq;
Signature · 1 line
2.43.5
Quoted 5 lines · Gao Xiang
BIO_MAX_VECSis too large for__GFP_NOFAILallocation. We could use a mempool (since BIO can always proceed), but it seems overly complicated for now.Signed-off-by Gao Xiang <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,