ASoC: wm8994: Add depends on MFD core
PATCH 1/1 ASoC: wm8994: Add depends on MFD core
The ASoC driver should not be used without the MFD component. This was causing randconfig issues with regmap IRQ which is selected by the MFD part of the wm8994 driver.
---
Slightly of two minds if this needs fixed since the WM8994 symbol is not user selectable, so is only normally included by selection from the machine driver, which should a) select MFD_WM8994 as well and b) the select would ignore the depends anyway. But I guessed it was best to squash the randconfig issue even if that is likely the only thing that will ever hit the issue.
Thanks,
Charles
sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+)
sound/soc/codecs/Kconfig +1 -0
@@ -2451,6 +2451,7 @@ config SND_SOC_WM8993 config SND_SOC_WM8994 tristate + depends on MFD_WM8994 config SND_SOC_WM8995 tristate
Signature · 1 line
2.39.5
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Charles,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.13-rc6 next-20250106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Charles-Keepax/ASoC-wm8994-Add-depends-on-MFD-core/20250106-235153 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20250106154639.3999553-1-ckeepax%40opensource.cirrus.com patch subject: [PATCH] ASoC: wm8994: Add depends on MFD core config: alpha-kismet-CONFIG_SND_SOC_WM8994-CONFIG_SND_SOC_SAMSUNG_MIDAS_WM1811-0-0 (https://download.01.org/0day-ci/archive/20250107/[email protected]/config) reproduce: (https://download.01.org/0day-ci/archive/20250107/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
kismet warnings: (new ones prefixed by >>)
>> kismet: WARNING: unmet direct dependencies detected for SND_SOC_WM8994 when selected by SND_SOC_SAMSUNG_MIDAS_WM1811
WARNING: unmet direct dependencies detected for SND_SOC_WM8994
Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && MFD_WM8994 [=n]
Selected by [y]:
- SND_SOC_SAMSUNG_MIDAS_WM1811 [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_SOC_SAMSUNG [=y] && IIO [=y]
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Quoted 22 lines · kernel test robot
Hi Charles,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.13-rc6 next-20250106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Charles-Keepax/ASoC-wm8994-Add-depends-on-MFD-core/20250106-235153 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20250106154639.3999553-1-ckeepax%40opensource.cirrus.com patch subject: [PATCH] ASoC: wm8994: Add depends on MFD core config: alpha-kismet-CONFIG_SND_SOC_WM8994-CONFIG_SND_SOC_SAMSUNG_MIDAS_WM1811-0-0 (https://download.01.org/0day-ci/archive/20250107/[email protected]/config) reproduce: (https://download.01.org/0day-ci/archive/20250107/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Quoted 7 lines
kismet warnings: (new ones prefixed by >>)
Quoted 1 line
Quoted 1 line
kismet: WARNING: unmet direct dependencies detected for
SND_SOC_WM8994when selected bySND_SOC_SAMSUNG_MIDAS_WM1811WARNING: unmet direct dependencies detected for
SND_SOC_WM8994
Depends on [n]: SOUND [=y] && SND [=y] &&SND_SOC[=y] &&MFD_WM8994[=n]
Selected by [y]:
-SND_SOC_SAMSUNG_MIDAS_WM1811[=y] && SOUND [=y] && SND [=y] &&SND_SOC[=y] &&SND_SOC_SAMSUNG[=y] && IIO [=y]
Well I guess this is maybe an argument in favour of adding the depends since unlike that issue these are actual things one might hit in practice. Both Aries and Midas appear to be missing selects for the MFD part of 8994, fine as long as it gets manually selected but will blow up if it doesn't. Will send a patch for this, but it needed not block this patch, its a separate issue.
Thanks,
Charles
Mark Brown
maintainerQuoted 5 lines · Charles Keepax
The ASoC driver should not be used without the MFD component. This was causing randconfig issues with regmap IRQ which is selected by the MFD part of the wm8994 driver.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: wm8994: Add depends on MFD core
commit: 5ed01155cea69801f1f0c908954a56a5a3474bed
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark