usb: ehci-mx5: Use regulator_set_enable_if_allowed
Subsystems (2)
PATCH 1/2 usb: ehci-mx5: Use regulator_set_enable_if_allowed
With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators.
Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulator already was enabled or disabled.
Based on 335799b7252a ("usb: dwc2: Use regulator_set_enable_if_allowed")
---
Cc: Alice Guo <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Mathieu Othacehe <[email protected]>
Cc: Mattijs Korpershoek <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]
--- drivers/usb/host/ehci-mx5.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/host/ehci-mx5.c +3 -3
@@ -287,9 +287,9 @@ static int ehci_usb_probe(struct udevice *dev)debug ("%s: No vbus supply\n" , dev->name);if (!ret && priv->vbus_supply) { - ret =regulator_set_enable (priv->vbus_supply, - (type ==USB_INIT_DEVICE ) ? - false : true); + ret =regulator_set_enable_if_allowed (priv->vbus_supply, + (type ==USB_INIT_DEVICE ) ? + false : true);if (ret) {puts ("Error enabling VBUS supply\n" );return ret;
Signature · 1 line
2.45.2
PATCH 2/2 usb: ehci-mx6: Use regulator_set_enable_if_allowed
With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators.
Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulator already was enabled or disabled.
Based on 335799b7252a ("usb: dwc2: Use regulator_set_enable_if_allowed")
---
Cc: Alice Guo <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Mathieu Othacehe <[email protected]>
Cc: Mattijs Korpershoek <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]
--- drivers/usb/host/ehci-mx6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/host/ehci-mx6.c +3 -3
@@ -479,9 +479,9 @@ static int mx6_init_after_reset(struct ehci_ctrl *dev)#if CONFIG_IS_ENABLED (DM_REGULATOR )if (priv->vbus_supply) {int ret; - ret =regulator_set_enable (priv->vbus_supply, - (type ==USB_INIT_DEVICE ) ? - false : true); + ret =regulator_set_enable_if_allowed (priv->vbus_supply, + (type ==USB_INIT_DEVICE ) ? + false : true);if (ret && ret != -ENOSYS ) {printf ("Error enabling VBUS supply (ret=%i)\n" , ret);return ret;
Signature · 1 line
2.45.2
Re: [PATCH 2/2] usb: ehci-mx6: Use regulator_set_enable_if_allowed
Quoted 11 lines · Marek Vasut
With the commit
4fcba5d556b4("regulator: implement basic reference counter") the return value ofregulator_set_enablemay be EALREADY or EBUSY for fixed/gpio regulators.Change to use the more relaxed
regulator_set_enable_if_allowedto continue if regulator already was enabled or disabled.Based on
335799b7252a("usb: dwc2: Useregulator_set_enable_if_allowed")Signed-off-by Marek Vasut <[email protected]>
Re: [PATCH 2/2] usb: ehci-mx6: Use regulator_set_enable_if_allowed
In reply to Marek VasutHi Marek,
Thank you for the patch.
Quoted 10 lines · Marek Vasut
With the commit
4fcba5d556b4("regulator: implement basic reference counter") the return value ofregulator_set_enablemay be EALREADY or EBUSY for fixed/gpio regulators.Change to use the more relaxed
regulator_set_enable_if_allowedto continue if regulator already was enabled or disabled.Based on
335799b7252a("usb: dwc2: Useregulator_set_enable_if_allowed")Signed-off-by Marek Vasut <[email protected]>
Quoted 31 lines
---
Cc: Alice Guo <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Mathieu Othacehe <[email protected]>
Cc: Mattijs Korpershoek <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]--- drivers/usb/host/ehci-mx6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/usb/host/ehci-mx6.c +3
-3@@ -479,9 +479,9 @@ static int mx6_init_after_reset(struct ehci_ctrl *dev)#if CONFIG_IS_ENABLED (DM_REGULATOR )if (priv->vbus_supply) {int ret; - ret =regulator_set_enable (priv->vbus_supply, - (type ==USB_INIT_DEVICE ) ? - false : true); + ret =regulator_set_enable_if_allowed (priv->vbus_supply, + (type ==USB_INIT_DEVICE ) ? + false : true);if (ret && ret != -ENOSYS ) {printf ("Error enabling VBUS supply (ret=%i)\n" , ret);return ret;Signature · 1 line
2.45.2
Quoted 11 lines · Marek Vasut
With the commit
4fcba5d556b4("regulator: implement basic reference counter") the return value ofregulator_set_enablemay be EALREADY or EBUSY for fixed/gpio regulators.Change to use the more relaxed
regulator_set_enable_if_allowedto continue if regulator already was enabled or disabled.Based on
335799b7252a("usb: dwc2: Useregulator_set_enable_if_allowed")Signed-off-by Marek Vasut <[email protected]>
Hi Marek,
Thank you for the patch.
Quoted 10 lines · Marek Vasut
With the commit
4fcba5d556b4("regulator: implement basic reference counter") the return value ofregulator_set_enablemay be EALREADY or EBUSY for fixed/gpio regulators.Change to use the more relaxed
regulator_set_enable_if_allowedto continue if regulator already was enabled or disabled.Based on
335799b7252a("usb: dwc2: Useregulator_set_enable_if_allowed")Signed-off-by Marek Vasut <[email protected]>
Quoted 31 lines
---
Cc: Alice Guo <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Mathieu Othacehe <[email protected]>
Cc: Mattijs Korpershoek <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: [email protected]--- drivers/usb/host/ehci-mx5.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/usb/host/ehci-mx5.c +3
-3@@ -287,9 +287,9 @@ static int ehci_usb_probe(struct udevice *dev)debug ("%s: No vbus supply\n" , dev->name);if (!ret && priv->vbus_supply) { - ret =regulator_set_enable (priv->vbus_supply, - (type ==USB_INIT_DEVICE ) ? - false : true); + ret =regulator_set_enable_if_allowed (priv->vbus_supply, + (type ==USB_INIT_DEVICE ) ? + false : true);if (ret) {puts ("Error enabling VBUS supply\n" );return ret;Signature · 1 line
2.45.2