perf llvm-add2line: Remove unused include
PATCH 1/1 perf llvm-add2line: Remove unused include
Remove unused symbol_conf.h include.
First, it's just unused. Second, it's problematic since this is a C++ file, and most perf headers don't compile as C++. So if any other includes are added to symbol_conf.h, it may break the build.
Signed-off-by Dmitry Vyukov <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Ian Rogers <[email protected]>
--- tools/perf/util/llvm-c-helpers.cpp | 1 - 1 file changed, 1 deletion(-)
tools/perf/util/llvm-c-helpers.cpp +0 -1
@@ -18,7 +18,6 @@ extern "C" { #include <linux/zalloc.h> } -#include "symbol_conf.h" #include "llvm-c-helpers.h" extern "C"
base-commit: 09a0fa92e5b45e99cf435b2fbf5ebcf889cf8780
Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog
Quoted 4 lines · Dmitry Vyukov
Remove unused
symbol_conf.hinclude.
First, it's just unused. Second, it's problematic since this is a C++ file, and most perf headers don't compile as C++. So if any other includes are added tosymbol_conf.h, it may break the build.
Thanks, applied to perf-tools-next,
- Arnaldo
Quoted 26 lines
Signed-off-by Dmitry Vyukov <[email protected]>Cc Namhyung Kim <[email protected]>Cc Ian Rogers <[email protected]>--- tools/perf/util/llvm-c-helpers.cpp | 1 - 1 file changed, 1 deletion(-)tools/perf/util/llvm-c-helpers.cpp +0
-1@@ -18,7 +18,6 @@ extern "C" { #include <linux/zalloc.h> } -#include "symbol_conf.h" #include "llvm-c-helpers.h" extern "C"base-commit:
09a0fa92e5b45e99cf435b2fbf5ebcf889cf8780Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog