Skip to contentSkip to conversation

bus: mhi: host: Enable MSI-X if the endpoint supports

PATCH Applied Vivek Pernamitta 2 participants 3 messages Jan 8, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bus: mhi: host: Enable MSI-X if the endpoint supports

Enable MSI-X if the endpoint supports.

---
Changes in v2:
- Updated commit text.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 drivers/bus/mhi/host/pci_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/mhi/host/pci_generic.c +1 -1
index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644
@@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl,
 	 */
 	mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events;
 
-	nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI);
+	nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI);
 	if (nr_vectors < 0) {
 		dev_err(&pdev->dev, "Error allocating MSI vectors %d\n",
 			nr_vectors);

---
base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250106-msix-a4c5488ecafe

Best regards,

Signature · 1 line
Vivek Pernamitta <[email protected]>
Reviewed-by on v2 1/1
#1 lore raw

On Wed, Jan 08, 2025 at 09:52:07PM +0530, Vivek Pernamitta wrote:

Subject should have 'pci_generic'. I'll add it while applying.

Quoted 3 lines

Enable MSI-X if the endpoint supports.

- Mani

Quoted 30 lines

---
Changes in v2:
- Updated commit text.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 drivers/bus/mhi/host/pci_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/mhi/host/pci_generic.c +1 -2
index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644
@@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl,
 	 */
 	mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events;
 
-	nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI);
+	nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI);
 	if (nr_vectors < 0) {
 		dev_err(&pdev->dev, "Error allocating MSI vectors %d\n",
 			nr_vectors);
 
---

base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250106-msix-a4c5488ecafe

Best regards,

Signature · 1 line
Vivek Pernamitta <[email protected]>
Signature · 1 line
மணிவண்ணன் சதாசிவம்
#2 lore raw
In reply to Vivek Pernamitta
Quoted 3 lines · Vivek Pernamitta

Enable MSI-X if the endpoint supports.

Applied to mhi-next!

- Mani

Quoted 30 lines

---
Changes in v2:
- Updated commit text.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 drivers/bus/mhi/host/pci_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/mhi/host/pci_generic.c +1 -2
index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644
@@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl,
 	 */
 	mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events;
 
-	nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI);
+	nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI);
 	if (nr_vectors < 0) {
 		dev_err(&pdev->dev, "Error allocating MSI vectors %d\n",
 			nr_vectors);
 
---

base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250106-msix-a4c5488ecafe

Best regards,

Signature · 1 line
Vivek Pernamitta <[email protected]>
Signature · 1 line
மணிவண்ணன் சதாசிவம்