Skip to contentSkip to conversation

xfs_repair: don't obliterate return codes

PATCH In review Darrick J. Wong 2 participants 2 messages Jan 9, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs_repair: don't obliterate return codes

From: Darrick J. Wong <[email protected]>

Don't clobber error here, it's err2 that's the temporary variable.

Coverity-id: 1637363

Fixes b790ab2a303d58 ("xfs_repair: support quota inodes in the metadata directory")
---
 repair/quotacheck.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
repair/quotacheck.c +1 -1
index 8c7339b267d8e6..7953144c3f416b 100644
@@ -691,7 +691,7 @@ discover_quota_inodes(
 	err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_GROUP);
 	if (err2 && !error)
 		error = err2;
-	error = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
+	err2 = mark_quota_inode(tp, dp, XFS_DQTYPE_PROJ);
 	if (err2 && !error)
 		error = err2;