Skip to contentSkip to conversation

net: phy: Kconfig: Fix error related to undefined reference

PATCH In review Divya Koppera 2 participants 2 messages Jan 9, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: Kconfig: Fix error related to undefined reference

When microchip_t1_phy is built in and phyptp is module facing undefined reference issue. This get fixed when microchip_t1_phy made dependent on PTP_1588_CLOCK_OPTIONAL.

Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]

Fixes fa51199c5f34 ("net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys")
---
 drivers/net/phy/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/phy/Kconfig +2 -2
index dc625f2b3ae4..9ad3dbfd2f99 100644
@@ -287,8 +287,8 @@ config MICROCHIP_PHY
 
 config MICROCHIP_T1_PHY
 	tristate "Microchip T1 PHYs"
-	select MICROCHIP_PHY_RDS_PTP if NETWORK_PHY_TIMESTAMPING && \
-				  PTP_1588_CLOCK_OPTIONAL
+	select MICROCHIP_PHY_RDS_PTP if NETWORK_PHY_TIMESTAMPING
+	depends on PTP_1588_CLOCK_OPTIONAL
 	help
 	  Supports the LAN8XXX PHYs.
 
Signature · 1 line
2.17.1
reviewer Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 9 lines · Divya Koppera

When microchip_t1_phy is built in and phyptp is module facing undefined reference issue. This get fixed when microchip_t1_phy made dependent on PTP_1588_CLOCK_OPTIONAL.

Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]

Fixes fa51199c5f34 ("net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys")

Hi Divya,

I think that this patch should be targeted at net-next, where the problem seems to manifest, rather than net where it does not. Likewise, this patch applies to net-next, but not net.

Also, I think the prefix for the patch should be "net: phy: microchip_t1". And perhaps the following subject is a bit more descriptive.

[PATCH net-next] net: phy: microchip_t1: depend on PTP_1588_CLOCK_OPTIONAL

As for the code change itself, it looks good to me.

Signature · 1 line
pw-bot: changes-requested