arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
PATCH 1/1 arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
Make this USB controller consistent with the others on this platform.
--- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100.dtsi +2 -0
@@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@a200000 { snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + dma-coherent; + ports { #address-cells = <1>; #size-cells = <0>;
Signature · 1 line
2.47.1
Quoted 5 lines · Mark Kettenis
Make this USB controller consistent with the others on this platform.
Fixes 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")Signed-off-by Mark Kettenis <[email protected]>---
Konrad
Quoted 13 lines · Mark Kettenis
Make this USB controller consistent with the others on this platform.
Fixes 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")Signed-off-by Mark Kettenis <[email protected]>--- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/qcom/x1e80100.dtsi +0
-0
arch/arm64/boot/dts/qcom/x1e80100.dtsi usb_2_dwc3: usb@a200000 { · line 4818
Quoted 5 lines
arch/arm64/boot/dts/qcom/x1e80100.dtsi +2
-0@@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@a200000 { snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + dma-coherent; +
Can someone from Qualcomm please confirm that this is correct, and that it's not the other way round and this property should be removed from the other controllers (e.g. if this was just some copy-pasta from sm8550 which is the only other Qualcomm platform that claims to have dma-coherent USB controllers).
Johan
Quoted 20 lines
Date: Fri, 10 Jan 2025 17:38:39 +0100
From: Johan Hovold <[email protected]>Quoted 16 lines · Mark Kettenis
Make this USB controller consistent with the others on this platform.
Fixes 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")Signed-off-by Mark Kettenis <[email protected]>--- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/qcom/x1e80100.dtsi +0
-0@@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@a200000 { snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk;
Quoted 8 lines
arch/arm64/boot/dts/qcom/x1e80100.dtsi usb_2_dwc3: usb@a200000 { · line 4818
Quoted 2 lines
arch/arm64/boot/dts/qcom/x1e80100.dtsi +2
-0+ dma-coherent; +Can someone from Qualcomm please confirm that this is correct, and that it's not the other way round and this property should be removed from the other controllers (e.g. if this was just some copy-pasta from sm8550 which is the only other Qualcomm platform that claims to have dma-coherent USB controllers).
It certainly wouldn't hurt to have confirmation from someone familliar with the SoC design.
However treating the controllers as DMA coherent when they're not would almost certainly resulted in reports of USB devices being unreliable on these machines as the OS would skip necessary cache flushes. I did test this patch on the ASUS Vivobook S 15 where the microSD-card reader uses the usb_2 controller.
Quoted 3 lines · Mark Kettenis
Make this USB controller consistent with the others on this platform.
Applied, thanks!
[1/1] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
commit: 45bd6ff900cfe5038e2718a900f153ded3fa5392
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>