binder: log transaction code on failure
Carlos Llamas
maintainerPATCH 1/1 binder: log transaction code on failure
When a transaction fails, log the 'tr->code' to help indentify the problematic userspace call path. This additional information will simplify debugging efforts.
--- drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/android/binder.c +2 -2
@@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *proc, }binder_debug (BINDER_DEBUG_FAILED_TRANSACTION , -"%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n" , +"%d:%d transaction %s to %d:%d failed %d/%d/%d, code %d size %lld-%lld line %d\n" , proc->pid, thread->pid, reply ?"reply" : (tr->flags &TF_ONE_WAY ?"async" :"call" ), target_proc ? target_proc->pid :0 , target_thread ? target_thread->pid :0 , t_debug_id, return_error, return_error_param, - (u64 )tr->data_size, (u64 )tr->offsets_size, + tr->code, (u64 )tr->data_size, (u64 )tr->offsets_size, return_error_line);if (target_thread)
Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog
Alice Ryhl
maintainerQuoted 16 lines · Carlos Llamas
When a transaction fails, log the '
tr->code' to help indentify the problematic userspace call path. This additional information will simplify debugging efforts.Cc Steven Moreland <[email protected]>Signed-off-by Carlos Llamas <[email protected]>--- drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/android/binder.c +0
-0
drivers/android/binder.c static void binder_transaction(struct binder_proc *proc, · line 3804
Quoted 5 lines
drivers/android/binder.c +1
-1@@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *proc, } binder_debug(BINDER_DEBUG_FAILED_TRANSACTION, - "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n", + "%d:%d transaction %s to %d:%d failed %d/%d/%d, code %d size %lld-%lld line %d\n",
Shouldn't this by %u instead?
Alice
Carlos Llamas
maintainerQuoted 19 lines · Alice Ryhl
Quoted 18 lines · Carlos Llamas
When a transaction fails, log the '
tr->code' to help indentify the problematic userspace call path. This additional information will simplify debugging efforts.Cc Steven Moreland <[email protected]>Signed-off-by Carlos Llamas <[email protected]>--- drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/android/binder.c +0
-0@@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *proc, }
Quoted 5 lines
drivers/android/binder.c static void binder_transaction(struct binder_proc *proc, · line 3804
Quoted 3 lines
drivers/android/binder.c +1
-1binder_debug(BINDER_DEBUG_FAILED_TRANSACTION, - "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n", + "%d:%d transaction %s to %d:%d failed %d/%d/%d, code %d size %lld-%lld line %d\n",Shouldn't this by %u instead?
Yes, with tr->code being u32 it technically should use %u. I'll send a new version. Thanks!
Carlos Llamas
maintainerPATCH v2 1/1 binder: log transaction code on failure
In reply to Alice RyhlWhen a transaction fails, log the 'tr->code' to help indentify the problematic userspace call path. This additional information will simplify debugging efforts.
---
Notes:
v2: use %u format specifier per Alice's feedback
drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/android/binder.c +2 -2
@@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *proc, }binder_debug (BINDER_DEBUG_FAILED_TRANSACTION , -"%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n" , +"%d:%d transaction %s to %d:%d failed %d/%d/%d, code %u size %lld-%lld line %d\n" , proc->pid, thread->pid, reply ?"reply" : (tr->flags &TF_ONE_WAY ?"async" :"call" ), target_proc ? target_proc->pid :0 , target_thread ? target_thread->pid :0 , t_debug_id, return_error, return_error_param, - (u64 )tr->data_size, (u64 )tr->offsets_size, + tr->code, (u64 )tr->data_size, (u64 )tr->offsets_size, return_error_line);if (target_thread)
Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog
Quoted 7 lines · Carlos Llamas
When a transaction fails, log the '
tr->code' to help indentify the problematic userspace call path. This additional information will simplify debugging efforts.Cc Steven Moreland <[email protected]>Signed-off-by Carlos Llamas <[email protected]>