usb: dwc3: st: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
Subsystems (3)
PATCH v2 1/1 usb: dwc3: st: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
Letting the compiler remove these functions when the kernel is built without CONFIG_PM_SLEEP support is simpler and less error prone than the use of #ifdef based kernel configuration guards.
---
Changes in v2:
- Split serie in single patches
- Remove irrelevant 'Link:' from commit log
- Link to v1: https://lore.kernel.org/r/[email protected]
--- drivers/usb/dwc3/dwc3-st.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/usb/dwc3/dwc3-st.c +2 -4
@@ -309,7 +309,6 @@ static void st_dwc3_remove(struct platform_device *pdev)reset_control_assert (dwc3_data->rstc_rst); } -#ifdef CONFIG_PM_SLEEP static int st_dwc3_suspend (struct device *dev) {struct st_dwc3 *dwc3_data =dev_get_drvdata (dev);
@@ -343,9 +342,8 @@ static int st_dwc3_resume(struct device *dev)return 0 ; } -#endif /* CONFIG_PM_SLEEP */ -static SIMPLE_DEV_PM_OPS(st_dwc3_dev_pm_ops, st_dwc3_suspend, st_dwc3_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(st_dwc3_dev_pm_ops, st_dwc3_suspend, st_dwc3_resume);static const struct of_device_id st_dwc3_match[] = { { .compatible ="st,stih407-dwc3" },
@@ -360,7 +358,7 @@ static struct platform_driver st_dwc3_driver = { .driver = { .name = "usb-st-dwc3", .of_match_table = st_dwc3_match, - .pm = &st_dwc3_dev_pm_ops, + .pm = pm_sleep_ptr(&st_dwc3_dev_pm_ops), }, };
Signature · 1 line
2.47.1
Quoted 49 lines · Raphael Gallais-Pou
Letting the compiler remove these functions when the kernel is built without
CONFIG_PM_SLEEPsupport is simpler and less error prone than the use of #ifdef based kernel configuration guards.Signed-off-by Raphael Gallais-Pou <[email protected]>---
Changes in v2:
- Split serie in single patches
- Remove irrelevant 'Link:' from commit log
- Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/r/[email protected]__;!!A4F2R9G_pg!e8eD9plJTlBfv3F2PIKo9M_iJd5FS75w9XuozUEOxjdPYLk08Q0x78HpwPg-qAgYHmtAiHqIeHZEnN9JtJ2o0LK80Q$--- drivers/usb/dwc3/dwc3-st.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/usb/dwc3/dwc3-st.c +2
-4@@ -309,7 +309,6 @@ static void st_dwc3_remove(struct platform_device *pdev)reset_control_assert (dwc3_data->rstc_rst); } -#ifdef CONFIG_PM_SLEEP static int st_dwc3_suspend (struct device *dev) {struct st_dwc3 *dwc3_data =dev_get_drvdata (dev);@@ -343,9 +342,8 @@ static int st_dwc3_resume(struct device *dev)return 0 ; } -#endif /* CONFIG_PM_SLEEP */ -static SIMPLE_DEV_PM_OPS(st_dwc3_dev_pm_ops, st_dwc3_suspend, st_dwc3_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(st_dwc3_dev_pm_ops, st_dwc3_suspend, st_dwc3_resume);static const struct of_device_id st_dwc3_match[] = { { .compatible ="st,stih407-dwc3" },@@ -360,7 +358,7 @@ static struct platform_driver st_dwc3_driver = { .driver = { .name = "usb-st-dwc3", .of_match_table = st_dwc3_match, - .pm = &st_dwc3_dev_pm_ops, + .pm = pm_sleep_ptr(&st_dwc3_dev_pm_ops), }, };Signature · 1 line
2.47.1
Thanks,
Thinh