Skip to contentSkip to conversation

HID: lenovo: Fix undefined platform_profile_cycle in ThinkPad X12 keyboard patch

PATCH Applied Vishnu Sankar 2 participants 3 messages Jan 10, 2025 – Jan 13, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: lenovo: Fix undefined platform_profile_cycle in ThinkPad X12 keyboard patch

The commit "HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys" introduced an issue where the CI failed with the following error:
ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!

This issue occurs because platform_profile_cycle is used without ensuring the kernel is configured with CONFIG_ACPI_PLATFORM_PROFILE. To address this, this patch adds conditional support for platform profile management to the Fn+F8 key handling.
The functionality for platform_profile_cycle is now included only when CONFIG_ACPI_PLATFORM_PROFILE is enabled in the kernel configuration.

This ensures compatibility with kernels that do not include the ACPI platform profile feature, resolving the CI build issue.

---
 drivers/hid/hid-lenovo.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
drivers/hid/hid-lenovo.c +13 -3
index bfaadd54cba1..4d00bc4d656e 100644
@@ -31,7 +31,10 @@
 #include <linux/input.h>
 #include <linux/leds.h>
 #include <linux/workqueue.h>
+
+#if IS_ENABLED(CONFIG_ACPI_PLATFORM_PROFILE)
 #include <linux/platform_profile.h>
+#endif /* CONFIG_ACPI_PLATFORM_PROFILE */
 
 #include "hid-ids.h"
 
@@ -724,10 +727,17 @@ static int lenovo_raw_event_TP_X12_tab(struct hid_device *hdev, u32 raw_data)
 			 * Whereas TP X12 TAB2 uses Fn-F8 for toggling
 			 * Power modes
 			 */
-			(hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) ?
-				report_key_event(input, KEY_RFKILL) :
+			if (hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) {
+				report_key_event(input, KEY_RFKILL);
+				return 1;
+			}
+#if IS_ENABLED(CONFIG_ACPI_PLATFORM_PROFILE)
+			else {
 				platform_profile_cycle();
-			return 1;
+				return 1;
+			}
+#endif /* CONFIG_ACPI_PLATFORM_PROFILE */
+			return 0;
 		case TP_X12_RAW_HOTKEY_FN_F10:
 			/* TAB1 has PICKUP Phone and TAB2 use Snipping tool*/
 			(hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB) ?
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 11 lines · Vishnu Sankar

The commit "HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys" introduced an issue where the CI failed with the following error:
ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!

This issue occurs because platform_profile_cycle is used without ensuring the kernel is configured with CONFIG_ACPI_PLATFORM_PROFILE. To address this, this patch adds conditional support for platform profile management to the Fn+F8 key handling.
The functionality for platform_profile_cycle is now included only when CONFIG_ACPI_PLATFORM_PROFILE is enabled in the kernel configuration.

Quoted 2 lines

This ensures compatibility with kernels that do not include the ACPI platform profile feature, resolving the CI build issue.

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs
#2 lore raw

Jiri,
Thanks a lot.

Quoted 23 lines · Jiri Kosina
Quoted 11 lines · Vishnu Sankar

The commit "HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys" introduced an issue where the CI failed with the following error:
ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!

This issue occurs because platform_profile_cycle is used without ensuring the kernel is configured with CONFIG_ACPI_PLATFORM_PROFILE. To address this, this patch adds conditional support for platform profile management to the Fn+F8 key handling.
The functionality for platform_profile_cycle is now included only when CONFIG_ACPI_PLATFORM_PROFILE is enabled in the kernel configuration.

Quoted 2 lines

This ensures compatibility with kernels that do not include the ACPI platform profile feature, resolving the CI build issue.

Applied, thanks.

--
Jiri Kosina
SUSE Labs

Signature · 4 lines
Regards,

      Vishnu Sankar
     +817015150407 (Japan)