Skip to contentSkip to conversation

sched: sch_cake: Align QoS treatment to Windows and Zoom

PATCH In review Toke Høiland-Jørgensen 2 participants 2 messages Jan 10, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: sch_cake: Align QoS treatment to Windows and Zoom

From: Dave Taht <[email protected]>

Cake's diffserv4 mode attempted to follow the IETF webrtc QoS marking standards, RFC8837.

It turns out Windows QoS can only use CS0, CS1, CS5, and CS7.

Zoom defaults to using CS5 for video and screen sharing traffic.

Bump CS4, CS5, and NQB to the video tin (2) in diffserv4 mode, for more bandwidth and lower priority.

This also better aligns with how WiFi presently treats CS5 and NQB.

---
 net/sched/sch_cake.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/sched/sch_cake.c +2 -2
index 48dd8c88903f..2a9288d4b873 100644
@@ -328,8 +328,8 @@ static const u8 diffserv4[] = {
 	1, 0, 0, 0, 0, 0, 0, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
-	3, 0, 2, 0, 2, 0, 2, 0,
-	3, 0, 0, 0, 3, 0, 3, 0,
+	2, 0, 2, 0, 2, 0, 2, 0,
+	2, 0, 0, 0, 2, 0, 3, 0,
 	3, 0, 0, 0, 0, 0, 0, 0,
 	3, 0, 0, 0, 0, 0, 0, 0,
 };
Signature · 1 line
2.47.1
#1 lore raw
Quoted 9 lines · Toke Høiland-Jørgensen

From: Dave Taht <[email protected]>

Cake's diffserv4 mode attempted to follow the IETF webrtc QoS marking standards, RFC8837.

It turns out Windows QoS can only use CS0, CS1, CS5, and CS7.

Zoom defaults to using CS5 for video and screen sharing traffic.

Quoted 7 lines

Bump CS4, CS5, and NQB to the video tin (2) in diffserv4 mode, for more bandwidth and lower priority.

This also better aligns with how WiFi presently treats CS5 and NQB.

Alright, there was some discussion on the cake list re: this. Please drop.

pw-bot: changes-requested