Skip to contentSkip to conversation

gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

PATCH New Vasiliy Kovalev 1 participant 1 message Jan 10, 2025 Stable branch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

From: Juntong Deng <[email protected]>

commit bdcb8aa434c6d36b5c215d02a9ef07551be25a37 upstream.

In gfs2_put_super(), whether withdrawn or not, the quota should be cleaned up by gfs2_quota_cleanup().

Otherwise, struct gfs2_sbd will be freed before gfs2_qd_dealloc (rcu callback) has run for all gfs2_quota_data objects, resulting in use-after-free.

Also, gfs2_destroy_threads() and gfs2_quota_cleanup() is already called by gfs2_make_fs_ro(), so in gfs2_put_super(), after calling gfs2_make_fs_ro(), there is no need to call them again.

---
Backport to fix CVE-2023-52760

---
 fs/gfs2/super.c | 2 ++
 1 file changed, 2 insertions(+)
fs/gfs2/super.c +2 -0
index 268651ac9fc848..98158559893f48 100644
@@ -590,6 +590,8 @@ static void gfs2_put_super(struct super_block *sb)
 
 	if (!sb_rdonly(sb)) {
 		gfs2_make_fs_ro(sdp);
+	} else {
+		gfs2_quota_cleanup(sdp);
 	}
 	WARN_ON(gfs2_withdrawing(sdp));
 
Signature · 1 line
2.33.8