hid-asus: Disable OOBE mode on the ProArt P16
Subsystems (2)
PATCH 1/1 hid-asus: Disable OOBE mode on the ProArt P16
The new ASUS ProArt 16" laptop series come with their keyboards stuck in an Out-Of-Box-Experience mode. While in this mode most functions will not work such as LED control or Fn key combos. The correct init sequence is now done to disable this OOBE.
This patch addresses only the ProArt series so far and it is unknown if there may be others, in which case a new quirk may be required.
--- drivers/hid/hid-asus.c | 26 ++++++++++++++++++++++ include/linux/platform_data/x86/asus-wmi.h | 5 +++++ 2 files changed, 31 insertions(+)
drivers/hid/hid-asus.c +26 -0
@@ -437,6 +437,26 @@ static int asus_kbd_get_functions(struct hid_device *hdev,return ret; } +static int asus_kbd_disable_oobe (struct hid_device *hdev) +{ +const u8 init[][6 ] = { + {FEATURE_KBD_REPORT_ID ,0x05 ,0x20 ,0x31 ,0x00 ,0x08 }, + {FEATURE_KBD_REPORT_ID ,0xBA ,0xC5 ,0xC4 }, + {FEATURE_KBD_REPORT_ID ,0xD0 ,0x8F ,0x01 }, + {FEATURE_KBD_REPORT_ID ,0xD0 ,0x85 ,0xFF } + }; +int ret; + +for (size_t i =0 ; i <ARRAY_SIZE (init); i++) { + ret =asus_kbd_set_report (hdev, init[i],sizeof (init[i])); +if (ret <0 ) +return ret; + } + +hid_info (hdev,"Disabled OOBE for keyboard\n" ); +return 0 ; +} +static void asus_schedule_work (struct asus_kbd_leds *led) {unsigned long flags;
@@ -539,6 +559,12 @@ static int asus_kbd_register_leds(struct hid_device *hdev) ret =asus_kbd_init (hdev,FEATURE_KBD_LED_REPORT_ID2 );if (ret <0 )return ret; + +if (dmi_match (DMI_PRODUCT_FAMILY ,"ProArt P16" )) { + ret =asus_kbd_disable_oobe (hdev); +if (ret <0 ) +return ret; + } }else {/* Initialize keyboard */ ret =asus_kbd_init (hdev,FEATURE_KBD_REPORT_ID );
include/linux/platform_data/x86/asus-wmi.h +5 -0
@@ -206,6 +206,11 @@ static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = { DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"), }, }, + { + .matches = { + DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"), + }, + }, { .matches = { DMI_MATCH(DMI_BOARD_NAME, "GA403U"),
Signature · 1 line
2.47.1
Quoted 5 lines · Luke D. Jones
The new ASUS ProArt 16" laptop series come with their keyboards stuck in an Out-Of-Box-Experience mode. While in this mode most functions will not work such as LED control or Fn key combos. The correct init sequence is now done to disable this OOBE.
Quoted 7 lines
This patch addresses only the ProArt series so far and it is unknown if there may be others, in which case a new quirk may be required.
Signed-off-by Luke D. Jones <[email protected]>Co-developed-by Connor Belli <[email protected]>Signed-off-by Connor Belli <[email protected]>Tested-by Jan Schmidt <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs