Add support for Ariaboard Photonicat RK3568
Subsystems (2)
v6 cover Add support for Ariaboard Photonicat RK3568
Add dts for Ariaboard Photonicat RK3568.
This series bring support for:
* Debug UART
* SDIO QCA9377 WiFi and Bluetooth
* M.2 E-Key PCIe WiFi and Bluetooth
* M.2 B-Key USB Modem WWAN
* Ethernet WAN Port
* MicroSD Card slot
* eMMC
* HDMI Output
* Mali GPU
* USB Type-A
Changed from v1:
- move some general nodes (firmware, ramoops, reboot-mode) to rk356x.dtsi
- gmac1 change to phy-mode rgmii-id
- corrected some regulator to be closer to schematics
- rename rk3568-ariaboard-photonicat.dts to rk3568-photonicat.dts
https://lore.kernel.org/lkml/[email protected]/
Changed from v2:
- remove unused headers
- corrected some regulator to be closer to schematics
- remove usb_host1_ohci, usb_host1_ehci, usb2phy1_host that have no connection
https://lore.kernel.org/lkml/[email protected]/
Changed from v3:
- corrected some regulator to be closer to schematics
- changed to using clk32k_out1 in xin32k
https://lore.kernel.org/lkml/[email protected]/
Changed from v4:
- corrected some regulator to be closer to schematics
- corrected some label to match node name
- use resets props in phy node instead deprecated snps,reset-gpio
https://lore.kernel.org/lkml/[email protected]/
Changed from v5:
- resort regulator nodes
- remove dr_mode from usb_host1_xhci
https://lore.kernel.org/lkml/[email protected]/
Junhao Xie (3):
dt-bindings: vendor-prefixes: Add prefix for Ariaboard
dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
.../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 599 ++++++++++++++++++ 4 files changed, 607 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Signature · 7 lines
2.47.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v6 1/3 dt-bindings: vendor-prefixes: Add prefix for Ariaboard
Add an entry for Ariaboard from Shanghai Novotech
Ariaboard represents a product line from Shanghai Novotech Co., Ltd.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -147,6 +147,8 @@ patternProperties: description: Arctic Sand "^arcx,.*": description: arcx Inc. / Archronix Inc. + "^ariaboard,.*": + description: Shanghai Novotech Co., Ltd. (Ariaboard) "^aries,.*": description: Aries Embedded GmbH "^arm,.*":
Signature · 7 lines
2.47.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v6 2/3 dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
In reply to Junhao XieThis documents Ariaboard Photonicat which is a router based on RK3568 SoC.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -49,6 +49,11 @@ properties: - anbernic,rg-arc-s - const: rockchip,rk3566 + - description: Ariaboard Photonicat + items: + - const: ariaboard,photonicat + - const: rockchip,rk3568 + - description: ArmSoM Sige5 board items: - const: armsom,sige5
Signature · 7 lines
2.47.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v6 3/3 arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
In reply to Junhao XieAdd dts for Ariaboard Photonicat RK3568.
Working IO:
Debug UART
SDIO QCA9377 WiFi and Bluetooth
M.2 E-Key PCIe WiFi and Bluetooth
M.2 B-Key USB Modem WWAN
Ethernet WAN Port
MicroSD Card slot
eMMC
HDMI Output
Mali GPU
USB Type-A
Not working IO:
Ethernet LAN Port (Lack of SGMII support) Power management MCU on UART4 (Driver pending)
Not working IO in MCU:
Battery voltage sensor
Board temperature sensor
Hardware Power-off
Hardware Watchdog
Network status LED
Real-time clock
USB Charger voltage sensor
About onboard power management MCU:
A heartbeat must be sent to the MCU within 60 seconds, otherwise the MCU will restart the system.
When powering off, a shutdown command needs to be sent to the MCU. When the power button is long pressed, the MCU will send a shutdown command to the system. If system does not shutdown within 60 seconds, the power will be turned off directly.
MCU only provides voltage for charger and battery. Manufacturer removed RK8xx PMIC.
--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 599 ++++++++++++++++++ 2 files changed, 600 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -120,6 +120,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-mecsbc.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5c.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5s.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-photonicat.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-qnap-ts433.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-radxa-e25.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-roc-pc.dtb
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +599 -0
599 lines not on this page · raw message
Signature · 7 lines
2.47.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Hi,
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 91
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +5
-0+ /* pi6c pcie clock generator */ + vcc3v3_pi6c: regulator-vcc3v3-pi6c { + compatible = "regulator-fixed"; + enable-active-high; + gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
Although both gpio and gpios can be used here, I tend to use gpio to keep it consistent with other parts. (vcc3v3_sd, vcc3v4_rf, vcc5v0_usb30_otg0 ...)
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 346
Quoted 2 lines
+&mdio1 {
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ rgmii_phy1: ethernet-phy@0 {
Only one rgmii phy I think '1' is not needed? Or phy@address: ethernet-phy@address {
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 348
Quoted 2 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0x0>;
The phy address should be 3. Can you try it?
Review
Quoted 2 lines
(quoted diff) +2
-0+ pinctrl-names = "default"; + pinctrl-0 = <ð1_phy_rst>;
Is pinctrl necessary here?
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 509
Quoted 7 lines
+&sdmmc1 {
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +6
-0+ ... + wifi: wifi@1 { + ... +&uart1 { + ... + bluetooth: bluetooth {
No aliases needed.
Signature · 1 line
2.25.1
Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Quoted 10 lines · Chukun Pan
Hi,
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 91
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +5
-0+ /* pi6c pcie clock generator */ + vcc3v3_pi6c: regulator-vcc3v3-pi6c { + compatible = "regulator-fixed"; + enable-active-high; + gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;Although both gpio and gpios can be used here, I tend to use gpio to keep it consistent with other parts. (
vcc3v3_sd,vcc3v4_rf,vcc5v0_usb30_otg0...)
Yes, I overlooked it, I will change it to this:
gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 346
Quoted 3 lines
+&mdio1 {
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ rgmii_phy1: ethernet-phy@0 {Only one rgmii phy I think '1' is not needed? Or
phy@address: ethernet-phy@address {
I used sgmii_phy0 rgmii_phy1 to name them, they are indeed redundant, and sgmii is not in mainline yet, I will change rgmii_phy1 to rgmii_phy.
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 348
Quoted 3 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0x0>;The phy address should be 3. Can you try it?
It seems to work fine when using address 0x3, I will modify it.
Quoted 5 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ pinctrl-names = "default"; + pinctrl-0 = <ð1_phy_rst>;Is pinctrl necessary here?
I will remove it.
The node now looks like this:
&mdio1 {
rgmii_phy: ethernet-phy@3 {
compatible = "ethernet-phy-ieee802.3-c22";
reg = <0x3>;
reset-assert-us = <20000>;
reset-deassert-us = <100000>;
reset-gpios = <&gpio4 RK_PC0 GPIO_ACTIVE_LOW>;
rx-internal-delay-ps = <1500>;
tx-internal-delay-ps = <1500>;
};
};Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 509
Quoted 8 lines
+&sdmmc1 {
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +6
-0+ ... + wifi: wifi@1 { + ... +&uart1 { + ... + bluetooth: bluetooth {No aliases needed.
I will remove it.
Quoted 1 line
Thanks for your review, I will fix all problems in next version!
Best regards,
Junhao
Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
In reply to Junhao XieHello Junhao,
Quoted 27 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
Working IO:
Debug UART
SDIO QCA9377 WiFi and Bluetooth
M.2 E-Key PCIe WiFi and Bluetooth
M.2 B-Key USB Modem WWAN
Ethernet WAN Port
MicroSD Card slot
eMMC
HDMI Output
Mali GPU
USB Type-ANot working IO:
Ethernet LAN Port (Lack of SGMII support) Power management MCU on UART4 (Driver pending)Not working IO in MCU:
Battery voltage sensor
Board temperature sensor
Hardware Power-off
Hardware Watchdog
Network status LED
Real-time clock
USB Charger voltage sensor
Quoted 10 lines
About onboard power management MCU:
A heartbeat must be sent to the MCU within 60 seconds, otherwise the MCU will restart the system.
When powering off, a shutdown command needs to be sent to the MCU. When the power button is long pressed, the MCU will send a shutdown command to the system. If system does not shutdown within 60
seconds,
the power will be turned off directly.
MCU only provides voltage for charger and battery. Manufacturer removed RK8xx PMIC.
Unless the design of the board is proprietary, it would be good to provide a link to the board schematic, for those interested in verifying the board DT file.
As a note, I already tried to find the board schematic with no success, so the design might be proprietary.
Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Quoted 40 lines · Dragan Simic
Hello Junhao,
Quoted 27 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
Working IO:
Debug UART
SDIO QCA9377 WiFi and Bluetooth
M.2 E-Key PCIe WiFi and Bluetooth
M.2 B-Key USB Modem WWAN
Ethernet WAN Port
MicroSD Card slot
eMMC
HDMI Output
Mali GPU
USB Type-ANot working IO:
Ethernet LAN Port (Lack of SGMII support) Power management MCU on UART4 (Driver pending)Not working IO in MCU:
Battery voltage sensor
Board temperature sensor
Hardware Power-off
Hardware Watchdog
Network status LED
Real-time clock
USB Charger voltage sensorQuoted 9 lines
About onboard power management MCU:
A heartbeat must be sent to the MCU within 60 seconds, otherwise the MCU will restart the system.
When powering off, a shutdown command needs to be sent to the MCU. When the power button is long pressed, the MCU will send a shutdown command to the system. If system does not shutdown within 60 seconds, the power will be turned off directly.
MCU only provides voltage for charger and battery. Manufacturer removed RK8xx PMIC.
Quoted 6 lines
Unless the design of the board is proprietary, it would be good to provide a link to the board schematic, for those interested in verifying the board DT file.
As a note, I already tried to find the board schematic with no success, so the design might be proprietary.
Yes, this board is proprietary. I asked the manufacturer and they don't provide schematics.
But I found a partial schematic diagram of some of connectors on the board here
https://dl.ariaboard.com/photonicat_rk3568/Photonicat%20rk3568%20EVB%20Board%20spec.pdf
Best regards,
Junhao
Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Hello Junhao,
Quoted 46 lines · Junhao Xie
Quoted 38 lines · Dragan Simic
Quoted 27 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
Working IO:
Debug UART
SDIO QCA9377 WiFi and Bluetooth
M.2 E-Key PCIe WiFi and Bluetooth
M.2 B-Key USB Modem WWAN
Ethernet WAN Port
MicroSD Card slot
eMMC
HDMI Output
Mali GPU
USB Type-ANot working IO:
Ethernet LAN Port (Lack of SGMII support) Power management MCU on UART4 (Driver pending)Not working IO in MCU:
Battery voltage sensor
Board temperature sensor
Hardware Power-off
Hardware Watchdog
Network status LED
Real-time clock
USB Charger voltage sensorQuoted 9 lines
About onboard power management MCU:
A heartbeat must be sent to the MCU within 60 seconds, otherwise the MCU will restart the system.
When powering off, a shutdown command needs to be sent to the MCU. When the power button is long pressed, the MCU will send a shutdown command to the system. If system does not shutdown within 60 seconds, the power will be turned off directly.
MCU only provides voltage for charger and battery. Manufacturer removed RK8xx PMIC.Quoted 6 lines
Unless the design of the board is proprietary, it would be good to provide a link to the board schematic, for those interested in verifying the board DT file.
As a note, I already tried to find the board schematic with no success, so the design might be proprietary.
Quoted 6 lines
Yes, this board is proprietary. I asked the manufacturer and they don't provide schematics.
But I found a partial schematic diagram of some of connectors on the board here
https://dl.ariaboard.com/photonicat_rk3568/Photonicat%20rk3568%20EVB%20Board%20spec.pdf
Yes, I also found that PDF file. It's somewhat similar to what Raspberry Pi provides with its reduced schematics -- helpful to an extent, but still leaving a lot to be desired.
Out of curiosity, what did you actually use as a reference to create the board dts file? Perhaps some downstream dts file provided by the manufacturer or found in some operating system image?
Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Quoted 56 lines · Dragan Simic
Hello Junhao,
Quoted 46 lines · Junhao Xie
Quoted 38 lines · Dragan Simic
Quoted 27 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
Working IO:
Debug UART
SDIO QCA9377 WiFi and Bluetooth
M.2 E-Key PCIe WiFi and Bluetooth
M.2 B-Key USB Modem WWAN
Ethernet WAN Port
MicroSD Card slot
eMMC
HDMI Output
Mali GPU
USB Type-ANot working IO:
Ethernet LAN Port (Lack of SGMII support) Power management MCU on UART4 (Driver pending)Not working IO in MCU:
Battery voltage sensor
Board temperature sensor
Hardware Power-off
Hardware Watchdog
Network status LED
Real-time clock
USB Charger voltage sensorQuoted 9 lines
About onboard power management MCU:
A heartbeat must be sent to the MCU within 60 seconds, otherwise the MCU will restart the system.
When powering off, a shutdown command needs to be sent to the MCU. When the power button is long pressed, the MCU will send a shutdown command to the system. If system does not shutdown within 60 seconds, the power will be turned off directly.
MCU only provides voltage for charger and battery. Manufacturer removed RK8xx PMIC.Quoted 6 lines
Unless the design of the board is proprietary, it would be good to provide a link to the board schematic, for those interested in verifying the board DT file.
As a note, I already tried to find the board schematic with no success, so the design might be proprietary.
Quoted 6 lines
Yes, this board is proprietary. I asked the manufacturer and they don't provide schematics.
But I found a partial schematic diagram of some of connectors on the board here
https://dl.ariaboard.com/photonicat_rk3568/Photonicat%20rk3568%20EVB%20Board%20spec.pdf
Quoted 7 lines
Yes, I also found that PDF file. It's somewhat similar to what Raspberry Pi provides with its reduced schematics -- helpful to an extent, but still leaving a lot to be desired.
Out of curiosity, what did you actually use as a reference to create the board dts file? Perhaps some downstream dts file provided by the manufacturer or found in some operating system image?
I wrote this device tree based on other rk3568 devices in mainline, and downstream board dts:
https://github.com/photonicat/rockchip_rk3568_kernel/blob/novotech-5.10/arch/arm64/boot/dts/rockchip/rk3568-photonicat-base.dtsi
Best regards,
Junhao
Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Hello Junhao,
Quoted 21 lines · Junhao Xie
Quoted 20 lines · Dragan Simic
Quoted 8 lines · Junhao Xie
Quoted 6 lines · Dragan Simic
Unless the design of the board is proprietary, it would be good to provide a link to the board schematic, for those interested in verifying the board DT file.
As a note, I already tried to find the board schematic with no success, so the design might be proprietary.
Quoted 6 lines
Yes, this board is proprietary. I asked the manufacturer and they don't provide schematics.
But I found a partial schematic diagram of some of connectors on the board here
https://dl.ariaboard.com/photonicat_rk3568/Photonicat%20rk3568%20EVB%20Board%20spec.pdfYes, I also found that PDF file. It's somewhat similar to what Raspberry Pi provides with its reduced schematics -- helpful to an extent, but still leaving a lot to be desired.
Quoted 7 lines
Quoted 3 lines
Out of curiosity, what did you actually use as a reference to create the board dts file? Perhaps some downstream dts file provided by the manufacturer or found in some operating system image?
I wrote this device tree based on other rk3568 devices in mainline, and downstream board dts:
https://github.com/photonicat/rockchip_rk3568_kernel/blob/novotech-5.10/arch/arm64/boot/dts/rockchip/rk3568-photonicat-base.dtsi
Thanks for the clarification. It would be good to include that link in the description of patch 3/3, for future reference.
Hello Junhao,
Quoted 14 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
This series bring support for:
* Debug UART
* SDIO QCA9377 WiFi and Bluetooth
* M.2 E-Key PCIe WiFi and Bluetooth
* M.2 B-Key USB Modem WWAN
* Ethernet WAN Port
* MicroSD Card slot
* eMMC
* HDMI Output
* Mali GPU
* USB Type-A
Quoted 3 lines
Changed from v1:
- move some general nodes (firmware, ramoops, reboot-mode) tork356x.dtsi
This entry from the changelog caught my attention, so I tried to find out what exactly happened back then. Though, after going through the mailing list archive, I still don't see where the as-described change took place, so perhaps this changelog entry needs adjusting.
Quoted 39 lines
- gmac1 change to phy-mode rgmii-id
- corrected some regulator to be closer to schematics
- renamerk3568-ariaboard-photonicat.dtstork3568-photonicat.dts
https://lore.kernel.org/lkml/[email protected]/Changed from v2:
- remove unused headers
- corrected some regulator to be closer to schematics
- removeusb_host1_ohci,usb_host1_ehci,usb2phy1_hostthat have no connection
https://lore.kernel.org/lkml/[email protected]/Changed from v3:
- corrected some regulator to be closer to schematics
- changed to usingclk32k_out1in xin32k
https://lore.kernel.org/lkml/[email protected]/Changed from v4:
- corrected some regulator to be closer to schematics
- corrected some label to match node name
- use resets props in phy node instead deprecated snps,reset-gpio
https://lore.kernel.org/lkml/[email protected]/Changed from v5:
- resort regulator nodes
- removedr_modefromusb_host1_xhci
https://lore.kernel.org/lkml/[email protected]/Junhao Xie (3):
dt-bindings: vendor-prefixes: Add prefix for Ariaboard
dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568.../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 599 ++++++++++++++++++ 4 files changed, 607 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 17 lines · Dragan Simic
Hello Junhao,
Quoted 14 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
This series bring support for:
* Debug UART
* SDIO QCA9377 WiFi and Bluetooth
* M.2 E-Key PCIe WiFi and Bluetooth
* M.2 B-Key USB Modem WWAN
* Ethernet WAN Port
* MicroSD Card slot
* eMMC
* HDMI Output
* Mali GPU
* USB Type-A
Quoted 8 lines
Quoted 2 lines
Changed from v1:
- move some general nodes (firmware, ramoops, reboot-mode) tork356x.dtsiThis entry from the changelog caught my attention, so I tried to find out what exactly happened back then. Though, after going through the mailing list archive, I still don't see where the as-described change took place, so perhaps this changelog entry needs adjusting.
Chukun Pan suggested moving these nodes to rk356x.dtsi, but I have not done that yet and simply deleted them. I will fix the changelog.
https://lore.kernel.org/lkml/[email protected]/
- remove some general nodes (firmware, ramoops, reboot-mode)
Quoted 33 lines
Quoted 33 lines
- gmac1 change to phy-mode rgmii-id
- corrected some regulator to be closer to schematics
- renamerk3568-ariaboard-photonicat.dtstork3568-photonicat.dts
https://lore.kernel.org/lkml/[email protected]/Changed from v2:
- remove unused headers
- corrected some regulator to be closer to schematics
- removeusb_host1_ohci,usb_host1_ehci,usb2phy1_hostthat have no connection
https://lore.kernel.org/lkml/[email protected]/Changed from v3:
- corrected some regulator to be closer to schematics
- changed to usingclk32k_out1in xin32k
https://lore.kernel.org/lkml/[email protected]/Changed from v4:
- corrected some regulator to be closer to schematics
- corrected some label to match node name
- use resets props in phy node instead deprecated snps,reset-gpio
https://lore.kernel.org/lkml/[email protected]/Changed from v5:
- resort regulator nodes
- removedr_modefromusb_host1_xhci
https://lore.kernel.org/lkml/[email protected]/Junhao Xie (3):
dt-bindings: vendor-prefixes: Add prefix for Ariaboard
dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Quoted 6 lines
Quoted 6 lines
.../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 599 ++++++++++++++++++
4 files changed, 607 insertions(+)create mode 100644
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Thanks for your review, I will fix all problems in next version!
Best regards,
Junhao
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hello Junhao,
Quoted 26 lines · Junhao Xie
Quoted 19 lines · Dragan Simic
Quoted 14 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
This series bring support for:
* Debug UART
* SDIO QCA9377 WiFi and Bluetooth
* M.2 E-Key PCIe WiFi and Bluetooth
* M.2 B-Key USB Modem WWAN
* Ethernet WAN Port
* MicroSD Card slot
* eMMC
* HDMI Output
* Mali GPU
* USB Type-AQuoted 3 lines
Changed from v1:
- move some general nodes (firmware, ramoops, reboot-mode) tork356x.dtsiQuoted 5 lines
This entry from the changelog caught my attention, so I tried to find out what exactly happened back then. Though, after going through the mailing list archive, I still don't see where the as-described change took place, so perhaps this changelog entry needs adjusting.
Quoted 5 lines
Chukun Pan suggested moving these nodes to
rk356x.dtsi, but I have not done that yet and simply deleted them. I will fix the changelog.
https://lore.kernel.org/lkml/[email protected]/- remove some general nodes (firmware, ramoops, reboot-mode)
Oh, thanks for the nudge, I just added a TODO to "sprinkle" a few "syscon-reboot-mode" and "ramoops" nodes onto the relevant SoC dtsi files. Those will be highly useful when debugging mysterious crashes and lockups that happen on various devices in the field.
Quoted 41 lines
Quoted 33 lines
Quoted 33 lines
- gmac1 change to phy-mode rgmii-id
- corrected some regulator to be closer to schematics
- renamerk3568-ariaboard-photonicat.dtstork3568-photonicat.dts
https://lore.kernel.org/lkml/[email protected]/Changed from v2:
- remove unused headers
- corrected some regulator to be closer to schematics
- removeusb_host1_ohci,usb_host1_ehci,usb2phy1_hostthat have no connection
https://lore.kernel.org/lkml/[email protected]/Changed from v3:
- corrected some regulator to be closer to schematics
- changed to usingclk32k_out1in xin32k
https://lore.kernel.org/lkml/[email protected]/Changed from v4:
- corrected some regulator to be closer to schematics
- corrected some label to match node name
- use resets props in phy node instead deprecated snps,reset-gpio
https://lore.kernel.org/lkml/[email protected]/Changed from v5:
- resort regulator nodes
- removedr_modefromusb_host1_xhci
https://lore.kernel.org/lkml/[email protected]/Junhao Xie (3):
dt-bindings: vendor-prefixes: Add prefix for Ariaboard
dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568Quoted 7 lines
Quoted 7 lines
.../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 599
++++++++++++++++++4 files changed, 607 insertions(+)create mode 100644
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 1 line
Thanks for your review, I will fix all problems in next version!
Thanks, although it was just a "mile-high" review that covered only a few things that caught my attention. :)
Rob Herring (Arm)
maintainerQuoted 55 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
This series bring support for:
* Debug UART
* SDIO QCA9377 WiFi and Bluetooth
* M.2 E-Key PCIe WiFi and Bluetooth
* M.2 B-Key USB Modem WWAN
* Ethernet WAN Port
* MicroSD Card slot
* eMMC
* HDMI Output
* Mali GPU
* USB Type-AChanged from v1:
- move some general nodes (firmware, ramoops, reboot-mode) tork356x.dtsi
- gmac1 change to phy-mode rgmii-id
- corrected some regulator to be closer to schematics
- renamerk3568-ariaboard-photonicat.dtstork3568-photonicat.dts
https://lore.kernel.org/lkml/[email protected]/Changed from v2:
- remove unused headers
- corrected some regulator to be closer to schematics
- removeusb_host1_ohci,usb_host1_ehci,usb2phy1_hostthat have no connection
https://lore.kernel.org/lkml/[email protected]/Changed from v3:
- corrected some regulator to be closer to schematics
- changed to usingclk32k_out1in xin32k
https://lore.kernel.org/lkml/[email protected]/Changed from v4:
- corrected some regulator to be closer to schematics
- corrected some label to match node name
- use resets props in phy node instead deprecated snps,reset-gpio
https://lore.kernel.org/lkml/[email protected]/Changed from v5:
- resort regulator nodes
- removedr_modefromusb_host1_xhci
https://lore.kernel.org/lkml/[email protected]/Junhao Xie (3):
dt-bindings: vendor-prefixes: Add prefix for Ariaboard
dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568.../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 599 ++++++++++++++++++ 4 files changed, 607 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 5 lines
--
2.47.1
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for [email protected]:
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dtb: bluetooth: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#arch/arm64/boot/dts/rockchip/rk3568-photonicat.dtb: phy@fe8c0000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml#arch/arm64/boot/dts/rockchip/rk3568-photonicat.dtb: rfkill-modem: 'reset-gpios' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/rfkill-gpio.yaml#