iio: adc: stm32: Drop unnecessary DT property presence check
PATCH 1/1 iio: adc: stm32: Drop unnecessary DT property presence check
There's no reason to check for regulator supply property presence before calling devm_regulator_get_optional() as that will return -ENODEV if the supply is not present.
---
The diff context doesn't show it, but the next line returns on error other than -ENODEV.
drivers/iio/adc/stm32-adc-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/iio/adc/stm32-adc-core.c +2 -4
@@ -615,8 +615,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, }/* Booster can be used to supply analog switches (optional) */ -if (priv->cfg->has_syscfg &HAS_VBOOSTER && -of_property_read_bool (np,"booster-supply" )) { +if (priv->cfg->has_syscfg &HAS_VBOOSTER ) { priv->booster =devm_regulator_get_optional (dev,"booster" );if (IS_ERR (priv->booster)) { ret =PTR_ERR (priv->booster);
@@ -628,8 +627,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, }/* Vdd can be used to supply analog switches (optional) */ -if (priv->cfg->has_syscfg &HAS_ANASWVDD && -of_property_read_bool (np,"vdd-supply" )) { +if (priv->cfg->has_syscfg &HAS_ANASWVDD ) { priv->vdd =devm_regulator_get_optional (dev,"vdd" );if (IS_ERR (priv->vdd)) { ret =PTR_ERR (priv->vdd);
Signature · 1 line
2.45.2
Quoted 8 lines · Rob Herring (Arm)
There's no reason to check for regulator supply property presence before calling
devm_regulator_get_optional()as that will return-ENODEVif the supply is not present.Signed-off-by Rob Herring (Arm) <[email protected]>---
The diff context doesn't show it, but the next line returns on error other than-ENODEV.
Hi Rob,
Tested on STM32MP157C-EV1,
Thanks & BR,
Fabrice
Quoted 28 lines
drivers/iio/adc/stm32-adc-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/iio/adc/stm32-adc-core.c +2
-4@@ -615,8 +615,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, }/* Booster can be used to supply analog switches (optional) */ -if (priv->cfg->has_syscfg &HAS_VBOOSTER && -of_property_read_bool (np,"booster-supply" )) { +if (priv->cfg->has_syscfg &HAS_VBOOSTER ) { priv->booster =devm_regulator_get_optional (dev,"booster" );if (IS_ERR (priv->booster)) { ret =PTR_ERR (priv->booster);@@ -628,8 +627,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, }/* Vdd can be used to supply analog switches (optional) */ -if (priv->cfg->has_syscfg &HAS_ANASWVDD && -of_property_read_bool (np,"vdd-supply" )) { +if (priv->cfg->has_syscfg &HAS_ANASWVDD ) { priv->vdd =devm_regulator_get_optional (dev,"vdd" );if (IS_ERR (priv->vdd)) { ret =PTR_ERR (priv->vdd);
Jonathan Cameron
maintainerQuoted 8 lines · On Thu, 9 Jan 2025 12:23:25 -0600 "Rob Herring (Arm)" <[email protected]> wrote:
There's no reason to check for regulator supply property presence before calling
devm_regulator_get_optional()as that will return-ENODEVif the supply is not present.Signed-off-by Rob Herring (Arm) <[email protected]>---
The diff context doesn't show it, but the next line returns on error other than-ENODEV.
Thanks for that. Saved me opening the file.
Applied to the testing branch of iio.git. Probably next cycle material now.
Jonathan
Quoted 28 lines
drivers/iio/adc/stm32-adc-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/iio/adc/stm32-adc-core.c +2
-4@@ -615,8 +615,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, }/* Booster can be used to supply analog switches (optional) */ -if (priv->cfg->has_syscfg &HAS_VBOOSTER && -of_property_read_bool (np,"booster-supply" )) { +if (priv->cfg->has_syscfg &HAS_VBOOSTER ) { priv->booster =devm_regulator_get_optional (dev,"booster" );if (IS_ERR (priv->booster)) { ret =PTR_ERR (priv->booster);@@ -628,8 +627,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, }/* Vdd can be used to supply analog switches (optional) */ -if (priv->cfg->has_syscfg &HAS_ANASWVDD && -of_property_read_bool (np,"vdd-supply" )) { +if (priv->cfg->has_syscfg &HAS_ANASWVDD ) { priv->vdd =devm_regulator_get_optional (dev,"vdd" );if (IS_ERR (priv->vdd)) { ret =PTR_ERR (priv->vdd);