ARM: dts: imx5: Fix the CCM interrupts description
Fabio Estevam
reviewerPATCH v2 1/2 ARM: dts: imx5: Fix the CCM interrupts description
From: Fabio Estevam <[email protected]>
On the i.MX5 chips the peripheral interrupts are represented directly only by their interrupt numbers.
The CCM nodes are not following this format and cause the following dt-schema warnings:
ccm@73fd4000: interrupts: [[0], [71], [4], [0], [72], [4]] is too long
Fix it by passing only the two interrupt numbers.
Run-time tested in on an imx53-qsb board.
---
Changes since v1:
- Use interrupts = <71>, <72>;
arch/arm/boot/dts/nxp/imx/imx50.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx51.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx53.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/nxp/imx/imx50.dtsi +1 -1
@@ -338,7 +338,7 @@ src: reset-controller@53fd0000 { clks: ccm@53fd4000 { compatible = "fsl,imx50-ccm"; reg = <0x53fd4000 0x4000>; - interrupts = <0 71 0x04 0 72 0x04>; + interrupts = <71>, <72>; #clock-cells = <1>; };
arch/arm/boot/dts/nxp/imx/imx51.dtsi +1 -1
@@ -458,7 +458,7 @@ src: reset-controller@73fd0000 { clks: ccm@73fd4000 { compatible = "fsl,imx51-ccm"; reg = <0x73fd4000 0x4000>; - interrupts = <0 71 0x04 0 72 0x04>; + interrupts = <71>, <72>; #clock-cells = <1>; }; };
arch/arm/boot/dts/nxp/imx/imx53.dtsi +1 -1
@@ -598,7 +598,7 @@ src: reset-controller@53fd0000 { clks: ccm@53fd4000 { compatible = "fsl,imx53-ccm"; reg = <0x53fd4000 0x4000>; - interrupts = <0 71 0x04 0 72 0x04>; + interrupts = <71>, <72>; #clock-cells = <1>; };
Signature · 1 line
2.34.1
Fabio Estevam
reviewerPATCH v2 2/2 dt-bindings: clock: imx5: Fix the CCM interrupts description
From: Fabio Estevam <[email protected]>
On the i.MX5 chips the peripheral interrupts are represented directly only by their interrupt numbers.
Make the CCM nodes to follow this format.
---
Changes since v1:
- Use interrupts = <71>, <72>;
Documentation/devicetree/bindings/clock/imx5-clock.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Documentation/devicetree/bindings/clock/imx5-clock.yaml +1 -3
@@ -46,13 +46,11 @@ additionalProperties: false examples: - | #include <dt-bindings/clock/imx5-clock.h> - #include <dt-bindings/interrupt-controller/arm-gic.h> clock-controller@53fd4000{ compatible = "fsl,imx53-ccm"; reg = <0x53fd4000 0x4000>; - interrupts = <0 71 IRQ_TYPE_LEVEL_HIGH>, - <0 72 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <71>, <72>; #clock-cells = <1>; }; ...
Signature · 1 line
2.34.1
Re: [PATCH v2 2/2] dt-bindings: clock: imx5: Fix the CCM interrupts description
Quoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX5 chips the peripheral interrupts are represented directly only by their interrupt numbers.
Make the CCM nodes to follow this format.
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Use interrupts = <71>, <72>;
Best regards,
Krzysztof
Rob Herring (Arm)
maintainerQuoted 15 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX5 chips the peripheral interrupts are represented directly only by their interrupt numbers.
The CCM nodes are not following this format and cause the following dt-schema warnings:
ccm@73fd4000: interrupts: [[0], [71], [4], [0], [72], [4]] is too long
Fix it by passing only the two interrupt numbers.
Run-time tested in on an imx53-qsb board.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 9 lines
---
Changes since v1:
- Use interrupts = <71>, <72>;arch/arm/boot/dts/nxp/imx/imx50.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx51.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx53.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/nxp/' for [email protected]:
arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dtb: pinctrl@80018000: compatible: ['fsl,imx28-pinctrl', 'simple-bus'] is too long
from schema $id: http://devicetree.org/schemas/gpio/gpio-mxs.yaml#arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: sram@20000000: '#address-cells' is a required property
from schema $id: http://devicetree.org/schemas/sram/sram.yaml#arch/arm/boot/dts/nxp/imx/imx6q-gw52xx.dtb: /soc/bus@2100000/mipi@21dc000: failed to match any schema with compatible: ['fsl,imx6-mipi-csi2'] arch/arm/boot/dts/nxp/imx/imx6dl-hummingboard2-emmc-som-v15.dtb: /soc/bus@2100000/mipi@21dc000: failed to match any schema with compatible: ['fsl,imx6-mipi-csi2'] arch/arm/boot/dts/nxp/imx/imx6dl-tx6u-8033.dtb: /soc/bus@2100000/mipi@21dc000: failed to match any schema with compatible: ['fsl,imx6-mipi-csi2'] arch/arm/boot/dts/nxp/imx/imx6dl-colibri-iris-v2.dtb: /capture-subsystem: failed to match any schema with compatible: ['fsl,imx-capture-subsystem'] arch/arm/boot/dts/nxp/imx/imx6qp-tx6qp-8037-mb7.dtb: gpio-keys: 'power' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
Shawn Guo
AppliedQuoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
On the i.MX5 chips the peripheral interrupts are represented directly only by their interrupt numbers.
The CCM nodes are not following this format and cause the following dt-schema warnings:
Quoted 7 lines
ccm@73fd4000: interrupts: [[0], [71], [4], [0], [72], [4]] is too long
Fix it by passing only the two interrupt numbers.
Run-time tested in on an imx53-qsb board.
Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks!