Skip to contentSkip to conversation

timekeeping: Remove unused ktime_get_fast_timestamps

PATCH Applied [email protected] 2 participants 2 messages Jan 12, 2025 – Jan 15, 2025 Timekeeping, clocksource core, NTP, alarmtimer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 timekeeping: Remove unused ktime_get_fast_timestamps

From: "Dr. David Alan Gilbert" <[email protected]>

ktime_get_fast_timestamps() was added in 2020 by
commit e2d977c9f1ab ("timekeeping: Provide multi-timestamp accessor to NMI safe timekeeper")

but has remained unused.

Remove it.

(Perhaps it's worth just reverting the entire commit, the only bit left is the extra parameter on __ktime_get_real_fast which is now always NULL).

---
 include/linux/timekeeping.h | 15 -----------
 kernel/time/timekeeping.c   | 54 -------------------------------------
 2 files changed, 69 deletions(-)
include/linux/timekeeping.h +0 -15
index 0e035f675efe..542773650200 100644
@@ -263,18 +263,6 @@ extern bool timekeeping_rtc_skipresume(void);
 
 extern void timekeeping_inject_sleeptime64(const struct timespec64 *delta);
 
-/**
- * struct ktime_timestamps - Simultaneous mono/boot/real timestamps
- * @mono:	Monotonic timestamp
- * @boot:	Boottime timestamp
- * @real:	Realtime timestamp
- */
-struct ktime_timestamps {
-	u64		mono;
-	u64		boot;
-	u64		real;
-};
-
 /**
  * struct system_time_snapshot - simultaneous raw/real time capture with
  *				 counter value
@@ -345,9 +333,6 @@ extern int get_device_system_crosststamp(
  */
 extern void ktime_get_snapshot(struct system_time_snapshot *systime_snapshot);
 
-/* NMI safe mono/boot/realtime timestamps */
-extern void ktime_get_fast_timestamps(struct ktime_timestamps *snap);
-
 /*
  * Persistent clock related interfaces
  */
kernel/time/timekeeping.c +0 -54

60 lines not on this page · raw message

Signature · 1 line
2.47.1
#1 lore raw

[tip: timers/core] timekeeping: Remove unused ktime_get_fast_timestamps()

The following commit has been merged into the timers/core branch of tip:

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     2d2a46cf23788a19e5450c6f9c86ab17f596c708
Gitweb:        https://git.kernel.org/tip/2d2a46cf23788a19e5450c6f9c86ab17f596c708
Author:        Dr. David Alan Gilbert <[email protected]>
AuthorDate:    Sun, 12 Jan 2025 16:01:32 
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Wed, 15 Jan 2025 19:49:14 +01:00

timekeeping: Remove unused ktime_get_fast_timestamps()

ktime_get_fast_timestamps() was added in 2020 by commit e2d977c9f1ab ("timekeeping: Provide multi-timestamp accessor to NMI safe timekeeper") but has remained unused.

Remove it.

[ tglx: Fold the inline as David suggested in the submission ]

---
 include/linux/timekeeping.h | 15 +-------
 kernel/time/timekeeping.c   | 77 +++---------------------------------
 2 files changed, 8 insertions(+), 84 deletions(-)
include/linux/timekeeping.h +0 -15
index 0e035f6..5427736 100644
@@ -264,18 +264,6 @@ extern bool timekeeping_rtc_skipresume(void);
 extern void timekeeping_inject_sleeptime64(const struct timespec64 *delta);
 
 /**
- * struct ktime_timestamps - Simultaneous mono/boot/real timestamps
- * @mono:	Monotonic timestamp
- * @boot:	Boottime timestamp
- * @real:	Realtime timestamp
- */
-struct ktime_timestamps {
-	u64		mono;
-	u64		boot;
-	u64		real;
-};
-
-/**
  * struct system_time_snapshot - simultaneous raw/real time capture with
  *				 counter value
  * @cycles:	Clocksource counter value to produce the system times
@@ -345,9 +333,6 @@ extern int get_device_system_crosststamp(
  */
 extern void ktime_get_snapshot(struct system_time_snapshot *systime_snapshot);
 
-/* NMI safe mono/boot/realtime timestamps */
-extern void ktime_get_fast_timestamps(struct ktime_timestamps *snap);
-
 /*
  * Persistent clock related interfaces
  */
kernel/time/timekeeping.c +8 -69

99 lines not on this page · raw message