nilfs2-protect-access-to-buffers-with-no-active-references.patch removed from -mm tree
The quilt patch titled
Subject: nilfs2: protect access to buffers with no active references
has been removed from the -mm tree. Its filename was
nilfs2-protect-access-to-buffers-with-no-active-references.patch
This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Ryusuke Konishi <[email protected]>
Subject: nilfs2: protect access to buffers with no active references
Date: Wed, 8 Jan 2025 05:00:47 +0900
nilfs_lookup_dirty_data_buffers(), which iterates through the buffers attached to dirty data folios/pages, accesses the attached buffers without locking the folios/pages.
For data cache, nilfs_clear_folio_dirty() may be called asynchronously when the file system degenerates to read only, so nilfs_lookup_dirty_data_buffers() still has the potential to cause use after free issues when buffers lose the protection of their dirty state midway due to this asynchronous clearing and are unintentionally freed by try_to_free_buffers().
Eliminate this race issue by adjusting the lock section in this function.
---
fs/nilfs2/segment.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/nilfs2/segment.c renamed from fs/nilfs2/segment.c~nilfs2-protect-access-to-buffers-with-no-active-references +3 -1
@@ -734,7 +734,6 @@ static size_t nilfs_lookup_dirty_data_buif (!head) head =create_empty_buffers (folio,i_blocksize (inode),0 ); -folio_unlock (folio); bh = head; do {
@@ -744,11 +743,14 @@ static size_t nilfs_lookup_dirty_data_bulist_add_tail (&bh->b_assoc_buffers, listp); ndirties++;if (unlikely (ndirties >= nlimit)) { +folio_unlock (folio);folio_batch_release (&fbatch);cond_resched ();return ndirties; } }while (bh = bh->b_this_page, bh != head); + +folio_unlock (folio); }folio_batch_release (&fbatch);cond_resched ();
_
Patches currently in -mm which might be from [email protected] are