Skip to contentSkip to conversation

toolchain/toolchain-external/toolchain-external-synopsys-arc: fix condition

PATCH In review Thomas Petazzoni 3 participants 3 messages Jan 13, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 toolchain/toolchain-external/toolchain-external-synopsys-arc: fix condition

The option BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC just depends on BR2_arc, but the choice of toolchains that appears once BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC=y only has choices for:

	depends on BR2_arc750d || BR2_arc770d

and

	depends on BR2_archs38_64mpy || BR2_archs38_full || \
		BR2_archs4x_rel31 || BR2_archs4x

which means that if you have a BR2_archs38=y configuration, you end up with no choice of toolchain, and the build fails with "No C library selected". Fix this by making sure BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC can only be selected when an actual toolchain is available.

---
 .../toolchain-external-synopsys-arc/Config.in                 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in +3 -1
index dc333f8474..98bfc2513c 100644
@@ -1,6 +1,8 @@
 config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC
 	bool "Synopsys ARC 2024.06 toolchain"
-	depends on BR2_arc
+	depends on BR2_arc750d || BR2_arc770d || \
+		BR2_archs38_64mpy || BR2_archs38_full || \
+		BR2_archs4x_rel31 || BR2_archs4x
 	depends on BR2_HOSTARCH = "x86_64"
 	depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_15
 	select BR2_INSTALL_LIBSTDCPP
Signature · 6 lines
2.47.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 toolchain/toolchain-external/toolchain-external-synopsys-arc: mark as broken

The ARC toolchains from Synopsys unfortunately are not "pure"
toolchains: their sysroot no only contains the C library, but also additional libraries, most notably libncurses and libexpat.

This confuses Buildroot, and causes build issues, and is anyway not a supported situation. Until the toolchains get fixed, let's mark them as broken.

Fixes:

http://autobuild.buildroot.net/results/38766332c391ce97a566c6e2255a947e6074152b/
(and possibly a number of others)

---
 .../toolchain-external-synopsys-arc/Config.in                 | 4 ++++
 1 file changed, 4 insertions(+)
toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in +4 -0
index 98bfc2513c..07688a1416 100644
@@ -5,6 +5,10 @@ config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC
 		BR2_archs4x_rel31 || BR2_archs4x
 	depends on BR2_HOSTARCH = "x86_64"
 	depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_15
+	# The toolchains have libncurses and libexpat in their
+	# sysroot, confusing Buildroot and causing build
+	# issues. Disable until the toolchains get fixed.
+	depends on BR2_BROKEN
 	select BR2_INSTALL_LIBSTDCPP
 	select BR2_TOOLCHAIN_HAS_SSP
 	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_16
Signature · 6 lines
2.47.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Thomas Petazzoni
Quoted 11 lines · Thomas Petazzoni

The option BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC just depends on BR2_arc, but the choice of toolchains that appears once BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC=y only has choices for:

	depends on BR2_arc750d || BR2_arc770d

and

	depends on BR2_archs38_64mpy || BR2_archs38_full || \
		BR2_archs4x_rel31 || BR2_archs4x
Quoted 6 lines

which means that if you have a BR2_archs38=y configuration, you end up with no choice of toolchain, and the build fails with "No C library selected". Fix this by making sure BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC can only be selected when an actual toolchain is available.

Series applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot