Skip to contentSkip to conversation

i2c: amd756: Remove TODO

PATCH In review Atharva Tiwari 2 participants 2 messages Jan 13, 2025 – Jan 14, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: amd756: Remove TODO

removing TODO in i2c-amd756.c because Andi Shyti said on
https://lore.kernel.org/all/ovddzx2zitp6lqjdasinn2zaaefp35y4mspol3v3x5rk3tddgo@kgcwexuai2ir/
: "I think the real solution would be to just remove the comments altogether" so yeah this patch just removes TODO

---
 drivers/i2c/busses/i2c-amd756.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-amd756.c +2 -2
index fa0d5a2c3732..3621c02f1cba 100644
@@ -211,7 +211,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr,
 		       SMB_HOST_ADDRESS);
 		outb_p(command, SMB_HOST_COMMAND);
 		if (read_write == I2C_SMBUS_WRITE)
-			outw_p(data->word, SMB_HOST_DATA);	/* TODO: endian???? */
+			outw_p(data->word, SMB_HOST_DATA);
 		size = AMD756_WORD_DATA;
 		break;
 	case I2C_SMBUS_BLOCK_DATA:
@@ -256,7 +256,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr,
 		data->byte = inw_p(SMB_HOST_DATA);
 		break;
 	case AMD756_WORD_DATA:
-		data->word = inw_p(SMB_HOST_DATA);	/* TODO: endian???? */
+		data->word = inw_p(SMB_HOST_DATA);
 		break;
 	case AMD756_BLOCK_DATA:
 		data->block[0] = inw_p(SMB_HOST_DATA) & 0x3f;
Signature · 1 line
2.43.0
#1 lore raw
Quoted 7 lines · Atharva Tiwari

removing TODO in i2c-amd756.c because Andi Shyti said on
https://lore.kernel.org/all/ovddzx2zitp6lqjdasinn2zaaefp35y4mspol3v3x5rk3tddgo@kgcwexuai2ir/
: "I think the real solution would be to just remove the comments altogether" so yeah this patch just removes TODO

Reverted your original commit, reworded the commit message (please check how once I pushed out) and applied to for-next, thanks!