Skip to contentSkip to conversation

sparc/irq: Use str_enabled_disabled() helper function

PATCH In review Thorsten Blum 2 participants 2 messages Jan 15, 2025 – Jan 17, 2025 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc/irq: Use str_enabled_disabled() helper function

Remove hard-coded strings by using the str_enabled_disabled() helper function.

---
 arch/sparc/kernel/irq_64.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/sparc/kernel/irq_64.c +2 -1
index 01ee800efde3..aff0d24f8c6f 100644
@@ -22,6 +22,7 @@
 #include <linux/seq_file.h>
 #include <linux/ftrace.h>
 #include <linux/irq.h>
+#include <linux/string_choices.h>
 
 #include <asm/ptrace.h>
 #include <asm/processor.h>
@@ -170,7 +171,7 @@ static void __init irq_init_hv(void)
 
 	pr_info("SUN4V: Using IRQ API major %d, cookie only virqs %s\n",
 		hv_irq_version,
-		sun4v_cookie_only_virqs() ? "enabled" : "disabled");
+		str_enabled_disabled(sun4v_cookie_only_virqs()));
 }
 
 /* This function is for the timer interrupt.*/
Signature · 1 line
2.47.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 21 lines · Thorsten Blum

Remove hard-coded strings by using the str_enabled_disabled() helper function.

---
 arch/sparc/kernel/irq_64.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/sparc/kernel/irq_64.c +1 -0
index 01ee800efde3..aff0d24f8c6f 100644
@@ -22,6 +22,7 @@
 #include <linux/seq_file.h>
 #include <linux/ftrace.h>
 #include <linux/irq.h>
+#include <linux/string_choices.h>
 
 #include <asm/ptrace.h>
 #include <asm/processor.h>

arch/sparc/kernel/irq_64.c static void __init irq_init_hv(void) · line 177

Quoted 8 lines
arch/sparc/kernel/irq_64.c +1 -1
@@ -170,7 +171,7 @@ static void __init irq_init_hv(void)
 
 	pr_info("SUN4V: Using IRQ API major %d, cookie only virqs %s\n",
 		hv_irq_version,
-		sun4v_cookie_only_virqs() ? "enabled" : "disabled");
+		str_enabled_disabled(sun4v_cookie_only_virqs()));
 }
 
 /* This function is for the timer interrupt.*/

Picking this up to my for-next.

Thanks,
Andreas