Skip to contentSkip to conversation

xfs: remove an out of data comment in _xfs_buf_alloc

PATCH Applied Christoph Hellwig 3 participants 3 messages Jan 16, 2025 – Jan 28, 2025 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: remove an out of data comment in _xfs_buf_alloc

There hasn't been anything like an io_length for a long time.

---
 fs/xfs/xfs_buf.c | 5 -----
 1 file changed, 5 deletions(-)
fs/xfs/xfs_buf.c +0 -5
index dc219678003c..af3945bf7d94 100644
@@ -241,11 +241,6 @@ _xfs_buf_alloc(
 	bp->b_mount = target->bt_mount;
 	bp->b_flags = flags;
 
-	/*
-	 * Set length and io_length to the same value initially.
-	 * I/O routines should use io_length, which will be the same in
-	 * most cases but may be reset (e.g. XFS recovery).
-	 */
 	error = xfs_buf_get_maps(bp, nmaps);
 	if (error)  {
 		kmem_cache_free(xfs_buf_cache, bp);
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Christoph Hellwig

There hasn't been anything like an io_length for a long time.

Yep, that old comment doesn't make much sense anymore

--D

Quoted 24 lines
---
 fs/xfs/xfs_buf.c | 5 -----
 1 file changed, 5 deletions(-)
fs/xfs/xfs_buf.c +0 -5
index dc219678003c..af3945bf7d94 100644
@@ -241,11 +241,6 @@ _xfs_buf_alloc(
 	bp->b_mount = target->bt_mount;
 	bp->b_flags = flags;
 
-	/*
-	 * Set length and io_length to the same value initially.
-	 * I/O routines should use io_length, which will be the same in
-	 * most cases but may be reset (e.g. XFS recovery).
-	 */
 	error = xfs_buf_get_maps(bp, nmaps);
 	if (error)  {
 		kmem_cache_free(xfs_buf_cache, bp);
Signature · 1 line
2.45.2
maintainer Applied
#2 lore raw
In reply to Christoph Hellwig
Quoted 3 lines · Christoph Hellwig

There hasn't been anything like an io_length for a long time.

Applied to for-next, thanks!

[1/1] xfs: remove an out of data comment in _xfs_buf_alloc

      commit: 89841b23809f5fb12cbead142204064739fef25a

Best regards,

Signature · 1 line
Carlos Maiolino <[email protected]>