Skip to contentSkip to conversation

linux-next: build warning after merge of the mm-stable tree

DISCUSSION Stephen Rothwell 2 participants 3 messages Jan 16, 2025 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the mm-stable tree, today's linux-next build (htmldocs) produced this warning:

include/linux/seqlock.h:341: warning: Function parameter or struct member 'start' not described in 'raw_seqcount_try_begin'

Introduced by commit

dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")

I seem to have missed this when it was first introduced, sorry.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 7 lines · Stephen Rothwell

Hi all,

After merging the mm-stable tree, today's linux-next build (htmldocs) produced this warning:

include/linux/seqlock.h:341: warning: Function parameter or struct member 'start' not described in 'raw_seqcount_try_begin'

Oops. Thanks for catching this! It should be:

@start: count to be passed to read_seqcount_retry()

Should I send a fixup to Andrew for inclusion into the mm tree?

Quoted 10 lines

Introduced by commit

dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")

I seem to have missed this when it was first introduced, sorry.

--
Cheers,
Stephen Rothwell

#2 lore raw
Quoted 8 lines · Suren Baghdasaryan
Quoted 6 lines · Stephen Rothwell

Hi all,

After merging the mm-stable tree, today's linux-next build (htmldocs) produced this warning:

Quoted 7 lines
Quoted 1 line

include/linux/seqlock.h:341: warning: Function parameter or struct member 'start' not described in 'raw_seqcount_try_begin'

Oops. Thanks for catching this! It should be:

@start: count to be passed to read_seqcount_retry()

Should I send a fixup to Andrew for inclusion into the mm tree?

I posted the fix at
https://lore.kernel.org/all/[email protected]/
in case it's needed.

Quoted 11 lines
Quoted 11 lines

Introduced by commit

dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")

I seem to have missed this when it was first introduced, sorry.

--
Cheers,
Stephen Rothwell